Changeset 10299

Show
Ignore:
Timestamp:
09/23/10 13:28:13 (3 years ago)
Author:
p_lindheimer
Message:

fixes #4553 Security Issue

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • modules/branches/2.8/recordings/module.xml

    r9809 r10299  
    22  <rawname>recordings</rawname> 
    33  <name>Recordings</name> 
    4   <version>3.3.10.0</version> 
     4  <version>3.3.10.1</version> 
    55  <publisher>FreePBX</publisher> 
    66  <license>GPLv2+</license> 
    …… 
    1111  <description>Creates and manages system recordings, used by many other modules (eg, IVR).</description> 
    1212  <changelog> 
     13    *3.3.10.1* #4553 Security Patch 
    1314    *3.3.10.0* #4244, #4309 
    1415    *3.3.9.4* localizations 

  • modules/branches/2.8/recordings/page.recordings.php

    r9786 r10299  
    4444$astsnd .= "/sounds/"; 
    4545 
    46 if (empty($usersnum)) { 
     46// check ctype_digit() to avoid very obscure vulnerability that can be made if certain proxy's are used 
     47// with the PBX system 
     48if (empty($usersnum) || !ctype_digit($usersnum)) { 
    4749  $dest = "unnumbered-"; 
    4850} else { 
    …… 
    198200  <?php 
    199201  if (isset($_FILES['ivrfile']['tmp_name']) && is_uploaded_file($_FILES['ivrfile']['tmp_name'])) { 
    200    if (empty($usersnum)) { 
     202    if (empty($usersnum) || !ctype_digit($usersnum)) { 
    201203      $dest = "unnumbered-"; 
    202204    } else {