Changeset 10463

Show
Ignore:
Timestamp:
11/01/10 15:34:33 (2 years ago)
Author:
p_lindheimer
Message:

Merged revisions 10462 via svnmerge from
http://www.freepbx.org/v2/svn/modules/branches/2.4

................

r10462 | p_lindheimer | 2010-11-01 13:25:23 -0700 (Mon, 01 Nov 2010) | 53 lines


Merged revisions 10461 via svnmerge from
http://www.freepbx.org/v2/svn/modules/branches/2.5


................

r10461 | p_lindheimer | 2010-11-01 13:13:34 -0700 (Mon, 01 Nov 2010) | 46 lines


Merged revisions 10460 via svnmerge from
http://www.freepbx.org/v2/svn/modules/branches/2.6


................

r10460 | p_lindheimer | 2010-11-01 13:02:25 -0700 (Mon, 01 Nov 2010) | 39 lines


Merged revisions 10399-10418,10420-10422,10424-10426,10428-10429,10432,10436-10458 via svnmerge from
http://www.freepbx.org/v2/svn/modules/branches/2.7


................

r10399 | GameGamer?43 | 2010-10-14 10:05:48 -0700 (Thu, 14 Oct 2010) | 1 line


closes #4590 - fixes issues with phonebook import

................

r10457 | p_lindheimer | 2010-11-01 12:46:35 -0700 (Mon, 01 Nov 2010) | 24 lines


Merged revisions 10456 via svnmerge from
http://svn.freepbx.org/modules/branches/2.8


................

r10456 | p_lindheimer | 2010-11-01 12:39:25 -0700 (Mon, 01 Nov 2010) | 17 lines


Merged revisions 10444,10447,10449-10451,10453-10455 via svnmerge from
http://svn.freepbx.org/modules/branches/2.9


........

r10444 | mbrevda | 2010-10-25 05:43:18 -0700 (Mon, 25 Oct 2010) | 1 line


re #4604 - potential injection when uploading files. Can be closed by when published/backported

........

r10454 | p_lindheimer | 2010-11-01 10:51:02 -0700 (Mon, 01 Nov 2010) | 1 line


block xss re #4615

........

r10455 | p_lindheimer | 2010-11-01 12:12:39 -0700 (Mon, 01 Nov 2010) | 1 line


changes to some of the fixes re #4604

........

................

................

r10458 | p_lindheimer | 2010-11-01 12:49:10 -0700 (Mon, 01 Nov 2010) | 1 line


update xml re #4590

................

................

................

................

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • modules/branches/2.3

    • Property svnmerge-integrated changed from /modules/branches/2.2:1-3588,3615-3635,3637-3638,3640,3674,3680,3686,3692,3702,3706,3710,3716,3758,3760,3762-3765,3767-3785,3787-3789,3801,3810,3828,3831,3839,3860,3866,3875,3877,3887,3899,3911,3913,3943,3982-3983,3990,3998,4007,4022-4023,4089,4092,4098,4265,4285 /modules/branches/2.4:1-5079,5090,5093,5097-5118,5120-5170,5172,5174,5176-5182,5184-5199,5202-5203,5205-5211,5239,5271-5272,5312,5383,5516,5544-5545,5548-5549,5555,5564,5570,5572-5574,5576-5578,5596,5606-5610,5612,5615-5618,5623-5624,5628,5630-5642,5644-5646,5648-5651,5653-5654,5656-5657,5660,5687-5699,5701-5702,5704-5715,5723-5727,5729-5730,5733-5741,5752-5753,5756,5830-5831,5842-5843,5881,6280,7876,7881,7887,7892,10303,10343 to /modules/branches/2.2:1-3588,3615-3635,3637-3638,3640,3674,3680,3686,3692,3702,3706,3710,3716,3758,3760,3762-3765,3767-3785,3787-3789,3801,3810,3828,3831,3839,3860,3866,3875,3877,3887,3899,3911,3913,3943,3982-3983,3990,3998,4007,4022-4023,4089,4092,4098,4265,4285 /modules/branches/2.4:1-5079,5090,5093,5097-5118,5120-5170,5172,5174,5176-5182,5184-5199,5202-5203,5205-5211,5239,5271-5272,5312,5383,5516,5544-5545,5548-5549,5555,5564,5570,5572-5574,5576-5578,5596,5606-5610,5612,5615-5618,5623-5624,5628,5630-5642,5644-5646,5648-5651,5653-5654,5656-5657,5660,5687-5699,5701-5702,5704-5715,5723-5727,5729-5730,5733-5741,5752-5753,5756,5830-5831,5842-5843,5881,6280,7876,7881,7887,7892,10303,10343,10462
  • modules/branches/2.3/core/module.xml

    r9402 r10463  
    44  <category>Basic</category> 
    55  <name>Core</name> 
    6   <version>2.3.1.5</version> 
     6  <version>2.3.1.6</version> 
    77  <candisable>no</candisable> 
    88  <canuninstall>no</canuninstall> 
    99  <changelog> 
     10    *2.3.1.6* #4615 (Security Bug) 
    1011    *2.3.1.5* #4075 
    1112    *2.3.1.4* #2607 fix display problems with custom trunks starting with A, M or P 
  • modules/branches/2.3/core/page.trunks.php

    r7882 r10463  
    1818$extdisplay=isset($_REQUEST['extdisplay'])?$_REQUEST['extdisplay']:''; 
    1919$action = isset($_REQUEST['action'])?$_REQUEST['action']:''; 
    20 $tech = strtolower(isset($_REQUEST['tech'])?$_REQUEST['tech']:''); 
     20$tech = strtolower(isset($_REQUEST['tech'])?htmlentities($_REQUEST['tech']):''); 
    2121 
    2222$trunknum = ltrim($extdisplay,'OUT_'); 
  • modules/branches/2.3/music/module.xml

    r5999 r10463  
    22  <rawname>music</rawname> 
    33  <name>Music on Hold</name> 
    4   <version>1.5.1.6</version> 
     4  <version>1.5.1.7</version> 
    55  <candisable>no</candisable> 
    66  <canuninstall>no</canuninstall> 
     
    99  <description>Uploading and management of sound files (wav, mp3) to be used for on-hold music.</description> 
    1010  <changelog> 
     11    *1.5.1.7* #4615 (Security Bug) 
    1112    *1.5.1.6* #2773 change change from exec of rm to unlink to remove security vulnerability 
    1213    *1.5.1.5* #2193 moh path hardcoded 
  • modules/branches/2.3/music/page.music.php

    r5998 r10463  
    179179  $output = 0; 
    180180  $returncode = 0; 
     181  $mohfile = escapeshellcmd($mohfile); 
    181182  $origmohfile=$path_to_dir."/orig_".$mohfile; 
    182183  $newname = strtr($mohfile,"&", "_"); 
     
    281282      echo "<h5> PHP "._("Error Processing")."! "._("No file provided")." "._("Please select a file to upload")."</h5>"; 
    282283    } else { 
    283       echo "<h5> PHP "._("Error Processing")." ".$_FILES['mohfile']['name']."! "._("Check")." upload_max_filesize "._("in")." /etc/php.ini</h5>"; 
     284      echo "<h5> PHP "._("Error Processing")." ".htmlentities($_FILES['mohfile']['name'])."! "._("Check")." upload_max_filesize "._("in")." /etc/php.ini</h5>"; 
    284285    } 
    285286  } 
     
    289290    $process_err = process_mohfile($_FILES['mohfile']['name']); 
    290291    if (isset($process_err)) { 
    291       echo "<h5>"._("Error Processing").": \"$process_err\" for ".$_FILES['mohfile']['name']."!</h5>\n"; 
     292      echo "<h5>"._("Error Processing").": \"$process_err\" for ".htmlentities($_FILES['mohfile']['name'])."!</h5>\n"; 
    292293      echo "<h5>"._("This is not a fatal error, your Music on Hold may still work.")."</h5>\n"; 
    293294    } else { 
    294       echo "<h5>"._("Completed processing")." ".$_FILES['mohfile']['name']."!</h5>"; 
     295      echo "<h5>"._("Completed processing")." ".htmlentities($_FILES['mohfile']['name'])."!</h5>"; 
    295296    } 
    296297    needreload(); 
  • modules/branches/2.3/phonebook/module.xml

    r4936 r10463  
    22  <rawname>phonebook</rawname> 
    33  <name>Phonebook</name> 
    4   <version>1.1.5.7</version> 
     4  <version>1.1.5.8</version> 
    55  <description>Provides a phonebook for FreePBX, it can be used as base for Caller ID Lookup and Speed Dial</description> 
    66  <type>tool</type> 
     
    1212  <md5sum>ac2f7115bc943a66faa552dab0dd4dc6</md5sum> 
    1313  <changelog> 
     14    *1.1.5.8* #4590 
    1415    *1.1.5.7* changed categories 
    1516    *1.1.5.6* bump for rc1 
  • modules/branches/2.3/phonebook/page.phonebook.php

    r4767 r10463  
    5555            if (is_array($fields) && count($fields) == 3 && is_numeric($fields[2]) &&  ($fields[3] == '' || is_numeric($fields[3]))) { 
    5656              phonebook_del($fields[2], $numbers[$fields[2]]['speeddial']); 
    57               phonebook_add($fields[2], addslashes($fields[1]), $fields[3]); 
     57              phonebook_add(htmlentities($fields[2],ENT_QUOTES), addslashes(htmlentities($fields[1],ENT_QUOTES)), htmlentities($fields[3],ENT_QUOTES)); 
    5858              $i++; 
    5959            } 
  • modules/branches/2.3/recordings/module.xml

    r10354 r10463  
    22  <rawname>recordings</rawname> 
    33  <name>Recordings</name> 
    4   <version>3.3.5.7</version> 
     4  <version>3.3.5.8</version> 
    55  <candisable>no</candisable> 
    66  <canuninstall>no</canuninstall> 
     
    99  <description>Creates and manages system recordings, used by many other modules (eg, IVR).</description> 
    1010  <changelog> 
     11    *3.3.5.8* #4615 (Security Bug) 
    1112    *3.3.5.7* #4568 Security Patch 
    1213    *3.3.5.6* #4553 Security Patch 
  • modules/branches/2.3/recordings/page.recordings.php

    r10344 r10463  
    6262    break; 
    6363  case "recorded": 
    64     // Clean up the filename, take out any nasty characters 
     64    // Clean up the filename,suffix, take out any nasty characters 
    6565    $filename = escapeshellcmd(strtr($rname, '/ ', '__')); 
     66    $suffix = escapeshellcmd(strtr($suffix, '/ ', '__')); 
    6667    if (!file_exists($astsnd."custom")) { 
    6768      if (!mkdir($astsnd."custom", 0775)) {