Changeset 10466

Show
Ignore:
Timestamp:
11/01/10 17:06:43 (3 years ago)
Author:
p_lindheimer
Message:

Merged revisions 10465 via svnmerge from
http://svn.freepbx.org/freepbx/branches/2.6

................

r10465 | p_lindheimer | 2010-11-01 14:02:29 -0700 (Mon, 01 Nov 2010) | 16 lines


Merged revisions 10464 via svnmerge from
http://www.freepbx.org/v2/svn/freepbx/branches/2.7


................

r10464 | p_lindheimer | 2010-11-01 13:42:52 -0700 (Mon, 01 Nov 2010) | 9 lines


Merged revisions 10453 via svnmerge from
http://www.freepbx.org/v2/svn/freepbx/branches/2.8


........

r10453 | p_lindheimer | 2010-11-01 10:34:27 -0700 (Mon, 01 Nov 2010) | 1 line


fixes #4615 XSS to Module Admin

........

................

................

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • freepbx/branches/2.5

    • Property svnmerge-integrated changed from /freepbx/branches/2.4:1-5944 /freepbx/branches/2.6:1-7913,9512 to /freepbx/branches/2.4:1-5944 /freepbx/branches/2.6:1-7913,9512,10465
  • freepbx/branches/2.5/amp_conf/htdocs/admin/page.modules.php

    r7808 r10466  
    1616 
    1717// can't go online if external management is on 
    18 $online = (isset($_REQUEST['online']) && !EXTERNAL_PACKAGE_MANAGEMENT) ? $_REQUEST['online'] : false
     18$online = (isset($_REQUEST['online']) && !EXTERNAL_PACKAGE_MANAGEMENT) ? 1 : 0
    1919 
    2020// fix php errors from undefined variable. Not sure if we can just change the reference below to use 
    2121// online since it changes values so just setting to what we decided it is here. 
    22 $_REQUEST['online'] = $online ? 1 : 0; 
    2322 
    2423$moduleaction = isset($_REQUEST['moduleaction'])?$_REQUEST['moduleaction']:false; 
     
    121120    freepbx_modal_hide('moduleBox'); 
    122121    if (goback) { 
    123      location.href = 'config.php?display=modules&amp;type=tool&amp;online=<?php echo ($_REQUEST['online']?1:0); ?>'; 
     122      location.href = 'config.php?display=modules&amp;type=<?php echo $type ?>&amp;online=<?php echo $online; ?>'; 
    124123    } 
    125124  } 
     
    145144  if ($module_getonlinexml_error) { 
    146145    echo "<div class=\"warning\"><p>".sprintf(_("Warning: Cannot connect to online repository (%s). Online modules are not available."), "mirror.freepbx.org")."</p></div><br />"; 
    147     $online = false
     146    $online = 0
    148147    unset($modules_online); 
    149148  } else if (!is_array($modules_online)) { 
    150149    echo "<div class=\"warning\"><p>".sprintf(_("Warning: Error retrieving updates from online repository (%s). Online modules are not available."), "mirror.freepbx.org")."</p></div><br />"; 
    151     $online = false
     150    $online = 0
    152151    unset($modules_online); 
    153152  } else { 
     
    271270      echo "\t<a href=\"#\" onclick=\"parent.close_module_actions(true);\" />"._("Return")."</a>"; 
    272271    } else { 
    273       echo "\t<input type=\"button\" value=\""._("Return")."\" onclick=\"location.href = 'config.php?display=modules&amp;type=tool&amp;online=".($_REQUEST['online']?1:0)."';\" />"; 
     272      echo "\t<input type=\"button\" value=\""._("Return")."\" onclick=\"location.href = 'config.php?display=modules&amp;type=$type&amp;online=".$online."';\" />"; 
    274273    echo "</div>"; 
    275274    } 
     
    416415      echo "<p>"._("Please select at least one action to perform by clicking on the module, and selecting an action on the \"Action\" tab.")."</p>"; 
    417416    } 
    418     echo "\t<input type=\"button\" value=\""._("Cancel")."\" onclick=\"location.href = 'config.php?display=modules&amp;type=tool&amp;online=".($_REQUEST['online']?1:0)."';\" />"; 
     417    echo "\t<input type=\"button\" value=\""._("Cancel")."\" onclick=\"location.href = 'config.php?display=modules&amp;type=$type&amp;online=$online';\" />"; 
    419418    echo "</form>"; 
    420419