Changeset 11015 for modules/branches/2.8

Timestamp:

01/19/11 11:23:45 (2 years ago)

Author:

p_lindheimer

Message:

closes #4749 avoids Asterisk Security Vulnerability by setting a max on outbound CIDs that came in from the system and can cause overflow issues

Files:

• modules/branches/2.8/core/functions.inc.php (modified) (3 diffs)
• modules/branches/2.8/core/module.xml (modified) (2 diffs)

modules/branches/2.8/core/functions.inc.php

@@ -1459 +1459 @@
-          $ext->add($tcontext,$tcustom,'',new ext_gosubif('$["${PREFIX_TRUNK_${DIAL_TRUNK}}" != ""]','sub-flp-${DIAL_TRUNK},s,1'));
-          $ext->add($tcontext,$tcustom,'',new ext_set('OUTNUM', '${OUTPREFIX_${DIAL_TRUNK}}${DIAL_NUMBER}'));  // OUTNUM is the final dial number
+
+          // Address Security Vulnerability in many earlier versions of Asterisk from an external source tranmitting a
+          // malicious CID that can cause overflows in the Asterisk code.
+          //
+          $ext->add($tcontext, $tcustom, '', new ext_set('CALLERID(number)','${CALLERID(number):0:40}'));
+          $ext->add($tcontext, $tcustom, '', new ext_set('CALLERID(name)','${CALLERID(name):0:40}'));
+
-          $ext->add($tcontext,$tcustom,'',new ext_dial('${EVAL(${TDIAL_STRING})}','300,${DIAL_TRUNK_OPTIONS}'));
-          $ext->add($tcontext,$tcustom,'hangit',new ext_hangup());
@@ -1477 +1484 @@
-
-          $ext->add($tcontext,$texten,'',new ext_dial('${TDIAL_STRING}/${OUTNUM}','300,${DIAL_TRUNK_OPTIONS}'));
+          // Address Security Vulnerability in many earlier versions of Asterisk from an external source tranmitting a
+          // malicious CID that can cause overflows in the Asterisk code.
+          //
+          $ext->add($tcontext, $texten, '', new ext_set('CALLERID(number)','${CALLERID(number):0:40}'));
+          $ext->add($tcontext, $texten, '', new ext_set('CALLERID(name)','${CALLERID(name):0:40}'));
+
-          $ext->add($tcontext,$texten,'hangit',new ext_hangup());
-        }
@@ -2281 +2294 @@
-      $ext->add($context, $exten, '', new ext_macro('hangupcall'));
-      $ext->add($context, $exten, '', new ext_congestion(20));
-
+
+
+
+
+
+
+
+
-      $ext->add($context, 'h', '', new ext_macro('hangupcall'));
-      

modules/branches/2.8/core/module.xml

@@ -4 +4 @@
-  <category>Basic</category>
-  <name>Core</name>
-7
+8
-  <publisher>FreePBX</publisher>
-  <license>GPLv2+</license>
@@ -10 +10 @@
-  <canuninstall>no</canuninstall>
-  <changelog>
+    *2.8.0.8* #4749 (Avoid Asterisk Security Vulnerability)
-    *2.8.0.7* #4689, #4697, #4730
-    *2.8.0.6* #4634, #4453, #4563