Changeset 12961

Show
Ignore:
Timestamp:
11/15/11 08:07:36 (2 years ago)
Author:
mbrevda
Message:

re #5451 - abstract app_meetme to transparently support app_meetme OR app_confbridge

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • modules/branches/2.10/conferences/functions.inc.php

    r12324 r12961  
    8484*/ 
    8585function conferences_get_config($engine) { 
    86   global $ext;  // is this the best way to pass this? 
    87   global $conferences_conf; 
    88   global $version; 
    89   global $amp_conf; 
    90   global $astman; 
     86  global $ext, $conferences_conf, $version, $amp_conf, $astman; 
    9187   
    9288  $ast_ge_162 = version_compare($version, '1.6.2', 'ge'); 
    93   // Default to conference meetme 
    94   $confapp = 'ext_meetme'; 
    95   if ($ast_ge_162 && $amp_conf['AMPENGINE'] == 'asterisk' && isset($astman) && $astman->connected()) { 
    96     //check for meetme application and fallback to confbridge if possible 
    97     $app = $astman->send_request('Command', array('Command' => 'module show like meetme')); 
    98     if (preg_match('/[1-9] modules loaded/', $app['data'])){ 
    99       $confapp='ext_meetme'; 
    100     } else { 
    101       $app = $astman->send_request('Command', array('Command' => 'module show like confbridge')); 
    102       if (preg_match('/[1-9] modules loaded/', $app['data'])){         
    103         $confapp='ext_confbridge'; 
    104       } 
    105     } 
    106   } 
    10789   
    10890  switch($engine) { 
     
    122104        $ext->add($contextname, 'STARTMEETME', '', new ext_setvar('GROUP(meetme)','${MEETME_ROOMNUM}')); 
    123105        $ext->add($contextname, 'STARTMEETME', '', new ext_gotoif('$[${MAX_PARTICIPANTS} > 0 && ${GROUP_COUNT(${MEETME_ROOMNUM}@meetme)}>${MAX_PARTICIPANTS}]','MEETMEFULL,1')); 
    124         if ($confapp != 'ext_confbridge') { 
    125           $ext->add($contextname, 'STARTMEETME', '', new ext_meetme('${MEETME_ROOMNUM}','${MEETME_OPTS}','${PIN}')); 
    126         } else { 
    127           $ext->add($contextname, 'STARTMEETME', '', new ext_confbridge('${MEETME_ROOMNUM}','${MEETME_OPTS}','${PIN}')); 
    128         } 
     106        $ext->add($contextname, 'STARTMEETME', '', new ext_meetme('${MEETME_ROOMNUM}','${MEETME_OPTS}','${PIN}')); 
     107 
    129108        $ext->add($contextname, 'STARTMEETME', '', new ext_hangup('')); 
    130109 
  • modules/branches/2.10/conferences/install.php

    r11109 r12961  
    115115  out(_("already present")); 
    116116} 
     117 
     118 
    117119?> 
  • modules/branches/2.10/conferences/page.conferences.php

    r12445 r12961  
    8080  $astver =  $engineinfo['version']; 
    8181} 
    82 $ast_ge_162 = version_compare($astver, '1.6.2', 'ge'); 
    83 // Default to conference meetme 
    84 $confapp = 'ext_meetme'; 
    85 if ($ast_ge_162 && $amp_conf['AMPENGINE'] == 'asterisk' && isset($astman) && $astman->connected()) { 
    86       //check for meetme application and fallback to confbridge if possible 
    87   $app = $astman->send_request('Command', array('Command' => 'module show like meetme')); 
    88       if (preg_match('/[1-9] modules loaded/', $app['data'])){ 
    89     $confapp='ext_meetme'; 
    90   } else { 
    91     $app = $astman->send_request('Command', array('Command' => 'module show like confbridge')); 
    92     if (preg_match('/[1-9] modules loaded/', $app['data'])){        $confapp='ext_confbridge'; 
    93     } 
    94   } 
    95 } 
    9682 
    9783//get meetme rooms 
     
    232218$engineinfo = engine_getinfo(); 
    233219$astver =  $engineinfo['version']; 
    234  
    235 //If the application is confbridge remove options that aren't supported 
    236 if ($confapp=='ext_confbridge') { 
    237   str_replace("o","",$options); 
    238   str_replace("T","",$options); 
    239 
    240  
    241 if (version_compare($astver, '1.4', 'ge') && $confapp=='ext_meetme') { 
     220if (version_compare($astver, '1.4', 'ge') && $amp_conf['ASTCONFAPP']=='app_meetme') { 
    242221?> 
    243222  <tr> 
     
    273252  </tr> 
    274253<?php 
    275 
    276 ?> 
     254} else {//when using confbridge, hide option, but save it anyway 
     255  echo '<input type="hidden" name="opt#T" value="' . (strpos($options, "T") !== false ? 'T' : '') . '"'; 
     256  echo '<input type="hidden" name="opt#o" value="' . (strpos($options, "o") !== false ? 'o' : '') . '"'; 
     257}?> 
    277258  <tr> 
    278259    <td><a href="#" class="info"><?php echo _("Quiet Mode:")?><span><?php echo _("Quiet mode (do not play enter/leave sounds)")?></span></a></td> 
     
    300281  </tr> 
    301282  <?php 
    302     //If the application is confbridge remove options that aren't supported 
    303     if ($confapp=='ext_confbridge') { 
    304       str_replace("i","",$options); 
    305     } 
    306     if ($confapp=='ext_meetme') { 
     283    if ($amp_conf['ASTCONFAPP']=='app_meetme') { 
    307284  ?> 
    308285  <tr> 
     
    318295    </td> 
    319296  </tr> 
    320   <?php } ?> 
     297  <?php } else {//when using confbridge, hide option, but save it anyway 
     298    echo '<input type="hidden" name="opt#i" value="' . (strpos($options, "i") !== false ? 'i' : '') . '"'; 
     299  }?> 
    321300  <tr> 
    322301    <td><a href="#" class="info"><?php echo _("Music on Hold:")?><span><?php echo _("Enable Music On Hold when the conference has a single caller")?></span></a></td> 
     
    370349  </tr> 
    371350  <?php 
    372     //If the application is confbridge remove options that aren't supported 
    373     if ($confapp=='ext_confbridge') { 
    374       str_replace("r","",$options); 
    375     } 
    376     if ($confapp=='ext_meetme') { 
     351    if ($amp_conf['ASTCONFAPP'] == 'app_meetme') { 
    377352  ?> 
    378353  <tr> 
     
    388363    </td> 
    389364  </tr> 
    390   <?php } ?> 
     365  <?php } else {//when using confbridge, hide option, but save it anyway 
     366    echo '<input type="hidden" name="opt#r" value="' . (strpos($options, "r") !== false ? 'r' : '') . '"'; 
     367  }?> 
    391368  <?php //Begin Maximum Participants Code ?> 
    392369  <tr> 
  • modules/branches/2.10/paging/agi-bin/page.agi

    r12942 r12961  
    2929              'Async'     => 'true', 
    3030              'Set'     => 'AMPUSER=' . $vars['AMPUSER'], 
    31               'Application' => 'meetme'
     31              'Application' => ($amp_conf['ASTCONFAPP'] == 'meetme' ? 'meetme' : 'confbridge')
    3232              'Data'      => $vars['meetmeopts'] 
    3333              )); 
  • modules/branches/2.10/paging/functions.inc.php

    r12942 r12961  
    423423         
    424424        //if page group it in use, got to busy 
    425         $ext->add($apppaging, $grp, '',  
     425        $ext->add($apppaging, $grp, 'busy-check',  
    426426          new ext_gotoif('$[${TRYLOCK(apppaging'. $grp .')}]', '', 'busy')); 
    427427         
     
    432432        $ext->add($apppaging, $grp, '', new ext_answer('')); 
    433433        $ext->add($apppaging, $grp, '', new ext_set('PAGE_CONF', '${EPOCH}${RAND(100,999)}')); 
     434        $page_opts = $amp_conf['ASTCONFAPP'] == 'app_meetme' ? '1doqsx' : '1qs'; 
    434435        $ext->add($apppaging, $grp, '',  
    435           new ext_set('PAGE_CONF_OPTS', '1doqsx' . (!$thisgroup['duplex'] ? 'm' : ''))); 
     436          new ext_set('PAGE_CONF_OPTS', $page_opts . (!$thisgroup['duplex'] ? 'm' : ''))); 
    436437        $ext->add($apppaging, $grp, 'agi', new ext_agi('page.agi,' 
    437438                        . 'extensions=' . implode(':',$page_memebers) . ',' 
     
    446447        }*/          
    447448        unset($page_memebers); 
    448         $ext->add($apppaging, $grp, 'page', new ext_meetme('${PAGE_CONF},doqwxCAG(beep)')); 
     449        $ext->add($apppaging, $grp, 'page', new ext_meetme('${PAGE_CONF}', 'doqwxAG(beep)')); 
    449450        $ext->add($apppaging, $grp, '', new ext_hangup()); 
    450451        $ext->add($apppaging, $grp, 'busy', new ext_set('PAGE${PAGEGROUP}BUSY', 'TRUE')); 
     
    555556  $sql = "SELECT * FROM paging_config WHERE page_group='$grp'"; 
    556557  $results = $db->getRow($sql, DB_FETCHMODE_ASSOC); 
    557   if(DB::IsError($results)) { 
    558     $results = null
     558  if(!$results || DB::IsError($results)) { 
     559    return false
    559560  } 
    560561  $sql = "SELECT * FROM admin WHERE variable='default_page_grp' AND value='$grp'"; 
  • modules/branches/2.10/paging/module.xml

    r12942 r12961  
    33  <repo>standard</repo> 
    44  <name>Paging and Intercom</name> 
    5   <version>2.10.0.1</version> 
     5  <version>2.10.0.2</version> 
    66  <publisher>FreePBX</publisher> 
    77  <license>GPLv2+</license> 
    88  <category>Applications</category> 
    99  <changelog> 
    10     *2.10.0.1* #729 
     10    *2.10.0.1-2* #729 
    1111    *2.10.0.0* new version changes 
    1212    *2.9.0.5* #5000 
  • modules/branches/2.10/paging/page.paging.php

    r12942 r12961  
    114114    } 
    115115 
    116     $delURL = $_SERVER['PHP_SELF']."?type=${type}&amp;display=${display}&amp;action=delete&amp;extdisplay=${xtn}"; 
     116    $delURL = $_SERVER['PHP_SELF']."?display=${display}&amp;action=delete&amp;extdisplay=${xtn}"; 
    117117    $tlabel = sprintf(_("Delete Group %s"),$xtn); 
    118118    $label = '<span><img width="16" height="16" border="0" title="'.$tlabel.'" alt="" src="images/core_delete.png"/>&nbsp;'.$tlabel.'</span>'; 
     
    252252  echo "<div class='rnav'><ul>\n"; 
    253253  echo "<li><a id='".($extdisplay==''?'current':'std')."' "; 
    254   echo "href='config.php?type=${type}&amp;display=${display}&amp;action=add'>"._("Add Paging Group")."</a></li>";  
     254  echo "href='config.php?display=${display}&amp;action=add'>"._("Add Paging Group")."</a></li>";  
    255255  //get the list of paging groups 
    256256  $presults = paging_list(); 
     
    264264      $hl = $group == $default_grp ? _(' [DEFAULT]') : ''; 
    265265      echo "<li><a class=\"".($extdisplay==$group ? 'current':'std'); 
    266       echo "\" href=\"config.php?type=${type}&amp;display="; 
     266      echo "\" href=\"config.php?display="; 
    267267      echo "${display}&amp;extdisplay=${group}&amp;action=modify\">"; 
    268268      echo $group." ".((trim($grouparr['description']) != '')?htmlspecialchars($grouparr['description']):_("Page Group"))."$hl</a></li>";