Changeset 13908 for modules

Show
Ignore:
Timestamp:
03/26/12 13:02:04 (1 year ago)
Author:
mbrevda
Message:

closes #5707, #5315 - backup editing issues

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • modules/branches/2.10/backup/functions.inc/class.backup.php

    r13555 r13908  
    324324          $ftp = ftp_connect($s['host'], $s['port']); 
    325325          if (ftp_login($ftp, $s['user'], $s['password'])) { 
    326             //use pasive mode 
    327             ftp_pasv($ftp, true); 
     326            //chose pasive/active transfer mode 
     327            ftp_pasv($ftp, ($s['transfer'] == 'passive')); 
    328328             
    329329            //switch to directory. If we fail, build directory structure and try again 
  • modules/branches/2.10/backup/functions.inc/servers.php

    r12414 r13908  
    2323    'password'  => '', 
    2424    'path'    => '', 
     25    'transfer'  => 'passive', 
    2526    'type'    => 'ftp', 
    2627    'readonly'  => array(), 
     
    7576  //dont delete if deleting has been blocked 
    7677  $immortal = $db->getOne('SELECT immortal FROM backup_servers WHERE id = ?', $id); 
     78  db_e($immortal); 
    7779  if ($immortal && $immortal == 'true') { 
    7880    return $id; 
    79   } else { 
    80     return false;//db error 
    8181  } 
    8282   
    8383  $sql = 'DELETE FROM backup_servers WHERE id = ?'; 
    8484  $ret = $db->query($sql, $id); 
    85   if ($db->IsError($ret)){ 
    86     die_freepbx($ret->getDebugInfo()); 
    87   } 
     85  db_e($ret); 
    8886   
    8987  $sql = 'DELETE FROM backup_server_details WHERE server_id = ?'; 
    9088  $ret = $db->query($sql, $id); 
    91   if ($db->IsError($ret)){ 
    92     die_freepbx($ret->getDebugInfo()); 
    93   } 
     89  db_e($ret); 
    9490   
    9591  //delete from backups_details 
    9692  $sql = 'DELETE FROM backup_details WHERE `key` = "storage_servers" and value = ?'; 
    9793  $ret = $db->query($sql, $id); 
    98   if ($db->IsError($ret)){ 
    99     die_freepbx($ret->getDebugInfo()); 
    100   } 
     94  db_e($ret); 
    10195   
    10296  //delete from backups_items 
    103   $sql = 'DELETE FROM backup_details WHERE type = "mysql" AND path = CONCAT("server-", ?)'; 
    104   $ret = $db->query($sql, $id); 
    105   if ($db->IsError($ret)){ 
    106     die_freepbx($ret->getDebugInfo()); 
    107   } 
     97  $sql = 'DELETE FROM backup_items WHERE type = "mysql" AND path = CONCAT("server-", ?)'; 
     98  $ret = $db->query($sql, $id); 
     99  db_e($ret); 
    108100   
    109101  //delete from templates 
    110102  $sql = 'DELETE FROM backup_template_details WHERE type = "mysql" AND path = CONCAT("server-", ?)'; 
    111103  $ret = $db->query($sql, $id); 
    112   dbug('temp', $db->last_query); 
    113   if ($db->IsError($ret)){ 
    114     die_freepbx($ret->getDebugInfo()); 
    115   } 
     104  //dbug('temp', $db->last_query); 
     105  db_e($ret); 
    116106   
    117107  return ''; 
     
    175165            array($var['id'], 'user', $var['user']), 
    176166            array($var['id'], 'path', $var['path']), 
    177             array($var['id'], 'password', $var['password']) 
     167            array($var['id'], 'password', $var['password']), 
     168            array($var['id'], 'transfer', $var['transfer']) 
    178169          ); 
    179170      break; 
  • modules/branches/2.10/backup/functions.inc/templates.php

    r13482 r13908  
    1212  $sql = 'DELETE FROM backup_templates WHERE id = ?'; 
    1313  $ret = $db->query($sql, $id); 
    14   if ($db->IsError($ret)){ 
    15     die_freepbx($ret->getDebugInfo()); 
    16   } 
     14  db_e($ret); 
    1715   
    1816  $sql = 'DELETE FROM backup_template_details WHERE template_id = ?'; 
    1917  $ret = $db->query($sql, $id); 
    20   if ($db->IsError($ret)){ 
    21     die_freepbx($ret->getDebugInfo()); 
    22   } 
     18  db_e($ret); 
    2319   
    2420  /*todo: select servers from backups 
  • modules/branches/2.10/backup/page.backup_servers.php

    r12848 r13908  
    2121        'server_type' => '', 
    2222        'submit'    => '', 
     23        'transfer'    => '', 
    2324        'type'      => ''  
    2425        ); 
  • modules/branches/2.10/backup/page.backup_templates.php

    r12848 r13908  
    11<?php  
    22if (!defined('FREEPBX_IS_AUTH')) { die('No direct script access allowed'); } 
     3dbug($_REQUEST); 
    34$get_vars = array( 
    45        'action'  => '', 
     
    4243  case 'save': 
    4344    $var = array_merge($var, backup_get_template($var['id'])); 
     45     
     46    //template id's are all prefixed by their module name for hooking reasons. Clear that past this point 
     47    if (strpos($var['id'], 'backup-') === 0) { 
     48      $var['id'] = substr($var['id'], 7); 
     49    } 
     50 
    4451    echo load_view(dirname(__FILE__) . '/views/templates/template.php', $var); 
    4552    break; 
  • modules/branches/2.10/backup/views/servers/ftp.php

    r12445 r13908  
    7070$label  = fpbx_label(_('Path'), _('Path where files are stored')); 
    7171$data   = array( 
    72       'name' => 'path',  
    73       'value' => $path 
     72      'name' => 'path',  
     73      'value'  => $path, 
    7474    ); 
    7575$data = backup_server_writeable('path', $readonly, $data); 
    7676$table->add_row($label, form_input($data)); 
     77 
     78//connection type key 
     79$label  = fpbx_label(_('Transfer Mode')); 
     80$lableactive = form_label('Active', 'transferactive'); 
     81$active = array( 
     82      'name'  => 'transfer',  
     83      'value' => 'active', 
     84      'id'  => 'transferactive' 
     85); 
     86$transfer == 'active' ? $active['checked'] = 'checked' : ''; 
     87$active = backup_server_writeable('transfer', $readonly, $active); 
     88$lablepassive = form_label('Passive', 'transferpassive'); 
     89$passive = array( 
     90      'name' => 'transfer',  
     91      'value' => 'passive', 
     92      'id'  => 'transferpassive' 
     93); 
     94$transfer == 'passive' ? $passive['checked'] = 'checked' : ''; 
     95$passive = backup_server_writeable('transfer', $readonly, $passive); 
     96$table->add_row($label,  
     97  '<span class="radioset">'  
     98    . $lableactive . form_radio($active) 
     99    . $lablepassive . form_radio($passive) 
     100  . '</span>'); 
    77101 
    78102$html .= $table->generate();