Changeset 13922

Timestamp:

03/27/12 11:46:48 (1 year ago)

Author:

p_lindheimer

Message:

fixes #5729 validate the callback number and also double check when pulling it from the AstDB in case it has been tampered with in there

Files:

• freepbx/branches/2.10/amp_conf/htdocs/recordings/includes/callme.php (modified) (3 diffs)

freepbx/branches/2.10/amp_conf/htdocs/recordings/includes/callme.php

@@ -53 +53 @@
-function callme_getnum($exten)
-{
-        
-        
+ 
+ 
-  $callme_num   = '';
-        
+ 
-
-  if (is_array($results))
@@ -79 +79 @@
-        global $astman;
-
+        $callme_num = preg_replace("/[^0-9*#+]/", "", $callme_num);
-        $cmd = "database put AMPUSER $exten/callmenum $callme_num";
-        $astman->Command($cmd);
@@ -89 +90 @@
-{
-  global $astman;
+
+  if (!preg_match("/^[0-9*#+]+$/",$to)) { 
+    freepbx_log(FPBX_LOG_SECURITY, sprintf(_('Malformed callme number passed to callme_startcall $to field could be Security Breach: %s'), $to));
+    return false;
+  }
+  if (!preg_match("/^[0-9]+$/",$from)) { 
+    freepbx_log(FPBX_LOG_SECURITY, sprintf(_('Malformed callme number passed to callme_startcall $from field could be Security Breach: %s'), $to));
+    return false;
+  }
+  // TODO: should I check that new_path is a valid sound file to play and bomb out if not as possible security protection?
+
-  $channel  = "Local/$to@from-internal/n";
-  $context  = "vm-callme";