Changeset 5913

Timestamp:

07/05/08 09:22:54 (5 months ago)

Author:

p_lindheimer

Message:

#2881 Add links to tickets and changeset references in changelog in Module Admin - from groogs drupal filter code

Files:

• freepbx/trunk/amp_conf/htdocs/admin/page.modules.php (modified) (2 diffs)

freepbx/trunk/amp_conf/htdocs/admin/page.modules.php

@@ -284 +284 @@
-}
-
+/* Replace '#nnn', 'bug nnn', 'ticket nnn' type ticket numbers in changelog with a link, taken from Greg's drupal filter
+*/
+function trac_replace_ticket($match) {
+  $baseurl = 'http://freepbx.org/trac/ticket/';
+  return '<a target="tractickets" href="'.$baseurl.$match[1].'" title="ticket '.$match[0].'">'.$match[0].'</a>';
+}
+
+/* Replace 'rnnn' changeset references to a link, taken from Greg's drupal filter
+*/
+function trac_replace_changeset($match) {
+  $baseurl = 'http://freepbx.org/trac/changeset/';
+  return '<a target="tractickets" href="'.$baseurl.$match[1].'" title="changeset '.$match[0].'">'.$match[0].'</a>';
+}                                                                                                                                              
+
-//--------------------------------------------------------------------------------------------------------
-switch ($extdisplay) {  // process, confirm, or nothing
@@ -789 +803 @@
-                                echo "\t\t\t\t<div class=\"tabbertab\" title=\""._("Changelog")."\">\n";
-                                echo "<h5>".sprintf(_("Change Log for version %s"), $modules[$name]['version'])."</h5>";
+
-                                // convert "1.x.x:" and "*1.x.x*" into bold, and do nl2br
+                                // TODO: need to fix this to convert 1.x.xbetax.x, 1.x.xalphax.x, 1.x.xrcx.x, 1.x.xRCx.x formats as well
+                                //
-                                $changelog = nl2br($modules[$name]['changelog']);
-                                $changelog = preg_replace('/(\d+(\.\d+)+):/', '<strong>$0</strong>', $changelog);
-                                $changelog = preg_replace('/\*(\d+(\.\d+)+)\*/', '<strong>$1:</strong>', $changelog);
+
+                                // convert '#xxx', 'ticket xxx', 'bug xxx' to ticket links and rxxx to changeset links in trac
+                                //
+                                $changelog = preg_replace_callback('/(?<!\w)(?:#|bug |ticket )([^&]\d{3,4})(?!\w)/i', 'trac_replace_ticket', $changelog);
+                                $changelog = preg_replace_callback('/(?<!\w)r(\d+)(?!\w)/', 'trac_replace_changeset', $changelog);
+                                $changelog = preg_replace_callback('/(?<!\w)\[(\d+)\](?!\w)/', 'trac_replace_changeset', $changelog);
+
-                                echo $changelog;
-                                echo "\t\t\t\t</div>\n";