Changeset 8275

Show
Ignore:
Timestamp:
09/05/09 16:21:20 (2 years ago)
Author:
p_lindheimer
Message:

fixes #3864, fixes #3865, fixes #3866 - php notices from undefined and other minor declaration probs

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • modules/branches/2.6/core/functions.inc.php

    r8269 r8275  
    52535253 
    52545254  $tech_hardware = isset($_REQUEST['tech_hardware'])?$_REQUEST['tech_hardware']:null; 
    5255   if ($devinfo_tech == 'virtual') { 
     5255  if (isset($devinfo_tech) && $devinfo_tech == 'virtual') { 
    52565256    return true; 
    52575257  } 
     
    53925392  extract($_REQUEST); 
    53935393 
    5394   if ($tech == "virtual") { 
     5394  if (isset($tech) && $tech == "virtual") { 
    53955395    return true; 
    53965396  } 
  • modules/branches/2.6/core/module.xml

    r8269 r8275  
    1010  <canuninstall>no</canuninstall> 
    1111  <changelog> 
    12     *2.6.0beta2.3* #3529 
     12    *2.6.0beta2.3* #3529, #3864 
    1313    *2.6.0beta2.2* #3722, #3848, #3841, #3700 
    1414    *2.6.0beta2.1* #3844 (revert #3423), #3846, #3849 
  • modules/branches/2.6/iaxsettings/functions.inc.php

    r8258 r8275  
    2525 
    2626/* Field Values for type field */ 
    27 define('NORMAL','0'); 
    28 define('CODEC','1'); 
    29 define('VIDEO_CODEC','2'); 
    30 define('CUSTOM','9'); 
     27define('IAX_NORMAL','0'); 
     28define('IAX_CODEC','1'); 
     29define('IAX_VIDEO_CODEC','2'); 
     30define('IAX_CUSTOM','9'); 
    3131 
    3232class iaxsettings_validate { 
     
    122122        foreach ($raw_settings as $var) { 
    123123          switch ($var['type']) { 
    124             case NORMAL: 
     124            case IAX_NORMAL: 
    125125              $interim_settings[$var['keyword']] = $var['data']; 
    126126            break; 
    127127 
    128             case CODEC: 
     128            case IAX_CODEC: 
    129129              $codecs[$var['keyword']] = $var['data']; 
    130130            break; 
    131131 
    132             case VIDEO_CODEC: 
     132            case IAX_VIDEO_CODEC: 
    133133              $video_codecs[$var['keyword']] = $var['data']; 
    134134            break; 
    135135 
    136             case CUSTOM: 
     136            case IAX_CUSTOM: 
    137137              $iax_settings[] = array($var['keyword'], $var['data']); 
    138138            break; 
     
    267267  foreach ($raw_settings as $var) { 
    268268    switch ($var['type']) { 
    269       case NORMAL: 
     269      case IAX_NORMAL: 
    270270        $iax_settings[$var['keyword']]                 = $var['data']; 
    271271      break; 
    272272 
    273       case CODEC: 
     273      case IAX_CODEC: 
    274274        $iax_settings['codecs'][$var['keyword']]       = $var['data']; 
    275275      break; 
    276276 
    277       case VIDEO_CODEC: 
     277      case IAX_VIDEO_CODEC: 
    278278        $iax_settings['video_codecs'][$var['keyword']] = $var['data']; 
    279279      break; 
    280280 
    281       case CUSTOM: 
     281      case IAX_CUSTOM: 
    282282        $iax_settings['iax_custom_key_'.$var['seq']]   = $var['keyword']; 
    283283        $iax_settings['iax_custom_val_'.$var['seq']]   = $var['data']; 
     
    311311      case 'bindaddr': 
    312312        $msg = _("Bind Address (bindaddr) must be an IP address."); 
    313         $save_settings[] = array($key,$db->escapeSimple($vd->is_ip($val,$key,$msg)),'2',NORMAL); 
     313        $save_settings[] = array($key,$db->escapeSimple($vd->is_ip($val,$key,$msg)),'2',IAX_NORMAL); 
    314314      break; 
    315315 
    316316      case 'bindport': 
    317317        $msg = _("Bind Port (bindport) must be between 1024..65535, default 5060"); 
    318         $save_settings[] = array($key,$db->escapeSimple($vd->is_ip_port($val, $key, $msg)),'1',NORMAL); 
     318        $save_settings[] = array($key,$db->escapeSimple($vd->is_ip_port($val, $key, $msg)),'1',IAX_NORMAL); 
    319319      break; 
    320320 
     
    322322      case 'maxregexpire': 
    323323        $msg = sprintf($integer_msg,$key); 
    324         $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg)),'10',NORMAL); 
     324        $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg)),'10',IAX_NORMAL); 
    325325      break; 
    326326 
    327327      case 'iax_language': 
    328328        $msg = ("Language must be alphanumeric and installed"); 
    329         $save_settings[] = array($key,$db->escapeSimple($vd->is_alphanumeric($val,$key,$msg)),'0',NORMAL); 
     329        $save_settings[] = array($key,$db->escapeSimple($vd->is_alphanumeric($val,$key,$msg)),'0',IAX_NORMAL); 
    330330      break; 
    331331 
     
    333333      case 'delayreject': 
    334334      case 'bandwidth': 
    335         $save_settings[] = array($key,$val,'0',NORMAL); 
     335        $save_settings[] = array($key,$val,'0',IAX_NORMAL); 
    336336      break; 
    337337 
    338338      case 'jitterbuffer': 
    339         $save_settings[] = array($key,$val,'4',NORMAL); 
     339        $save_settings[] = array($key,$val,'4',IAX_NORMAL); 
    340340      break; 
    341341 
    342342      case 'forcejitterbuffer': 
    343         $save_settings[] = array($key,$val,'5',NORMAL); 
     343        $save_settings[] = array($key,$val,'5',IAX_NORMAL); 
    344344      break; 
    345345 
     
    347347      case 'maxjitterinterps': 
    348348        $msg = sprintf($integer_msg,$key); 
    349         $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg)),'5',NORMAL); 
     349        $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg)),'5',IAX_NORMAL); 
    350350      break; 
    351351 
    352352      case 'resyncthreshold': 
    353353        $msg = _("resyncthreshold must be a non-negative integer or -1 to disable"); 
    354         $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg,true)),'5',NORMAL); 
     354        $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg,true)),'5',IAX_NORMAL); 
    355355      break; 
    356356 
    357357      case 'videosupport': 
    358         $save_settings[] = array($key,$val,'10',NORMAL); 
     358        $save_settings[] = array($key,$val,'10',IAX_NORMAL); 
    359359      break; 
    360360 
     
    362362      if (substr($key,0,15) == "iax_custom_key_") { 
    363363        $seq = substr($key,15); 
    364         $save_settings[] = array($db->escapeSimple($val),$db->escapeSimple($iax_settings["iax_custom_val_$seq"]),($seq),CUSTOM);  
     364        $save_settings[] = array($db->escapeSimple($val),$db->escapeSimple($iax_settings["iax_custom_val_$seq"]),($seq),IAX_CUSTOM);  
    365365      } else if (substr($key,0,15) == "iax_custom_val_") { 
    366366        // skip it, we will seek it out when we see the iax_custom_key 
    367367      } else { 
    368         $save_settings[] = array($key,$val,'0',NORMAL); 
     368        $save_settings[] = array($key,$val,'0',IAX_NORMAL); 
    369369      } 
    370370    } 
     
    377377    $seq = 0; 
    378378    foreach ($codecs as $key => $val) { 
    379       $save_settings[] = array($db->escapeSimple($key),$db->escapeSimple($val),$seq++,CODEC); 
     379      $save_settings[] = array($db->escapeSimple($key),$db->escapeSimple($val),$seq++,IAX_CODEC); 
    380380    } 
    381381    $seq = 0; 
    382382    foreach ($video_codecs as $key => $val) { 
    383       $save_settings[] = array($db->escapeSimple($key),$db->escapeSimple($val),$seq++,VIDEO_CODEC);  
     383      $save_settings[] = array($db->escapeSimple($key),$db->escapeSimple($val),$seq++,IAX_VIDEO_CODEC);  
    384384    } 
    385385 
  • modules/branches/2.6/iaxsettings/module.xml

    r8267 r8275  
    22  <rawname>iaxsettings</rawname> 
    33  <name>Asterisk IAX Settings</name> 
    4   <version>2.6.0.4</version> 
     4  <version>2.6.0.5</version> 
    55  <publisher>Bandwidth.com</publisher> 
    66  <license>AGPLv3</license> 
     
    1414  </description> 
    1515  <changelog> 
     16    *2.6.0.5* #3866 
    1617    *2.6.0.4* localizations, misc 
    1718    *2.6.0.3* #3832 
  • modules/branches/2.6/outroutemsg/functions.inc.php

    r8059 r8275  
    1313//GNU General Public License for more details. 
    1414 
    15 define (DEFAULT_MSG, -1); 
    16 define (CONGESTION_TONE, -2); 
     15define ('DEFAULT_MSG', -1); 
     16define ('CONGESTION_TONE', -2); 
    1717 
    1818function outroutemsg_get_config($engine) { 
  • modules/branches/2.6/outroutemsg/module.xml

    r8060 r8275  
    22  <rawname>outroutemsg</rawname> 
    33  <name>Route Congestion Messages</name> 
    4   <version>2.6.0.2</version> 
     4  <version>2.6.0.3</version> 
    55  <publisher>Bandwidth.com</publisher> 
    66  <license>GPLv2</license> 
     
    1313  </menuitems> 
    1414  <changelog> 
     15    *2.6.0.3* #3865 
    1516    *2.6.0.2* minor tootlip tweaks 
    1617    *2.6.0.1* init tabindex 
  • modules/branches/2.6/sipsettings/functions.inc.php

    r8259 r8275  
    2525 
    2626/* Field Values for type field */ 
    27 define('NORMAL','0'); 
    28 define('CODEC','1'); 
    29 define('VIDEO_CODEC','2'); 
    30 define('CUSTOM','9'); 
     27define('SIP_NORMAL','0'); 
     28define('SIP_CODEC','1'); 
     29define('SIP_VIDEO_CODEC','2'); 
     30define('SIP_CUSTOM','9'); 
    3131 
    3232class sipsettings_validate { 
     
    123123        foreach ($raw_settings as $var) { 
    124124          switch ($var['type']) { 
    125             case NORMAL: 
     125            case SIP_NORMAL: 
    126126              $interim_settings[$var['keyword']] = $var['data']; 
    127127            break; 
    128128 
    129             case CODEC: 
     129            case SIP_CODEC: 
    130130              $codecs[$var['keyword']] = $var['data']; 
    131131            break; 
    132132 
    133             case VIDEO_CODEC: 
     133            case SIP_VIDEO_CODEC: 
    134134              $video_codecs[$var['keyword']] = $var['data']; 
    135135            break; 
    136136 
    137             case CUSTOM: 
     137            case SIP_CUSTOM: 
    138138              $sip_settings[] = array($var['keyword'], $var['data']); 
    139139            break; 
     
    318318  foreach ($raw_settings as $var) { 
    319319    switch ($var['type']) { 
    320       case NORMAL: 
     320      case SIP_NORMAL: 
    321321        $sip_settings[$var['keyword']]                 = $var['data']; 
    322322      break; 
    323323 
    324       case CODEC: 
     324      case SIP_CODEC: 
    325325        $sip_settings['codecs'][$var['keyword']]       = $var['data']; 
    326326      break; 
    327327 
    328       case VIDEO_CODEC: 
     328      case SIP_VIDEO_CODEC: 
    329329        $sip_settings['video_codecs'][$var['keyword']] = $var['data']; 
    330330      break; 
    331331 
    332       case CUSTOM: 
     332      case SIP_CUSTOM: 
    333333        $sip_settings['sip_custom_key_'.$var['seq']]   = $var['keyword']; 
    334334        $sip_settings['sip_custom_val_'.$var['seq']]   = $var['data']; 
     
    362362      case 'bindaddr': 
    363363        $msg = _("Bind Address (bindaddr) must be an IP address."); 
    364         $save_settings[] = array($key,$db->escapeSimple($vd->is_ip($val,$key,$msg)),'2',NORMAL); 
     364        $save_settings[] = array($key,$db->escapeSimple($vd->is_ip($val,$key,$msg)),'2',SIP_NORMAL); 
    365365      break; 
    366366 
    367367      case 'bindport': 
    368368        $msg = _("Bind Port (bindport) must be between 1024..65535, default 5060"); 
    369         $save_settings[] = array($key,$db->escapeSimple($vd->is_ip_port($val, $key, $msg)),'1',NORMAL); 
     369        $save_settings[] = array($key,$db->escapeSimple($vd->is_ip_port($val, $key, $msg)),'1',SIP_NORMAL); 
    370370      break; 
    371371 
     
    378378        } 
    379379        $msg = sprintf($integer_msg,$key); 
    380         $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val, $key, $msg)),'10',NORMAL); 
     380        $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val, $key, $msg)),'10',SIP_NORMAL); 
    381381      break; 
    382382 
     
    389389      case 'defaultexpiry': 
    390390        $msg = sprintf($integer_msg,$key); 
    391         $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg)),'10',NORMAL); 
     391        $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg)),'10',SIP_NORMAL); 
    392392      break; 
    393393 
     
    395395      case 'registerattempts': 
    396396        $msg = sprintf($integer_msg,$key); 
    397         $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg)),'10',NORMAL); 
     397        $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg)),'10',SIP_NORMAL); 
    398398      break; 
    399399 
     
    401401      case 'sip_language': 
    402402        $msg = ("Language must be alphanumeric and installed"); 
    403         $save_settings[] = array($key,$db->escapeSimple($vd->is_alphanumeric($val,$key,$msg)),'0',NORMAL); 
     403        $save_settings[] = array($key,$db->escapeSimple($vd->is_alphanumeric($val,$key,$msg)),'0',SIP_NORMAL); 
    404404      break; 
    405405 
    406406      case 'context': 
    407407        $msg = sprintf(_("%s must be alphanumeric"),$key); 
    408         $save_settings[] = array($key,$db->escapeSimple($vd->is_alphanumeric($val,$key,$msg)),'0',NORMAL); 
     408        $save_settings[] = array($key,$db->escapeSimple($vd->is_alphanumeric($val,$key,$msg)),'0',SIP_NORMAL); 
    409409      break; 
    410410 
    411411      case 'externrefresh': 
    412412        $msg = sprintf($integer_msg,$key); 
    413         $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg)),'41',NORMAL); 
     413        $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg)),'41',SIP_NORMAL); 
    414414      break; 
    415415 
    416416      case 'nat': 
    417         $save_settings[] = array($key,$val,'39',NORMAL); 
     417        $save_settings[] = array($key,$val,'39',SIP_NORMAL); 
    418418      break; 
    419419 
     
    423423          $vd->log_error($val, $key, $msg); 
    424424         } 
    425         $save_settings[] = array($key,$val,'40',NORMAL); 
     425        $save_settings[] = array($key,$val,'40',SIP_NORMAL); 
    426426      break; 
    427427 
     
    431431          $vd->log_error($val, $key, $msg); 
    432432         } 
    433         $save_settings[] = array($key,$val,'40',NORMAL); 
     433        $save_settings[] = array($key,$val,'40',SIP_NORMAL); 
    434434      break; 
    435435 
    436436      case 'jbenable': 
    437         $save_settings[] = array($key,$val,'4',NORMAL); 
     437        $save_settings[] = array($key,$val,'4',SIP_NORMAL); 
    438438      break; 
    439439 
     
    441441      case 'jbimpl': 
    442442      case 'jblog': 
    443         $save_settings[] = array($key,$val,'5',NORMAL); 
     443        $save_settings[] = array($key,$val,'5',SIP_NORMAL); 
    444444      break; 
    445445 
     
    447447      case 'jbresyncthreshold': 
    448448        $msg = sprintf($integer_msg,$key); 
    449         $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg)),'5',NORMAL); 
     449        $save_settings[] = array($key,$db->escapeSimple($vd->is_int($val,$key,$msg)),'5',SIP_NORMAL); 
    450450      break; 
    451451 
     
    459459      case 'allowguest': 
    460460      case 'srvlookup': 
    461         $save_settings[] = array($key,$val,'10',NORMAL); 
     461        $save_settings[] = array($key,$val,'10',SIP_NORMAL); 
    462462      break; 
    463463 
     
    467467        $seq = substr($key,9); 
    468468        $msg = _("Localnet setting must be an IP address"); 
    469         $save_settings[] = array($key,$db->escapeSimple($vd->is_ip($val,$key,$msg)),(42+$seq),NORMAL);  
     469        $save_settings[] = array($key,$db->escapeSimple($vd->is_ip($val,$key,$msg)),(42+$seq),SIP_NORMAL);  
    470470      } else if (substr($key,0,8) == "netmask_") { 
    471471        // ip validate this and store 
    472472        $seq = substr($key,8); 
    473473        $msg = _("Localnet netmask must be formated properly (e.g. 255.255.255.0 or 24)"); 
    474         $save_settings[] = array($key,$db->escapeSimple($vd->is_netmask($val,$key,$msg)),$seq,NORMAL);  
     474        $save_settings[] = array($key,$db->escapeSimple($vd->is_netmask($val,$key,$msg)),$seq,SIP_NORMAL);  
    475475      } else if (substr($key,0,15) == "sip_custom_key_") { 
    476476        $seq = substr($key,15); 
    477         $save_settings[] = array($db->escapeSimple($val),$db->escapeSimple($sip_settings["sip_custom_val_$seq"]),($seq),CUSTOM);  
     477        $save_settings[] = array($db->escapeSimple($val),$db->escapeSimple($sip_settings["sip_custom_val_$seq"]),($seq),SIP_CUSTOM);  
    478478      } else if (substr($key,0,15) == "sip_custom_val_") { 
    479479        // skip it, we will seek it out when we see the sip_custom_key 
    480480      } else { 
    481         $save_settings[] = array($key,$val,'0',NORMAL); 
     481        $save_settings[] = array($key,$val,'0',SIP_NORMAL); 
    482482      } 
    483483    } 
     
    490490    $seq = 0; 
    491491    foreach ($codecs as $key => $val) { 
    492       $save_settings[] = array($db->escapeSimple($key),$db->escapeSimple($val),$seq++,CODEC); 
     492      $save_settings[] = array($db->escapeSimple($key),$db->escapeSimple($val),$seq++,SIP_CODEC); 
    493493    } 
    494494    $seq = 0; 
    495495    foreach ($video_codecs as $key => $val) { 
    496       $save_settings[] = array($db->escapeSimple($key),$db->escapeSimple($val),$seq++,VIDEO_CODEC);  
     496      $save_settings[] = array($db->escapeSimple($key),$db->escapeSimple($val),$seq++,SIP_VIDEO_CODEC);  
    497497    } 
    498498 
  • modules/branches/2.6/sipsettings/module.xml

    r8265 r8275  
    22  <rawname>sipsettings</rawname> 
    33  <name>Asterisk SIP Settings</name> 
    4   <version>2.6.0.6</version> 
     4  <version>2.6.0.7</version> 
    55  <publisher>Bandwidth.com</publisher> 
    66  <license>AGPLv3</license> 
     
    1414  </description> 
    1515  <changelog> 
     16    *2.6.0.7* #3866 
    1617    *2.6.0.6* #3722, localizations 
    1718    *2.6.0.5* #3831, #3722