Changeset 9650 for modules

Show
Ignore:
Timestamp:
05/18/10 19:37:15 (3 years ago)
Author:
p_lindheimer
Message:

closes #4280 checks for version ge 1.4.25 to use queue state information if USEQUEUESTATE is not set

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • modules/branches/2.8/queues/functions.inc.php

    r9649 r9650  
    4444    $ver12 = version_compare($ast_version, '1.4', 'lt'); 
    4545    $ver16 = version_compare($ast_version, '1.6', 'ge'); 
     46    $ast_ge_14_25 = version_compare($ast_version,'1.4.25','ge'); 
    4647     
    4748    // legacy but in case someone was using this we will leave it 
     
    5960    } 
    6061 
    61     if ($amp_conf['USEQUEUEDEVICE']) { 
     62    if ($ast_ge_14_25) { 
    6263      $devices = array(); 
    6364      $device_results = core_devices_list('all','full',true); 
     
    7172      } 
    7273    } 
    73     if ($amp_conf['USEQUEUESTATE'] || $amp_conf['USEQUEUEDEVICE']) { 
     74    if ($amp_conf['USEQUEUESTATE'] || $ast_ge_14_25) { 
    7475      $users = array(); 
    7576      $user_results = core_users_list(); 
     
    152153          } 
    153154        } 
    154       } else if ($amp_conf['USEQUEUEDEVICE']) { 
     155      } else if ($ast_ge_14_25) { 
    155156        foreach ($members as $member) { 
    156157          preg_match("/^Local\/([\d]+)\@*/",$member,$matches); 
     
    200201    return $output; 
    201202  } 
    202  
    203  
    204  
    205203} 
    206204 
     
    298296      $ast_ge_14 = version_compare($version,'1.4','ge'); 
    299297      $ast_ge_16 = version_compare($version,'1.6','ge'); 
     298      $ast_ge_14_25 = version_compare($version,'1.4.25','ge'); 
    300299 
    301300      $has_extension_state = $ast_ge_16; 
     
    522521          $ext->add($from_queue_exten_only, $item[0], '', new ext_setvar('RingGroupMethod', 'none')); 
    523522          $ext->add($from_queue_exten_only, $item[0], '', new ext_macro('record-enable',$item[0].",IN")); 
    524           if ($amp_conf['USEDIALONE'] && $has_extension_state) { 
     523          if ($has_extension_state) { 
    525524            $ext->add($from_queue_exten_only, $item[0], '', new ext_macro('dial-one',',${DIAL_OPTIONS},'.$item[0])); 
    526525          } else { 
     
    546545      $ext->add($context, $exten, 'a5', new ext_set('CALLBACKNUM', '${IF($[${LEN(${AMPUSER})}=0]?${CALLERID(number)}:${AMPUSER})}')); 
    547546 
    548       if ($amp_conf['USEQUEUEDEVICE']) { 
     547      if ($ast_ge_14_25) { 
    549548        $ext->add($context, $exten, '', new ext_set('THISDEVICE', '${DB(DEVICE/${REALCALLERIDNUM}/dial)}')); 
    550549      } 
     
    567566        $ext->add($context, $exten, '', new ext_execif('$[${DB_EXISTS(AMPUSER/${CALLBACKNUM}/cidname)} = 1]', 'AddQueueMember', '${ARG1},Local/${CALLBACKNUM}@from-queue/n,${DB(QPENALTY/${ARG1}/agents/${CALLBACKNUM})},,${DB(AMPUSER/${CALLBACKNUM}/cidname)},HINT:${CALLBACKNUM}@ext-local')); 
    568567        $ext->add($context, $exten, '', new ext_execif('$[${DB_EXISTS(AMPUSER/${CALLBACKNUM}/cidname)} = 0]', 'AddQueueMember', '${ARG1},Local/${CALLBACKNUM}@from-queue/n,${DB(QPENALTY/${ARG1}/agents/${CALLBACKNUM})}')); 
    569       } else if ($amp_conf['USEQUEUEDEVICE']) { 
     568      } else if ($ast_ge_14_25) { 
    570569        $ext->add($context, $exten, '', new ext_set('THISDEVICE', '${IF($[${LEN(${THISDEVICE})}=0]?${DB(DEVICE/${CUT(DB(AMPUSER/${CALLBACKNUM}/device),&,1)}/dial)}:${THISDEVICE})}')); 
    571570        $ext->add($context, $exten, '', new ext_execif('$[${LEN(${THISDEVICE})}!=0]', 'AddQueueMember', '${ARG1},Local/${CALLBACKNUM}@from-queue/n,${DB(QPENALTY/${ARG1}/agents/${CALLBACKNUM})},,${DB(AMPUSER/${CALLBACKNUM}/cidname)},${THISDEVICE}')); 
     
    10431042  global $ext; 
    10441043  global $amp_conf; 
    1045  
     1044  global $version; 
     1045 
     1046  $ast_ge_14_25 = version_compare($version,'1.4.25','ge'); 
    10461047  $id = "macro-toggle-add-agent"; // The context to be included 
    10471048 
     
    10551056  if ($amp_conf['USEQUEUESTATE']) { 
    10561057    $ext->add($id, $c, '', new ext_addqueuemember('${QUEUENO}','Local/${CALLBACKNUM}@from-queue/n,${DB(QPENALTY/${QUEUENO}/agents/${CALLBACKNUM})},,${DB(AMPUSER/${CALLBACKNUM}/cidname)},HINT:${CALLBACKNUM}@ext-local')); 
    1057   } else if ($amp_conf['USEQUEUEDEVICE']) { 
     1058  } else if ($ast_ge_14_25) { 
    10581059    $ext->add($id, $c, '', new ext_addqueuemember('${QUEUENO}','Local/${CALLBACKNUM}@from-queue/n,${DB(QPENALTY/${QUEUENO}/agents/${CALLBACKNUM})},,${DB(AMPUSER/${CALLBACKNUM}/cidname)},${DB(DEVICE/${REALCALLERIDNUM}/dial)}')); 
    10591060  } else {