Ticket #1138 (closed Patches: fixed)

Opened 5 years ago

Last modified 5 years ago

code cleanup and enhancement

Reported by: lfarkas@lfarkas.org Assigned to:
Priority: minor Milestone: 2.2
Component: Applications Module Version: SVN-HEAD
Keywords: Cc:
Confirmation: SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

hi,
i made a few changes to the current trunk of freepbx. i hope these'll be applied. changes:
- cleanup code in config.php (only one 'if' for type)
- set all nessesery varibale in config.php and therefore don't required to do it in most other places eg page.XXX.php
- always send the type variable with the request (in drawListMenu, in config.php etc)
- enhance components class with type, and isequal()
- code cleanup in page.XXX.php files
- and the addition of cdrcost module which i currently develop (this can be applied later).

now i go for a week vacation for diving, so i can reply to any question only after a week.

yours.

Attachments

freepbx.lfarkas-1.patch (10.7 kB) - added by lfarkas@lfarkas.org on 09/22/06 09:29:36.
my patches

Change History

09/22/06 09:29:36 changed by lfarkas@lfarkas.org

  • attachment freepbx.lfarkas-1.patch added.

my patches

09/26/06 06:53:57 changed by RobThomas

  • status changed from new to closed.
  • resolution set to fixed.

Seemed to go in well. I've stuck it in trunk, but I took out the references to that module you haven't written yet 8) Thanks!

--Rob

09/26/06 06:55:51 changed by RobThomas

(Hope you enjoyed your diving - PS, watch out for stingrays, Crikey!)

10/02/06 07:14:33 changed by lfarkas@lfarkas.org

thanks. the diving in egyipt was nice as always (but there is no stringrays:-()

01/08/07 13:46:44 changed by

  • milestone deleted.

Milestone 2.2 deleted

01/08/07 15:16:47 changed by vgster

  • milestone set to 2.2.