Mailbox not being setup properly

looks like more carnage from moving voicemail into the hooks code (or is it related to the gui elements as well). Changing to a blocker - this is really bad.

Fixed in voicemail 1.5

It's still not working with 1.5 VM mod, but the other VM settings are saving properly.

Thanks, sorry for that. Fixed in VM 1.5.1.

Not quite fixed: I have FreePBX 2.2.0 with Voicemail module 1.6. When running in deviceanduser mode, a newly created user does not get the mailbox=... line added. I switched to extensions mode, created a new extension with voicemail, and that one extension was fine, but the previously created ones still did not have it added.

Milestone 2.2 deleted

It is not being noticed because it was working in the older versions. An upgrade will cause the DB and config to retain the correct settings for old extensions. However, new extensions will have this problem.

verified bug in frepbx 2.2 only in deviceanduser mode.

mailbox does not get filled in as id@device.

diff attached to fix. please test before committing.

Index: amp_conf/htdocs/admin/modules/core/functions.inc.php
===================================================================
--- amp_conf/htdocs/admin/modules/core/functions.inc.php        (revision 3562)
+++ amp_conf/htdocs/admin/modules/core/functions.inc.php        (working copy)
@@ -777,6 +777,8 @@
                        $keyword = substr($req, 8);
                        if ( $keyword == 'dial' && $data == '' ) {
                                $sipfields[] = array($account, $keyword, 'SIP/'.$account);
+                       } elseif ($keyword == 'mailbox' && $data == '') {
+                               $sipfields[] = array($account,'mailbox',$account.'@device');
                        } else {
                                $sipfields[] = array($account, $keyword, $data);
                        }
@@ -856,6 +858,8 @@
                        $keyword = substr($req, 8);
                        if ( $keyword == 'dial' && $data == '' ) {
                                $iaxfields[] = array($account, $keyword, 'IAX2/'.$account);
+                       } elseif ($keyword == 'mailbox' && $data == '') {
+                               $iaxfields[] = array($account,'mailbox',$account.'@device');
                        } else {
                                $iaxfields[] = array($account, $keyword, $data);
                        }
@@ -936,6 +940,8 @@
                        if ( $keyword == 'dial' && $data == '' ) {
                                $zapchan = $_REQUEST['devinfo_channel'] != '' ? $_REQUEST['devinfo_channel'] : $_REQUEST['channel'];
                                $zapfields[] = array($account, $keyword, 'ZAP/'.$zapchan);
+                       } elseif ($keyword == 'mailbox' && $data == '') {
+                               $zapfields[] = array($account,'mailbox',$account.'@device');
                        } else {
                                $zapfields[] = array($account, $keyword, $data);
                        }

Tested fix - confirmed OK.

Fix seems to correct edit function. On add new extension mailbox fields are still missing.

Replying to ShaneB:

Fix seems to correct edit function. On add new extension mailbox fields are still missing.

Please double check. If indeeed, it is still not working, please post versions, and specifics. (deviceanduser or extensions, etc.)

Double checked, its working. I didn't patch right. Working fine now.

patch opened #1667

Thanks, naftali5. Applied in r3584