Ticket #1463 (closed Bugs: fixed)

Opened 6 years ago

Last modified 6 years ago

Modules on 2.2.x (including b3, rc1) Upgrade All doesn't work

Reported by: uforgotten Assigned to: gregmac
Priority: trivial Milestone: 2.2
Component: Core - Module Admin Version: 2.2rc1
Keywords: modules upgrade all firefox Cc:
Confirmation: Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

When upgrading, both to 2.2b3 and 2.2rc1, the "Upgrade All" link does not work. Browser is Firefox 1.5.0.8 on Windows XP Home. Browser meta data: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.8) Gecko/20061025 Firefox/1.5.0.8. From about:plugins

Java(TM) 2 Platform Standard Edition 5.0 Update 6

File name: NPJPI150_06.dll Java Plug-in 1.5.0_06 for Netscape Navigator (DLL Helper)

MIME Type Description Suffixes Enabled application/x-java-applet;jpi-version=1.5.0_06 Java Applet Yes application/x-java-bean;jpi-version=1.5.0_06 JavaBeans? Yes Java(TM) 2 Platform Standard Edition 5.0 Update 6

File name: NPOJI610.dll Java Plug-in 1.5.0_06 for Netscape Navigator (DLL Helper)

MIME Type Description Suffixes Enabled application/x-java-vm Java Yes Java(TM) 2 Platform Standard Edition 5.0 Update 6

File name: NPJava11.dll Java Plug-in 1.5.0_06 for Netscape Navigator (DLL Helper)

MIME Type Description Suffixes Enabled application/x-java-applet;version=1.1.1 Java Applet Yes application/x-java-bean;version=1.1.1 JavaBeans? Yes application/x-java-applet;version=1.1 Java Applet Yes application/x-java-bean;version=1.1 JavaBeans? Yes application/x-java-applet Java Applet Yes application/x-java-bean JavaBeans? Yes Java(TM) 2 Platform Standard Edition 5.0 Update 6

File name: NPJava12.dll Java Plug-in 1.5.0_06 for Netscape Navigator (DLL Helper)

MIME Type Description Suffixes Enabled application/x-java-applet;version=1.2 Java Applet Yes application/x-java-bean;version=1.2 JavaBeans? Yes application/x-java-applet;version=1.1.3 Java Applet Yes application/x-java-bean;version=1.1.3 JavaBeans? Yes application/x-java-applet;version=1.1.2 Java Applet Yes application/x-java-bean;version=1.1.2 JavaBeans? Yes Java(TM) 2 Platform Standard Edition 5.0 Update 6

File name: NPJava13.dll Java Plug-in 1.5.0_06 for Netscape Navigator (DLL Helper)

MIME Type Description Suffixes Enabled application/x-java-applet;version=1.3.1 Java Applet Yes application/x-java-bean;version=1.3.1 JavaBeans? Yes application/x-java-applet;version=1.4 Java Applet Yes application/x-java-bean;version=1.4 JavaBeans? Yes application/x-java-applet;version=1.4.1 Java Applet Yes application/x-java-bean;version=1.4.1 JavaBeans? Yes Java(TM) 2 Platform Standard Edition 5.0 Update 6

File name: NPJava14.dll Java Plug-in 1.5.0_06 for Netscape Navigator (DLL Helper)

MIME Type Description Suffixes Enabled application/x-java-applet;version=1.4.2 Java Applet Yes application/x-java-bean;version=1.4.2 JavaBeans? Yes application/x-java-applet;version=1.5 Java Applet Yes application/x-java-bean;version=1.5 JavaBeans? Yes Java(TM) 2 Platform Standard Edition 5.0 Update 6

File name: NPJava32.dll Java Plug-in 1.5.0_06 for Netscape Navigator (DLL Helper)

MIME Type Description Suffixes Enabled application/x-java-applet;version=1.3 Java Applet Yes application/x-java-bean;version=1.3 JavaBeans? Yes application/x-java-applet;version=1.2.2 Java Applet Yes application/x-java-bean;version=1.2.2 JavaBeans? Yes application/x-java-applet;version=1.2.1 Java Applet Yes application/x-java-bean;version=1.2.1 JavaBeans? Yes

Change History

11/28/06 19:05:27 changed by uforgotten

I believe this did work in 2.2b1. It may be a browser-related issue, but per X-Rob I'm logging it nonetheless.

11/28/06 19:12:07 changed by gregmac

I can't reproduce this. Can you do the following please:

  • open the javascript console (tools > javascript console),
  • Press the clear button
  • reload the module admin page, and press 'update all'
  • paste any errors you get here

I've tested in the exact same version of firefox running on XP pro (as well as some other platforms)..

11/28/06 21:06:01 changed by uforgotten

OK, there were no Java errors. One thing that I noticed, it was on the following modules: Follow Me, Queues, Ring Groups. These were enabled and upgraded before I installed rc1 and then the module admin disabled them for whatever reason, "pending upgrade to x.x". I just realized that maybe the upgrade all didn't work because they were "Disabled". But more importantly, why is it disabling them?

11/29/06 13:44:24 changed by gregmac

Modules are automatically disabled (Disabled; pending upgrade to..) whenever the version in the modules directory (eg, /var/www/html/admin/modules/*) doesn't match the version register in the freepbx database. This is because when a module is upgraded, it runs an install script, which can setup tables, etc.

If, for example, the table structure had changed, and you generated the configs using the code from the new version but the database structure from the old version, you could end up with an error, or potentially (even worse) a weird/wrong configuration being written out. To avoid this situation, the module is simply disabled.

The 'upgrade all' likely isn't upgrading those right now, because it was really made for online mode. I'll look into that, and set it to upgrade those, as well as be visible all the time.

12/03/06 14:12:46 changed by p_lindheimer

what's the status of this?

12/07/06 03:50:51 changed by p_lindheimer

  • priority changed from minor to trivial.

status?

12/07/06 11:05:09 changed by uforgotten

I'm not sure if you're asking me for status or not... it's not changed here. The resolution would be, as stated above by gregmac, to either put in a note telling people to manually upgrade their modules that are auto-disabled, or have the Upgrade All javascript ALSO upgrade the disabled modules. I recommend that it should at least be explained in the final release as to what is going on or the modules will remain disabled until upgraded. Thanks for all your hard work!

12/17/06 23:59:08 changed by RobThomas

Mmm.. I think that, yes, 'Upgrade All' _should_ upgrade disabled modules. Anyone have any issues with that?

12/18/06 00:48:05 changed by RobThomas

  • status changed from new to closed.
  • resolution set to fixed.

Well, I went and did it anyway.. Checked into 2.2 and 2.3 branches as r3348

01/08/07 14:46:44 changed by

  • milestone deleted.

Milestone 2.2 deleted

01/08/07 15:39:04 changed by vgster

  • milestone set to 2.2.