Ticket #1487 (closed Bugs: duplicate)

Opened 6 years ago

Last modified 6 years ago

Cannot edit / delete Queue when queue number is 0

Reported by: shimi Assigned to:
Priority: minor Milestone: 2.2
Component: Queues Version: 2.3-branch
Keywords: queue edit delete Cc:
Confirmation: Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

Create a queue number of "0", and then click on it to edit/remove.

Instead of a Remove option, you'll see a regular "Add Queue" form, with most of the details filled up (but queue number is empty) - if you'll try to fill the queue number with "0" and do save, you'll get an SQL error. If you try another number, it will create another queue, with the details of queue 0.

I am GUESSING that this is related to some IF that checks for FALSE or so with == instead of === ? I don't know...

I would also check if this affects other places where 0 is used as extension number (ring groups, extension, and so on...) - I would check myself, if I could remove the 0 queue ;-)

Change History

12/02/06 15:01:05 changed by p_lindheimer

  • priority changed from major to minor.

I would venture to guess that 0 is a problem in a lot of places (and not just 2.2), will have to take a look. In general, 0 is not a good number for most things...

12/02/06 15:06:10 changed by shimi

In most PBXs I've seen (companies / hotels) - 0 is what you dial to get to an operator. When you think about it, even the Asterisk Directory says "Press 0 to reach an operator"... when you think about it, even most phones has the word "OPER" hardcoded on their 0 key ;)

And IMHO, if you are not a very small place, you will want 0 to be a queue - especially if you have only one person occupying that job at the same time...

12/07/06 03:35:42 changed by p_lindheimer

should try to put a javascript validation to block this before 2.2 final

12/07/06 04:24:05 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

r3287, r3288, r3289, r3290

added javascript to block 0

12/07/06 04:24:13 changed by p_lindheimer

  • milestone set to 2.2.

01/08/07 14:46:44 changed by

  • milestone deleted.

Milestone 2.2 deleted

01/08/07 15:36:43 changed by vgster

  • milestone set to 2.2.

01/08/07 21:35:07 changed by shimi

  • status changed from closed to reopened.
  • resolution deleted.

I don't care if the milestone be changed to 2.3 or whatever - but the bug is still there - hiding the bug with JavaScript? does not constitute a resolution - 0 is a valid phone number, and is widely used in PBX systems - especially as the operator QUEUE - like I commented before. This needs to be fixed. I am re-opening and if you want you can change the milestone (or "WONTFIX" it - which would really be shame) - at any rate - "fixed" is a wrong resolution when the problem was not fixed.

01/08/07 23:48:08 changed by naftali5

shimi, just for you... #1659

hope it gets in soon.

06/25/07 08:09:10 changed by p_lindheimer

  • version changed from 2.2rc1 to 2.3-branch.
  • engine_version changed.
  • svn_rev changed.

06/30/07 12:37:06 changed by p_lindheimer

  • status changed from reopened to closed.
  • resolution set to duplicate.

see #1659, marking this as a dup since that has fix we will review.