Can't use apostrophe in Display Name field

hmm - is an "'" a supported CID character? can someone test that and see if handsets can receive and apostrophe?

Ok - I tried by putting it straight into the astdb field, looks like both my polycom as well as a panasonic phone I have connected to a Sipura ata have no problem receiving the "'" so ... guess it should be fixed (eventually)

yes, the script does not let '

/var/www/html/admin/common/script.js.php

function isCallerIDChar (c)
{   return ( ((c >= "a") && (c <= "z")) || ((c >= "A") && (c <= "Z")) || ((c >= "0") && (c <= "9")) || (c == ":") || (c == "_") || (c == "-") || (c == "<") || (c == ">") || (c == "(") || (c == ")") || (c == " ") || (c == "\"") || (c == "&") || (c == "@") || (c == ".") )
}

besides, the message is wrong...

line 2331 of my version of core's functions.include.php

$currentcomponent->addguielem($section, new gui_textbox('name', $name, 'Display Name', 'The caller id name for calls from this user will be set to this name. Only enter the name, NOT the number.', '!isCallerID()', $msgInvalidOutboundCID, false));

should be using

$msgInvalidDispName = 'Please enter a valid Display Name';

not

$msgInvalidOutboundCID = 'Please enter a valid Outbound CID';

Please check for proper escaping in queries that use this field before making this change, otherwise we will run into sql errors

The incorrect error being displayed is fixed, but allowing users to use ' in names won't be fixed for a while yet, possibly until 3.0, to avoid SQL injection errors.

Milestone 2.3 deleted

Dup of #1955