Ticket #1549 (closed Bugs: fixed)

Opened 4 years ago

Last modified 4 years ago

Mistake in /admin/functions.inc.php drawselects()

Reported by: naftali5 Assigned to:
Priority: minor Milestone: 2.2
Component: Web interface Version: 2.2rc1
Keywords: Cc:
Confirmation: SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

the function mistakenly reuses the variable $goto

line 649 is 

if ($checked) { $goto = $mod; }

should be 

if ($checked) { $gotomod = $mod; }

line 663 is 

$selectHtml .= "\n<input type='hidden' name='goto$i' value='$goto'>";

should be 

$selectHtml .= "\n<input type='hidden' name='goto$i' value='$gotomod'>";

one outcome is that any module with the word custom in the module name can not be chosen as a destination.

Change History

12/17/06 12:23:11 changed by naftali5

sorry, one more thing

before line 663 should be inserted another line so it reads 

$gotomod = ($gotomod)?$gotomod:'custom';
$selectHtml .= "\n<input type='hidden' name='goto$i' value='$gotomod'>";

and this is a BLOCKER! try to set a destination of "custom-myapp,1,1" then submit

seems to be saved, right? don't change anything and submit again. it is gone!

12/17/06 22:26:42 changed by naftali5

this should be marked as closed. X-rob fixed it. Thanks!

12/17/06 22:28:49 changed by RobThomas

  • status changed from new to closed.
  • resolution set to fixed.

01/08/07 11:46:44 changed by

  • milestone deleted.

Milestone 2.2 deleted

01/08/07 12:32:43 changed by vgster

  • milestone set to 2.2.