Open Source Training Seminar FreePBX Paid Support

Ticket #1613 (closed Feature Requests: fixed)

Opened 2 years ago

Last modified 3 months ago

Caller Lookup Source for Extension (DID)

Reported by: FSeebach Assigned to:
Priority: minor Milestone: 2.5
Component: Third Party Module Version: 2.5-branch
Keywords: Cc:
Confirmation: Need Feedback SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

The only way to set up Caller Lookup is in the Settings of an inbound Trunk.

I think there should be a way to set this for an Extension too (if a caller comes in over the Direct DID of the extension)

Change History

12/29/06 01:55:46 changed by vgster

It's inbound route not inbound trunk. A call coming into a DID is an inbound route, so set the caller ID on that.

12/31/06 06:46:15 changed by vgster

  • status changed from new to closed.
  • resolution set to invalid.

As previously stated if you have DID's going to extensions set the CID lookup source on the inbound route.

01/08/07 07:13:10 changed by kiwi_uk

  • status changed from closed to reopened.
  • resolution deleted.

vgster, sorry to be a pain but could you please clarify what you mean?

When setting a DID inside an Extensions config (in FreePBX) an "Inbound Route" is not created under the relevant page in FreePBX. Do you mean use Inbound routes instead of DIDs to set the Caller ID Lookup source (not NOT the caller ID, but the CID lookup source with reference to that module).

01/17/07 01:47:39 changed by vgster

  • engine_version changed.
  • svn_rev changed.

Are you creating inbound routes for your extensions? Putting a DID in when you create the extension doesn't create the inbound route. You need to specify the caller ID lookup on the inbound route.

01/18/07 00:53:09 changed by vgster

  • status changed from reopened to closed.
  • resolution set to invalid.

06/01/07 18:07:35 changed by cgb

  • status changed from closed to reopened.
  • resolution deleted.

I've just stumbled up the same symptoms as the original author of the ticket. I've examined the context path/call flow with respect to this feature and I don't see how someone might 'make it work' by setting the the CID lookup source on the inbound route.

According to '[from-pstn]':

  from-pstn-custom
  ext-did-direct
  ext-did
   ..

Now a call to a user matching the DID would traverse the 'ext-did-direct' context, which results in something like:

  [ext-did-direct]
  ..
  exten => 12345678,1,Set(FROM_DID=12345678)
  exten => 12345678,n,Goto(from-did-direct,5678,1)
  ..

The only lookup I see to to the cidlookup sub is in ext-did:

exten => s,n,Gosub(cidlookup,cidlookup_1,1)

So maybe the above comments are suggesting to add a route per DID. This would then allow the user to define a lookup source per DID. However, because 'ext-did-direct' is included before 'ext-did' in the [from-pstn] context, I still don't see this working.

I've updated /var/www/html/admin/modules/core/functions.inc.php on my install to do output the caller ID lookup GotoSub? for each extension listend in [ext-did-direct]. This is doing ok so far (early days in testing yet).

So, could someone set me straight on my misunderstanding (as the above comments don't explain things very clearly), or could this be reconsidered as a valid ticket/bug/feature request ...?

Thanks

06/09/07 03:31:45 changed by vgster

  • type changed from Bugs to Feature Requests.

08/03/07 03:11:50 changed by vgster

  • confirmation set to Confirmed.
  • version changed from 2.2rc3 to 2.3-branch.
  • milestone set to 3.0.

(follow-up: ↓ 10 ) 09/27/07 15:03:09 changed by FreshSmith

It is a pitty to set this feature to 3.0. Because it does not make sense to put it only on a inbound route. The direct-did is more important to get all extensions in the favour to see who is ringing. It would be nice to add the lookup to the extensions (maybe in the general menu).

(in reply to: ↑ 9 ; follow-up: ↓ 11 ) 09/27/07 17:59:25 changed by cgb

Oops - I could include for you my fix (which I noted above was in early testing). See how it goes for you:

--- /var/www/html/admin/modules/core/functions.inc.php.bak  2007-06-02 16:36:07.000000000 +1000
+++ /var/www/html/admin/modules/core/functions.inc.php  2007-06-02 16:35:25.000000000 +1000
@@ -298,6 +298,8 @@
        foreach($directdidlist as $item) {
          $exten = $item['directdid'];
          $ext->add($context, $exten, '', new ext_setvar('FROM_DID',$exten));
+               $ext->splice($context, $exten, 1, new ext_gosub('1', 'cidlookup_1', 'cidlookup'));
+

          if ($item['faxexten'] != "default") {
            $ext->add($context, $exten, '', new ext_setvar('FAX_RX',$item['faxexten']));

(in reply to: ↑ 10 ) 09/27/07 18:14:10 changed by cgb

Note that there is a static reference to the name of the caller id lookup source (cidlookup_1). Update as necessary. It was a quick fix for my setup - it's not a permanent fix to this problem.

09/27/07 23:49:10 changed by FreshSmith

Perfect this works as a workaround.

Thanks for your help. Maybe it helps here to implement something useful.

Marcus

11/13/07 20:19:29 changed by p_lindheimer

  • confirmation changed from Confirmed to Need Feedback.
  • version deleted.
  • milestone changed from 2.4 to 3.0.

My opinion on this is that cidlookup should not be associated with a route, it should be associated with an inbound trunk since different inbound trunks have different needs. So I understand the issue wrt to inbound routing and not having this on directdids and agree that is an issue, but I vote to defer this until we get more specific trunk related routing, and where we can then associate it with the inbound trunks in question.

07/04/08 14:11:00 changed by p_lindheimer

  • status changed from reopened to closed.
  • version set to 2.5-branch.
  • resolution set to fixed.

fixed in 2.5 with the merging of directdids and incoming routes.

Donate



Support
Download
Develop
Forums
News
Documentation
Paid Support
About

Paid Ads