Ticket #1810 (closed Patches: wontfix)

Opened 5 years ago

Last modified 4 years ago

conversion of extensions.conf to php

Reported by: bsdtech Assigned to:
Priority: minor Milestone:
Component: Core Version: 2.2.1
Keywords: Cc:
Confirmation: Confirmed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

Groogs requested extensions.con be made into php

Attachments

extensions.conf.php (52.7 kB) - added by bsdtech on 02/27/07 11:15:04.

Change History

02/27/07 11:15:04 changed by bsdtech

  • attachment extensions.conf.php added.

03/01/07 08:31:51 changed by naftali5

firstly, there are numerous mistakes in this file (addinclude() called wrong, most strings not enclosed in quotes, setting $id and assuming it magically does something) and I only glanced at it for a moment.

On the other hand, this was probably quite a bit of work, and checking it over and correcting it will be far easier than writing it probably was.

More importantly, the motto of freepbx has always been to leave room for the user to customize. This was always done by including _custom.conf, AND allowing the user to add/edit extensions.conf. Although this was not always a great idea from the user's standpoint, as an upgrade could wipe it out, it still allowed for the advanced user to adjust. If extension.conf.php will be static (i.e. not pulling from database), why bother making it php? It will be part of core anyhow, and not get fixed besides for an upgrade (and assuming core does become upgradeable like a module, the file could be upgraded as easily as the php.

As i think about it, there is one benefit I can think of, though. This will allow module developers to ext->splice which was otherwise impossible. Perhaps that is enough reason to do it. I just figured i'd voice the question so it can be discussed.

11/13/07 14:36:10 changed by p_lindheimer

  • status changed from new to closed.
  • confirmation set to Confirmed.
  • resolution set to wontfix.
  • milestone deleted.

from the feedback that this is filled with errors and never tested, closing.