Ticket #1847 (closed Bugs: fixed)

Opened 3 years ago

Last modified 3 years ago

Can't use = in trunk secret

Reported by: toddinpal Assigned to:
Priority: major Milestone: 2.3
Component: Core - Trunks/Routing Version: 2.2.1
Keywords: Cc:
Confirmation: SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

If you try to use an equal sign (=) in the secret for the peer settings of a trunk the equal sign and everything after it in the secret are discarded. This is caused by the use of split() and splitting the secret string on equal signs. Adding 2 as the third parameter to the split call will allow the entire secret string to be gotten. The diff on my system for admin/modules/core/functions.inc.php is: 

1390c1390
<                       $tmp = split('=',$line);
---
>                       $tmp = split('=',$line,2);

-tl

Change History

03/28/07 08:02:59 changed by wiseoldowl

I will just note that this is something that's been coming up in the #freepbx channel recently (on at least a couple of occasions) - people are commenting that some providers seem to be putting = or @ in the password (there's even been speculation that they do it specifically to stop Trixbox/FreePBX users from using their Asterisk boxes to connect, instead of using a standalone VoIP adapter, however I have no idea if that is the case). If this fix doesn't break anything, it might be a good idea to get it into 2.3.

03/28/07 09:38:22 changed by p_lindheimer

  • priority changed from minor to major.
  • status changed from new to closed.
  • resolution set to fixed.

r3891 (2.2) r3892 (2.3) fixed. (Also broke using setvar=var=value in a trunk, and anything else that needed an = on the right side.