Ticket #1888 (closed Bugs: fixed)

Opened 6 years ago

Last modified 6 years ago

ringgroup non-'prim' strategies don't ring extensions when first is dnd

Reported by: p_lindheimer Assigned to: p_lindheimer
Priority: major Milestone: 2.3
Component: Ring Groups Version: 2.2.1
Keywords: ringgroups followme Cc:
Confirmation: Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable): svn head and 2.2.1

Description

'prim' mode will not ring subsequent extensions when the primary has freepbx DND enabled or is otherwise occupied. Non-prim mode strategies should ring the others and this is not happening.

This is broken in 2.2.1 and 2.3.

The fix should be the following but I need to test several modes before comitting this:

Version 2.2.1:

Index: dialparties.agi
===================================================================
--- dialparties.agi     (revision 3896)
+++ dialparties.agi     (working copy)
@@ -185,7 +185,7 @@
                        $AGI->set_variable('DIALSTATUS','BUSY');
                        // if this is primary set dndprimary and figure out if needed below
                        //
-                       if ($count == 0)
+                       if ($count == 0 && $mastermode)
                        {
                                $dndprimary = 1;
                                debug("Primary extension is DND, so if mastermode, all should be dnd", 4);

And version 2.3:

Index: dialparties.agi
===================================================================
--- dialparties.agi     (revision 3903)
+++ dialparties.agi     (working copy)
@@ -239,12 +239,15 @@
                        $AGI->set_variable('DIALSTATUS','BUSY');
                        // if this is primary set dndprimary and figure out if needed below
                        //
-                       if ($count == 0)
+                       if ($count == 0 && $mastermode)
                        {
                                $dndprimary = 1;
-                               $fmgrp_primaryremoved = 1;
                                debug("Primary extension is DND, so if mastermode, all should be dnd", 4);
                        }
+                       if ($count == 0)
+                       {
+                               $fmgrp_primaryremoved = 1;
+                       }
                } 
                else
                        debug("Extension $k do not disturb is disabled", 3);

Change History

04/06/07 20:22:10 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

r3909 (2.2) r3910 (2.3)