Ticket #2133 (closed Bugs: fixed)

Opened 6 years ago

Last modified 6 years ago

2.3.0Beta2 - draw_graph function is confused by numbers formatted with ',' - comma

Reported by: habile Assigned to: gregmac
Priority: minor Milestone: 2.4
Component: Core Version: 2.3-branch
Keywords: Dashboard memory draw_graph Cc:
Confirmation: Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable): 2.3.0Beta2

Description

In my locale (not French ;)) a comma is used to separate 1000 digits with a comma, e.g. 2027.30 will become: 2,027.30

Line 168 of page.index.php formats the total memory value using: number_format(...,2) -- this results in the value: e.g 2,027.30 being passed to the draw_graph function which results in a nonsense graph being created with a huge percentage.

I think we need to fix draw_graph to perhaps format the number to allow the raw values to be passed in instead.

Change History

07/22/07 13:28:13 changed by p_lindheimer

  • owner set to gregmac.

greg - shouldn't we just put number_format() inside the draw_graph routine anyhow and only calling it when we are displaying full numbers?

07/22/07 15:00:20 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

r4509, r4510