Ticket #2167 (closed Patches: wontfix)

Opened 5 years ago

Last modified 5 years ago

[PATCH] MySQL 3 doesn't support CAST

Reported by: julianjm Assigned to: p_lindheimer
Priority: minor Milestone: 2.3
Component: Core Version: 2.3-branch
Keywords: Cc:
Confirmation: SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

Little fix, that will allow FreePBX to work on old systems (FC2,3) where only Mysql version 3 is packaged.

It's a oneliner.

Attachments

freepbx_core_mysql3.diff.txt (0.9 kB) - added by julianjm on 07/27/07 08:45:00.
freepbx_core_mysql3.diff (0.9 kB) - added by julianjm on 07/27/07 08:45:48.

Change History

07/27/07 08:45:00 changed by julianjm

  • attachment freepbx_core_mysql3.diff.txt added.

07/27/07 08:45:48 changed by julianjm

  • attachment freepbx_core_mysql3.diff added.

08/01/07 12:18:49 changed by p_lindheimer

  • status changed from new to closed.
  • type changed from Bugs to Patches.
  • resolution set to wontfix.

wontfix - we don't support pre-MySQL 4

08/01/07 21:25:43 changed by julianjm

  • status changed from closed to reopened.
  • resolution deleted.

I'm fine with not supporting old versions of MySQL (if they may cause trouble), but this patch is trivial to apply. And using '+0' instead of a cast to integer is already used in current FreePBX code. 

[/var/www/html/admin/modules/core]# grep \+0 *
functions.inc.php:              $sqlstr .= "ORDER BY RIGHT( variable, LENGTH( variable ) - 4 )+0";

08/02/07 04:24:44 changed by p_lindheimer

  • status changed from reopened to closed.
  • resolution set to wontfix.

Julian, you ticket is not going anywhere and is available to anyone who wants to grab it. It is being closed because we don't support pre- MySQL 4 and the fact that such code exists elsewhere is no indication that it won't be changed breaking in future versions as well.