Ticket #2245 (closed Bugs: fixed)

Opened 6 years ago

Last modified 6 years ago

old framework files copied back to system

Reported by: p_lindheimer Assigned to: p_lindheimer
Priority: minor Milestone: 2.3
Component: Installation Version: 2.3-branch
Keywords: framework Cc:
Confirmation: Pending Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

this is really the same issue that module_admin doesn't do any cleanup, but particularly annoying with Framework. Since the tarball just gets exploded, old files that may have been removed stay in the framework directory and are copied back in. This could be handled one of a couple ways:

  • After the framework install script runs, it could delete the directories but then if anything went wrong, they would be deleted. It could skip the delete if an error occured?
  • module_admin could special case the framework install and remove the 'static' directories that it creates before exploding the new tarball.

I'm leaning towards the second, although the first has the advantage of not having all the install files laying around twice...

Change History

08/18/07 20:34:02 changed by p_lindheimer

  • confirmation changed from Confirmed to Pending.

r4892 - need to copy removefiles.php into the final release so that it get run again and assures the files are gone. Leaving ticket open until final release to make sure this happens.

08/19/07 01:28:29 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

tested and ready to svn ci - in upgrades/2.3.0 so closing