Ticket #2295 (closed Bugs: fixed)

Opened 4 years ago

Last modified 2 years ago

[bad-number] context as coded causes problems with phones that use the "early dial" feature

Reported by: rjch Assigned to: p_lindheimer
Priority: minor Milestone: 2.3
Component: Core Version: 2.3.0
Keywords: bad-calls Cc:
Confirmation: Pending SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

The use of _X. as an extension means that all phones that use the "early dial" feature (such as the Grandstream phones) cannot dial any extension of more than 2 digits, nor any feature code of more than 1 digit.

If there is no other option available to catch "other" calls (given that using the i extension doesn't work in a sub-context) then can we either (a) have the option to disable the bad-calls context or (b) supply a different match string? (e.g. because we have extensions starting with digits 4 to 8, _[4-8]XX would be quite acceptable here)

Change History

08/18/07 01:19:45 changed by p_lindheimer

  • confirmation changed from Unreviewed to Pending.
  • version changed from 2.2.3 to 2.3-branch.
  • milestone changed from 3.0 to 2.3.

you can redefine the bad-number context in extension_custom.conf and it should override what is in the main system. We will review the bug in the mean time but the GS is the only phone that does this and we need to evaluate the benefits of the feature which is much more user friendly then the old system, to this 'interesting' feature that GS implements which is usually implemented by other vendors with some form of digitmap in the end points.

08/19/07 01:02:48 changed by p_lindheimer

moved bad-number context into core, default is enabled. AMPBADNUMBER=false in amportal.conf will disable and revert back to previous behavior. Will be checked in once framework is upgraded because of amportal.conf parser.

08/20/07 23:59:56 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

r4905, r4917

08/21/07 00:05:07 changed by p_lindheimer

r4918

11/03/07 13:33:29 changed by acumensystems

hi - that's great, but i cant find out what the process is for these modules to be compiled into the module updates FreePBX manages. is the only way to obtain this fix to checkout directly from SVN to the correct location?

thanks

11/03/07 13:39:15 changed by p_lindheimer

  • version changed from 2.3-branch to 2.3.0.

its fixed and in the released product, just set 

AMPBADNUMBER=false

in your amportal.conf file and then do something to make the orange bar come up and press it. Please take any subsequent discussion to the forum, this ticket is fixed and closed.

11/03/07 13:49:09 changed by acumensystems

Understood- thanks.

http://www.freepbx.org/forum/freepbx/installation/branches-modules-update-cycle

03/27/10 12:04:35 changed by matt_001

A second problem prevents the Quick Dial feature on Grandstream phones from working correctly. In extensions_additional.conf the following code is generated: 

[outbound-allroutes]
include => outbound-allroutes-custom
include => outrt-001-9_outside
exten => _!,1,Macro(user-callerid,SKIPTTL,)

The last line also catches all extensions when dialling from an internal extension and prevents quick-dial from working correctly. Commenting-out the line fixes the problem.

The code is generated by /var/www/html/admin/modules/core/functions.inc.php, line 1533: 

                        /* outbound routes */
                        // modules should use their own table for storage (and module_get_config() to add dialplan)
                        // modules should NOT use the extension table to store anything!
                        $sql = "SELECT application FROM extensions where context = 'outbound-allroutes' ORDER BY application";
                        $outrts = sql($sql,"getAll",DB_FETCHMODE_ASSOC);
                        $ext->addInclude('from-internal-additional','outbound-allroutes');
                        $ext->add('outbound-allroutes', '_!', '', new ext_macro('user-callerid,SKIPTTL'));

Commenting out the last line leaves a clean dial plan, resolving the quick dial issue - but I don't know what else this might interfere with, I don't see how callerid is relevant in a catch-all.

03/27/10 13:04:59 changed by p_lindheimer

actually it is very relevant as you can create routes based on CID. You'll have to open a new ticket for this as it is a new issue.