Customized FOP setting for column settings need to mvoe3 to a config file

the system will not prompt about overwriting core scripts beyond what already exists in install_amp. People who do modifications will have to address their own systems and there are plenty of ways to do that. (patch plus model, write protect, etc.)

If you have modifications, how about making those modifications more general purpose (calculate the number of extensions and then size accordingly). Sounds like what you have done is one step removed from that.

If you do that and submit it then we can get it into the code base and it fixes your problem and everyone else who has a similar situation. That's one of the benefits of Open Source, not keeping your fixes to yourself - sending them back for all to use. If the config file is really the way to go, then make that change and submit it for review - although I prefer if possible to have it auto calculate and generate the stuff.

At this time because we have change SO much it's not that simple. We've tweaked the spacing inside each phone to make it look ok, added another full height column for extensions and also increased the space for trunks as we have 25 total, along with space for parking and conferance rooms (yea not supported yet)... It's not a simple thing. I spent two days tweaking it all to look right for the people who need to use it.

I am attempting to look in to making the FOP support includes for some files so that I can place my changes into a _custom file that will not get over written. Yes I have a scheme currently so that when they do get overwritten I can recover from it but it's a PITA to have to remember and do each time.

If I knew PHP and or Perl I'd think about taking it on but I don't.

I'm willing to do the work to move the position variables into the config file. I was going to add some more FOP* variables to /etc/amportal.conf. For example FOPEXTENPOS. Let me know if you think there is a better way.

Giving an auto completion might come after that, perhaps when FOPEXTENPOS is set to "auto".

Just as a possible starting point, I've moved the $...pos settings from retrieve_op_conf_from_mysql to a new "config file" /var/www/html/panel/op_conf.pl, which could then contain something like:

 $extenpos="2-40";
 $trunkpos="53-60,72-80";
 $parkingpos="50-51,69-71";
 $confepos="46-48,65-68";
 $queuepos="42-44,61-64";

In the original file, it's included with

 require "retrieve_parse_amportal_conf.pl";

See patch.

the problem with this is that we would still overwrite the include file as you have done it if we have to change things. Why don't you try something like this in the main file and if it works we can add it once tested:

$extenpos="2-40";
$trunkpos="53-60,72-80";
$parkingpos="50-51,69-71";
$confepos="46-48,65-68";
$queuepos="42-44,61-64";

# Now include conf file exists, and re define any and all
# of the above paramters so user can control changes without
# getting overwritten
if (file_existst($astetc_path."/fop.conf")) {
 include "$astetc_path.'/fop.conf'"
}

I also like this idea/approach better. Wish I knew Perl better to have come up with that as that was more my thinking originally. I also think that the FOP author would accept a change like this more easily so that it can be integrated into the base code he uses.

one more thing: for the same of continuity as well as for backup purposes, perhaps this file should be located in /etc/asterisk

thus my pseudo code: $astetc_path."/fop.conf"

I just can't recall where that path is put in the perl parser that this uses. BTW - this code is part of FreePBX not FOP, so no need to include it back into FOP. What would be nice is if someone wanted to migrate this to php so we have one more perl script out of the way :-)

btw - if you want to get this working and tested, we can get it into 2.5.

ops, my bad :)