Ticket #2366 (closed Patches: wontfix)

Opened 4 years ago

Last modified 4 years ago

GUI correction. "outbound routing" route list is shows 'up/down' arrows to the right of route name.

Reported by: Blackdog Assigned to: p_lindheimer
Priority: minor Milestone: 2.6
Component: Core - Trunks/Routing Version: 2.3.0
Keywords: inline-block Cc:
Confirmation: Need Feedback SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description (Last modified by p_lindheimer)

The following patch moves the up and down arrows from the next line, back to the right of the 'outbound route' name. It assumes the outbound route fits in around 120px, but this sits nicely with the other 'rnav' limitations.

NOTE the use of style='display:-moz-inline-stack; display:inline-block;' This allows the change to work correctly in firefox (which understands -moz-inline-stack) and internet explorer (which understands inline-block). Other browsers have not been tested.

NOTE ALSO, the 'display' and 'width' flags may be better placed in common/mainstyle.css under '.rnav ul li a'

*** admin/modules/core/page.routing.php.save    2007-09-08 09:28:23.000000000 +1000
--- admin/modules/core/page.routing.php 2007-09-08 09:27:40.000000000 +1000
***************
*** 205,214 ****
  $positions=count($routepriority);
  foreach ($routepriority as $tresult) {
        $key++;
!               echo "\t<li>\n\t\t<a " . ($extdisplay==$tresult[0] ? 'class="current"':'') .
                        " href=\"config.php?display=" .
                        urlencode($display)."&amp;extdisplay=" .
!                       urlencode($tresult[0]) . "\">$key " . substr($tresult[0],4)."</a>\n";

                if ($key > 0)
                        echo "\t\t<img src=\"images/scrollup.gif\" onclick=\"repositionRoute('$key','up')\" alt='" .  _("Move Up") .
--- 205,214 ----
  $positions=count($routepriority);
  foreach ($routepriority as $tresult) {
        $key++;
!               echo "\t<li>\n\t\t<span style='display:-moz-inline-stack; display:inline-block; width:120px;'><a " . ($extdisplay==$tresult[0] ? 'class="current"':'') .
                        " href=\"config.php?display=" .
                        urlencode($display)."&amp;extdisplay=" .
!                       urlencode($tresult[0]) . "\">$key " . substr($tresult[0],4)."</a></span>\n";

                if ($key > 0)
                        echo "\t\t<img src=\"images/scrollup.gif\" onclick=\"repositionRoute('$key','up')\" alt='" .  _("Move Up") .

Attachments

page.routing.patch (1.2 kB) - added by Blackdog on 09/08/07 08:17:24.
Patch file for gui update against 2.3.0.2
page.routing.php.patch (0.8 kB) - added by Blackdog on 11/27/07 23:08:54.
Updated Patch (in unified diff format)

Change History

09/08/07 08:17:24 changed by Blackdog

  • attachment page.routing.patch added.

Patch file for gui update against 2.3.0.2

11/27/07 22:02:47 changed by p_lindheimer

Blackdog,

can you please provide your patches in 'unified output format' (e.g. diff -ubB or the same format that 'svn diff' would give). This allows us to view the patches in the trac viewer as well as being easier to read and more standard.

Thanks

11/27/07 23:08:54 changed by Blackdog

  • attachment page.routing.php.patch added.

Updated Patch (in unified diff format)

12/02/07 01:40:58 changed by p_lindheimer

  • confirmation changed from Unreviewed to Confirmed.
  • milestone changed from 2.4 to 3.0.

07/15/08 19:42:52 changed by p_lindheimer

  • confirmation changed from Confirmed to Need Feedback.
  • description changed.

Blackdog,

I took a look but it does not look good when you have a wide range of route names, some of the arrows are staggered. If you want to change it so the up/down arrows are on the far left, such that they are consistent despite the route name, that seems like it would be an improvement. Please re-submit it as a patch like the attached one. Thanks.

07/23/08 01:08:28 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to wontfix.
  • milestone changed from 2.5 to 3.0.

Closing due to no response. If someone wants to supply the request, we can take a look.