Ticket #2384 (closed Bugs: fixed)

Opened 4 years ago

Last modified 4 years ago

bad numbers in cdr didn't show correct caller-id

Reported by: tbsky Assigned to: p_lindheimer
Priority: minor Milestone: 2.4
Component: Asterisk Configuration Version: 2.3.0
Keywords: bad numbers caller-id Cc:
Confirmation: Need testing SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

hi:

i am using freepbx extension mode.if i dial a random wrong number, the clid field in cdr shows like:"device" <1234>. the "_X." dial pattern in "bad-number" context didn't lookup caller-id macro, so the user field is shown as "device".maybe it should do this to make the cdr more complete?

Change History

09/17/07 15:22:52 changed by p_lindheimer

even better would be to try to get rid of the CDR records. If anyone wants to try to do that and it works I'd like to get it in. Short of that, I would agree it should call macro-usercallerid so we'll leave this ticket open to do one of the two.

09/17/07 20:30:18 changed by p_lindheimer

  • owner set to p_lindheimer.
  • status changed from new to assigned.
  • confirmation changed from Unreviewed to Need testing.

try the following and tell me if the CDR records go away: 

Index: functions.inc.php
===================================================================
--- functions.inc.php   (revision 5033)
+++ functions.inc.php   (working copy)
@@ -508,6 +508,8 @@
                        if ($amp_conf['AMPBADNUMBER'] !== false) {
                                $context = 'bad-number';
                                $exten = '_X.';
+                               $ext->add($context, $exten, '', new extension('ResetCDR()'));
+                               $ext->add($context, $exten, '', new extension('NoCDR()'));
                                $ext->add($context, $exten, '', new ext_wait('1'));
                                $ext->add($context, $exten, '', new ext_playback('silence/1&cannot-complete-as-dialed&check-number-dial-again,noanswer'));
                                $ext->add($context, $exten, '', new ext_wait('1'));
@@ -515,6 +517,8 @@
                                $ext->add($context, $exten, '', new ext_hangup());
 
                                $exten = '_*.';
+                               $ext->add($context, $exten, '', new extension('ResetCDR()'));
+                               $ext->add($context, $exten, '', new extension('NoCDR()'));
                                $ext->add($context, $exten, '', new ext_wait('1'));
                                $ext->add($context, $exten, '', new ext_playback('silence/1&feature-not-avail-line&silence/1&cannot-complete-as-dialed&check-number-dial-again,noanswer'));
                                $ext->add($context, $exten, '', new ext_wait('1'));

09/17/07 23:47:15 changed by tbsky

hi:

the patch works for me. no more cdr for random wrong numbers.

09/18/07 00:36:54 changed by p_lindheimer

  • status changed from assigned to closed.
  • resolution set to fixed.

r5045 - don't create a CDR field for these numbers