Ticket #2543 (closed Patches: invalid)

Opened 4 years ago

Last modified 4 years ago

Add multiple DID entries to Users

Reported by: prolfe Assigned to: p_lindheimer
Priority: minor Milestone: 2.5
Component: Core - Users/Devices Version: 2.3.1
Keywords: did multiple Cc:
Confirmation: Confirmed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

I had the requirement to have multiple DID's for many of our users. The FreePBX interface doesn't appear to support this by default.

I have extended functions.inc.php to allow multiple DID to be entered into the "Direct DID" field, each separated by a comma. Further mods were also made to ensure the each DID was populated to the extensions_additional.conf correctly via the core_get_config() function.

Attachments

functions.inc.php.diff (8.0 kB) - added by prolfe on 12/14/07 00:04:46.

Change History

(follow-up: ↓ 2 ) 12/13/07 23:11:21 changed by p_lindheimer

  • confirmation changed from Unreviewed to Confirmed.

a couple of observations:

we will be changing the way these are handled in the next release of so, to where they share the same table with inbound routes so this would become an issue this way.

From a very quick glance at this patch, it looks like you are bypassing the conflict check and it would be possible to slip in the same did on either two users or between a user and inbound route - you may want to check that.

(in reply to: ↑ 1 ) 12/14/07 00:03:56 changed by prolfe

Replying to p_lindheimer:

a couple of observations: we will be changing the way these are handled in the next release of so, to where they share the same table with inbound routes so this would become an issue this way. From a very quick glance at this patch, it looks like you are bypassing the conflict check and it would be possible to slip in the same did on either two users or between a user and inbound route - you may want to check that.

Corrected version attached.

Now checks each DID. If a conflict is found, only removes the DID causing the issue.

Thanks for the feedback.

12/14/07 00:04:46 changed by prolfe

  • attachment functions.inc.php.diff added.

07/12/08 20:30:50 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to invalid.
  • milestone changed from Cut Line to 2.5.

this is invalid with the new way that DIDs are managed.