Ticket #2580 (closed Patches: invalid)

Opened 4 years ago

Last modified 4 years ago

macro-dial is making errors...

Reported by: pnlarsson Assigned to:
Priority: minor Milestone: 2.5
Component: Asterisk Configuration Version: 2.4-branch
Keywords: Cc:
Confirmation: Need testing SVN Revision (if applicable):
Backend Engine: Asterisk 1.4.x Backend Engine Version:

Description 

[Dec 22 16:48:55] WARNING[10142] pbx.c: Unable to register extension 's', priority 30 in 'macro-dial', already in use
[Dec 22 16:48:55] WARNING[10142] pbx.c: Unable to register extension 's', priority 31 in 'macro-dial', already in use

Only warnings, but it's good to get rid of them, the easy way is: 

exten => s,n,Goto(s,a22)

exten => s,30(a50),DBdel(CALLTRACE/${CT_EXTEN})
exten => s,n,Goto(s,a42)

change to 

exten => s,n,Goto(s,a22)

exten => s,(a50),DBdel(CALLTRACE/${CT_EXTEN})
exten => s,n,Goto(s,a42)

The more complex and also not very tested is attached...

Attachments

extensions.conf.diff (2.1 kB) - added by pnlarsson on 12/22/07 14:07:13.

Change History

12/22/07 14:07:13 changed by pnlarsson

  • attachment extensions.conf.diff added.

07/01/08 17:47:33 changed by mbrevda

  • confirmation changed from Unreviewed to Need testing.

devs: can this be committed?

07/05/08 06:10:47 changed by pnlarsson

I would like to commit this to trunk and then see what happens... It's should work, but the change it quit big and in a very sensitive code.

07/05/08 10:26:50 changed by p_lindheimer

  • milestone changed from Cut Line to 2.5.

pnlarsson, as far as the bug report, why is it complaining about unable to register? I think they may have it redefined in their _custom file. As far as trying the patch, I'm ok with that as it does make it cleaner to read and understand. Make sure to update as Ethan recently checked in changes that effect macro-dial for his caller announcement code. Just make sure to test both a normal dial and hunt group dial to exercise both paths.

While you are at is: [findmefollow-ringallv2prim] 

exten => _FMGL-.,n+10(dodnd),DBDel(FM/DND/${FMGRP}/${FMUNIQUE})

and in paging group's [macro-autoanswer] 

exten => s,n+2(macro),Macro(${DB(DEVICE/${ARG1}/autoanswer/macro)},${ARG1})
exten => s,n+2(macro2),Macro(${ANSWERMACRO},${ARG1})

07/15/08 19:30:56 changed by p_lindheimer

pnlarsson, were you going to try this out?

07/23/08 01:17:53 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to invalid.

pnlarsson,

the patch no longer applies so I'm closing this. If you want to clean it up and test it, we can try to get the change in then but we need to do it soon, I don't want to put this in once beta starts. Even though it is straight forward, it is at the very core.