Ticket #2593 (closed Feature Requests: fixed)

Opened 4 years ago

Last modified 4 years ago

Password for Voice Mail Box - Do not make it mandatory

Reported by: rogerluo Assigned to:
Priority: major Milestone: 2.5
Component: Voicemail Version: 2.4-branch
Keywords: password Cc:
Confirmation: Confirmed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

The system insists on setting up a password for a voicemail box. Suggest to remove this requirement to allow users to decide whether to protect their voice mail boxes or not. If so, they can enter passwords to protect their voicemail boxes; if not, they can leave this field blank so voice mail access is instantaneously.

Attachments

voicemail.patch (1.9 kB) - added by dgorski on 02/14/08 00:50:51.
modules/voicemail/functions.inc.php diff to fix this bug
functions.inc.php.patch (3.0 kB) - added by dgorski on 07/07/08 00:33:07.
patch for modules/voicemail/functions.inc.php (2.4.0.1) with confirmation dialog

Change History

(follow-up: ↓ 2 ) 12/29/07 09:31:21 changed by mbrevda

try using use s option in a custom dialplan to bypass the voicemail password

(in reply to: ↑ 1 ) 01/03/08 21:22:16 changed by rogerluo

Thanks.

But the GUI interface of FreePBX extension module insists on having a password. I could not leave the password field blank.

I use TrixBox. I know nothing about dialplan programming.

01/04/08 13:48:26 changed by rogerluo

The 2.4.beta2 also insists on a password at the GUI for extension.

01/12/08 15:14:18 changed by p_lindheimer

  • confirmation changed from Unreviewed to Confirmed.
  • version changed from 2.3.1 to 2.4-branch.
  • milestone changed from Cut Line to 2.4.

will review

01/15/08 12:34:03 changed by dgorski

This is a problem with the voicemail module. I was able to make the change in order to accept empty VM passwords in the FreePBX GUI:

admin/modules/voicemail/functions.inc.php line 349:

Change:

"frm_${display}_isVoiceMailEnabled() && !isInteger()"

To:

"frm_${display}_isVoiceMailEnabled() && !isEmpty() && !isInteger()"

- Darrin

01/15/08 12:38:39 changed by dgorski

Sorry - I'm using FreePBX 2.3, Core 2.3.1.4 and Voicemail 2.0.3.4 so the line number referenced above may be incorrect for a later version.

- Darrin

01/27/08 13:40:26 changed by p_lindheimer

  • milestone changed from 2.4 to 3.0.

02/14/08 00:50:51 changed by dgorski

  • attachment voicemail.patch added.

modules/voicemail/functions.inc.php diff to fix this bug

02/14/08 00:53:19 changed by dgorski

Attached a patch for the Voicemail module version 2.4.0.1 that fixes the problem in functions.inc.php.

07/05/08 16:26:16 changed by mbrevda

I'm still not sure this is the best route to avoid having to enter you password to check VM. Currently you can enter any password in to the gui and use the s option to alleviate having to enter the password when you check your voicmeail. While you might need a line or two of dialplan to get that going, I dont think that the password field should be allowed to be left blank.

(follow-up: ↓ 11 ) 07/06/08 21:51:06 changed by dgorski

I disagree. This is a BUG. For the longest time one was able to leave the voicemail password field blank in the GUI. The interface needs to be flexible. Forcing the use of a password and then going into the dialplan and forcing the passwords to be ignored is not an appropriate solution. That approach does not allow for a mixture of the two modes.

A simple office with a small number of users who don't want passwords on their voicemail boxes my not have the savvy to update the dialplan in this way - look at the comments for an example of such a user.

This is a trivial fix, look a the patch (or indeed the thread above where the fix is described). If you want to add a "no voicemail password specified, are you sure" dialog box to the check, I could see that, but disallowing empty passwords is a bug, plain and simple.

It used to work and now it doesn't. That's a bug.

(in reply to: ↑ 10 ) 07/06/08 22:10:13 changed by p_lindheimer

Replying to dgorski:

It used to work and now it doesn't. That's a bug.

No, this does not make something a bug. Something having worked may have been the bug. There are plenty of cases where javascripts were in place that were suppose to block things but had syntax errors that made them useless, or where there was no validation. So putting validation in place where there was not before is NOT a bug.

With that said, if you want to provide a patch that pulls up a confirmation box instead allowing the user to not put in a pass word but providing a warning, then feel free to submit it and we'll have a look at putting it in. But for now, allowing an empty password without any feedback IS a bug so until there is the above submitted it will be left as is.

07/07/08 00:31:36 changed by dgorski

Fair enough I suppose. I still liked it the other way, but I relent.

07/07/08 00:33:07 changed by dgorski

  • attachment functions.inc.php.patch added.

patch for modules/voicemail/functions.inc.php (2.4.0.1) with confirmation dialog

07/07/08 00:49:39 changed by mbrevda

  • status changed from new to closed.
  • resolution set to fixed.

dgorski: Welcome aboard! r5929

07/07/08 01:08:32 changed by dgorski

Awesome. Thanks!

07/07/08 02:33:02 changed by mbrevda

Your welcome. BTW, it seems like you quite capable. If your so inclined, we can always use another set of hands around here :)