Ticket #2638 (closed Patches: worksforme)

Opened 4 years ago

Last modified 4 years ago

(PATCH) DISA module, string quoting problem with caller ID field and SQL database

Reported by: tara Assigned to:
Priority: minor Milestone: Undetermined
Component: DISA Version: 2.4-branch
Keywords: cid Cc:
Confirmation: Unreviewed SVN Revision (if applicable):
Backend Engine: Asterisk 1.4.x Backend Engine Version: 1.4.17

Description

Hi, in Disa 2.4.0, as part of freePBX 2.4.0Beta2.2, I ran across a problem with quoting the Caller ID field within the DISA module. Anyways, so that I can end this day productive, I post it here in hopes that someone with smarts and know-how can fix the minor bug. The problem is quoting of the " is not done right, so when trying to insert into the DB, the insert fails, and you get a big insert error from MySQL. I hereby release this in the public domain to do with as you will. I was lazy, but here is a patch(hopefully attached)

Attachments

disa.patch (1.6 kB) - added by tara on 01/20/08 14:21:35.
Patch for admin/modules/disa/functions.inc.php

Change History

01/20/08 14:21:35 changed by tara

  • attachment disa.patch added.

Patch for admin/modules/disa/functions.inc.php

(follow-up: ↓ 3 ) 07/01/08 17:51:25 changed by mbrevda

  • status changed from new to closed.
  • resolution set to worksforme.

hmm, I seem to have no problem using a quoted name for disa. "Moshe" <220> worked just fine. Im closing for now, please reopen if I misunderstood your intent.

07/06/08 17:52:27 changed by tara

mbrevda: It's Single quotes, not double quotes that this fixes. Sorry even I had the problem wrong in the description.

(in reply to: ↑ 1 ) 07/06/08 17:54:22 changed by tara

Replying to mbrevda:

hmm, I seem to have no problem using a quoted name for disa. "Moshe" <220> worked just fine. Im closing for now, please reopen if I misunderstood your intent.

I can't reopen this bug for whatever reason, and It didn't email me that there was a change (i.e. you response) hence why it took so long for me to reply. I dunno why this site hates me.

07/06/08 20:00:56 changed by p_lindheimer

tara: you can got to your main account on freepbx.org and tell it whether or not you want emails sent for trac bugs you are associated with.

In the meantime, does this need to be re-opened? Let us know.