Ticket #2646 (closed Patches: invalid)

Opened 4 years ago

Last modified 4 years ago

Ensuring asterisk stops and some good practice freepbx_engine

Reported by: jfinstrom Assigned to: p_lindheimer
Priority: minor Milestone: 2.5
Component: Core Version: 2.4-branch
Keywords: amportal, amp_engine Cc:
Confirmation: Need Feedback SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

I remember seeing #2474 but didn't really read why he suggested it. I have seen amportal stop not kill asterisk but continue I have attached a patch that watches for asterisk to quit in case it hangs. I have also gone through and updated the backtick method to the dollar parenthisies method which is considered good practice by the bash folks...

Attachments

freepbx_engine (7.3 kB) - added by jfinstrom on 01/24/08 10:52:28.
freepbx_engine.patch (2.9 kB) - added by jfinstrom on 01/24/08 10:53:17.
the patch

Change History

01/24/08 10:52:28 changed by jfinstrom

  • attachment freepbx_engine added.

01/24/08 10:53:17 changed by jfinstrom

  • attachment freepbx_engine.patch added.

the patch

01/27/08 10:49:12 changed by p_lindheimer

  • confirmation changed from Unreviewed to Need Feedback.
  • milestone changed from Cut Line to 2.4.

there is an issue that it does not force Asterisk to stop. However, what if Asterisk is waiting for channels to hangup. Neither current nor this are the desirable effect. Why don't you work on another modification:

1. amportal stop and restart should wait 'forever' for Asterisk to stop
2. amportal stop_now and restart_now could implement something like you have done

then we can take a look at doing the mods. For now, my preference is the current flakey behavior of not stopping over killing active calls in error.

02/07/08 14:14:49 changed by p_lindheimer

  • milestone changed from 2.4 to 3.0.

Jim, I'm going to move this out to the next milestone for now. We can always backport to 2.4 if a good implementation comes up but it is getting late in the 2.4 game...

07/13/08 09:34:41 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to invalid.

jfinstrom, I'm closing this for now as invalid. If you want to update it so that there is a force stop and a normal stop that would be great and we could get it in and I'll re-open it. See my comments.