Ticket #2699 (closed Feature Requests: fixed)

Opened 9 months ago

Last modified 4 months ago

not enough room in FOP for trunks

Reported by: dziny Assigned to:
Priority: minor Milestone: 2.5
Component: Flash Operator Panel Version:
Keywords: FOP customization Cc:
Confirmation: Confirmed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

I have to total of 21 trunks (counting both outgoing and incoming), but FOP does not have enough room for all of them. Of course I can modify manually op_panel files to show them all, but any freepbx reload destroys my changes.

I would sugest to add feature that would allow the user to choose how the FOP space is divided between Queues, Conferences, Parking lot and Trunks, for example I don't need any Queues and Conferences, so I would like to be able to expand Trunk space at their expense.

Attachments

retrieve_op_conf_from_mysql.patch (4.0 kB) - added by Nick_Lewis on 07/25/08 06:57:20.
missed a bit
retrieve_op_conf_from_mysql.2.patch (6.2 kB) - added by Nick_Lewis on 07/30/08 03:40:31.
now with option of layout from database
install.sql (0.9 kB) - added by Nick_Lewis on 07/30/08 03:54:32.
example of a panel table
retrieve_op_conf_from_mysql.3.patch (3.1 kB) - added by Nick_Lewis on 08/01/08 02:21:13.
bug fix

Change History

02/21/08 19:51:30 changed by p_lindheimer

  • confirmation changed from Unreviewed to Confirmed.
  • version deleted.
  • milestone changed from Cut Line to 3.0.

we would be happy if someone wants to step up to the plate and take ownership for such FOP requests. Right now there are no Devs who have the interest in working on it so until someone comes forward...

02/22/08 06:20:39 changed by fskrotzki

dziny,

Edit /var/lib/asterisk/bin/retrieve_op_conf_from_mysql.pl and change the slots that are allocated for the trunks. you'll find a line starting with $trunkpos= this is the line that assigns where it places the trunks on the display. It takes a series of slot positions.

Yes not a pretty fix currently but it does work as I've re-configured most of the slots for my use of 59 extenssions, 9 parking lot slots, 19 conferances and 29 trunks (we don't use queues).

I'm working on a patch that will read these values from a config file so that changes are never lost.

02/22/08 07:52:42 changed by dziny

Thanks! Really appreciate your help, it's a good temporary fix.

06/15/08 01:31:20 changed by lazytt

  • owner deleted.

07/16/08 09:23:43 changed by p_lindheimer

  • milestone changed from 2.5 to 3.0.

moving FOP to future milestone

07/25/08 06:57:20 changed by Nick_Lewis

  • attachment retrieve_op_conf_from_mysql.patch added.

missed a bit

07/25/08 07:12:47 changed by Nick_Lewis

I have attached a patch that integrates the layout elements (rectangles and legends) of op_button.cfg with the button definitions of op_button_additional.cfg. (Since the layout elements are now added dynamically to op_button_additional.cfg they no longer need to be listed in op_button.cfg.)

If the sizes of the layout areas are modified then the available button positions are automatically adjusted to match. The legends are also automatically moved to the correct positions.

Currently the layout areas are defined in a structure near the top of the file

07/25/08 09:59:45 changed by p_lindheimer

  • milestone changed from 3.0 to 2.5.

07/25/08 10:05:17 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [6180]) closes #2945 and #2699 proper VM_PREFIX and dynamic screen space allocation, ref #2686 modified

07/30/08 03:40:31 changed by Nick_Lewis

  • attachment retrieve_op_conf_from_mysql.2.patch added.

now with option of layout from database

07/30/08 03:42:29 changed by Nick_Lewis

I have attached a patch that makes the following changes:

(i) If a "panel" table exists in the freepbx database then layout info is taken from the database. This is primarily a hook for a forthcoming panel module but can be used now with phpMyAdmin

(ii) Legends can be customised without breaking the association between buttons and rectangles. This permits non-english legends to be specified in layout info

(iii) Some layout constants are made explicit

(iv) Color2 for conference rectange is improved/corrected

This patch has been tested with a panel table using phpMyAdmin

07/30/08 03:54:32 changed by Nick_Lewis

  • attachment install.sql added.

example of a panel table

08/01/08 02:21:13 changed by Nick_Lewis

  • attachment retrieve_op_conf_from_mysql.3.patch added.

bug fix

08/01/08 02:23:39 changed by Nick_Lewis

I regret that further testing has identified a bug in the generation of the style-info from the layout-info for very small rectangles. The bug is present in head [6180] but the fix that I have attached includes the retrieve_op_conf_from_mysql.2.patch functional enhancements. Philippe please let me know if you would rather have a minimal fix of [6180] instead.

08/01/08 06:24:13 changed by Nick_Lewis

I have produced a panel module that can be used to configure the FOP layout in conjunction with the 'panel' database table support that was added to retrieve_op_conf_from_mysql.pl by the patches above.

This panel module can be found at

http://freepbx.org/trac/browser/contributed_modules/modules/panel

08/01/08 07:17:43 changed by p_lindheimer

Nick, can you please re-submit this as a new ticket as this one is closed. You can reference this or other related tickets there. Thanks. (also - when you add new modules to the contributed modules directory, it would be good to open a new module ticket here and point at the new module so people can search and find out about it.)

Donate



Support
Download
Develop
Forums
News
Documentation
Paid Support
About

Paid Ads