Ticket #2806 (closed Bugs: worksforme)

Opened 4 years ago

Last modified 4 years ago

On demand recording doesn't show up on ARI correctly

Reported by: mok Assigned to: pkaplan
Priority: major Milestone: 2.5
Component: ARI Version: 2.3.1
Keywords: call monitor Cc:
Confirmation: Need Feedback SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description (Last modified by p_lindheimer)

Problem : Using "*1" on demand recording to record calls. After 2nd recorded calls, the ARI call monitor page doesn't show the 'Play' link properly. All rows in the first page has a 'Play' link with the last recorded call. I cannot retrieve any previous recorded call from the call monitor page anymore.

Proposed fix : This problem was because of the $unique_file_key variable didn't initialize properly key within the matching loop.

Fixed by initialize $unique_file_key variable in /var/www/html/recordings/modules/callmonitor.module getRecordings function. 

// unique file key
$unique_file_key="";   <--- added line to initialize $unique_file_key
if ($uniqueid) {
$buf = preg_replace('/\-|\:/', '', $calldate);
$calldate_key = preg_replace('/\s+/', '-', $buf);
$unique_file_key = $calldate_key . "-" . $uniqueid;
}

Change History

04/24/08 18:15:07 changed by p_lindheimer

  • description changed.

04/24/08 18:34:18 changed by p_lindheimer

  • confirmation changed from Unreviewed to Need Feedback.
  • milestone changed from Cut Line to 3.0.

I put this in (basically the same thing as you have): 

Index: callmonitor.module
===================================================================
--- callmonitor.module  (revision 5722)
+++ callmonitor.module  (working copy)
@@ -385,6 +385,7 @@
     foreach($data as $data_key => $data_value) {
 
       $recording='';
+      $unique_file_key ='';
 
       $calldate = $data_value['calldate'];
       $duration = $data_value['duration'];

however I don't see it making a difference? In my case I have several on demand calls I made, 15 pages back. But with or without the patch I see them and can play them? (note this is 2.4, however this should be unchanged from 2.3)

07/01/08 18:22:55 changed by mbrevda

any feedback on this? can we patch + close?

07/11/08 14:15:02 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to worksforme.

closing worksforme due to lack of feedback and that it does work, uninitialized variable fixed in a prior commit.