Ticket #2809 (closed Bugs: fixed)

Opened 5 years ago

Last modified 5 years ago

Case where ARI doesn't show outboundCID

Reported by: ip-rob Assigned to: pkaplan
Priority: minor Milestone: 2.5
Component: ARI Version: 2.4-branch
Keywords: Cc:
Confirmation: Confirmed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

If a user enters the outbound CID without bracketing the number with < or > then the number will be truncated by one character.

The attached patch looks for a < in the OutboundCID string and if it doesn't find one then it assumes the user forgot to add them. In this case, it just trims the CID for filtering.

We've seen cases where the users enter the same CID information as the Direct DID which doesn't require brackets. This patch attempts to correct user error so I'm not sure it is a bug!

Rob

Rob

Attachments

login.php.diff (0.8 kB) - added by ip-rob on 04/25/08 15:21:33.
Corrected version of patch file
login.php.patch (0.8 kB) - added by ip-rob on 04/25/08 16:38:43.
Corrected version

Change History

04/25/08 15:21:33 changed by ip-rob

  • attachment login.php.diff added.

Corrected version of patch file

04/25/08 16:16:55 changed by p_lindheimer

ip-rob, can you reattach the file as login.php.patch - it does not seem to like the .diff format (and I'm not sure if there is a setting in trac to make it so) - with .patch it is easily viewed for review. Thanks!

04/25/08 16:38:01 changed by ip-rob

I renamed it but it still doesn't show up in trac. Maybe it is something to do with the patch file...let me review and try attaching another version.

04/25/08 16:38:43 changed by ip-rob

  • attachment login.php.patch added.

Corrected version

04/25/08 16:39:25 changed by ip-rob

OK, got it this time. The file had a few comments at the bottom. Should be good now.

Rob

04/25/08 17:07:49 changed by p_lindheimer

  • status changed from new to closed.
  • confirmation changed from Unreviewed to Confirmed.
  • resolution set to fixed.
  • milestone changed from Cut Line to 3.0.

r5750 and r5751

I agree with what you are doing (so it is checked in). Where was the outboundcid being used that was creating issues?

04/25/08 17:11:47 changed by ip-rob

The issue came in that if the < or > was not included when they enter the outbound caller ID in the FreePBX interface then the call monitor module was not listing those calls. Specifically the ouboundCID variable was truncating the last number because of the formula used in the strpos function. That meant that if their outboundCID was entered as 5555551234 then the login.php set the outboundCIDto 555555123. This resulted in all CDR records with the src or dest equal to their outbound caller ID (5555551234 in this case) being excluded from the call monitor screen. I found it by someone noticing that only a fraction of their calls were listed in the ARI interface.

Does that make sense? Thanks!

Rob