Ticket #2972 (closed Bugs: wontfix)

Opened 4 years ago

Last modified 2 years ago

Problem with ZAP channel renaming in FOP

Reported by: Nick_Lewis Assigned to: asternic
Priority: minor Milestone: 2.6
Component: Flash Operator Panel Version: SVN-HEAD
Keywords: retrieve_op_conf_from_mysql.pl Cc:
Confirmation: Unreviewed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

The FOP configuration script retrieve_op_conf_from_mysql.pl looks in zapata.conf and zapata-auto.conf for the pseudo comment ;AMPLABEL: and uses it to rename zap channels. This does not work if the pseudo comment is in zapata.conf and the channel declarations are in zapata-auto.conf (which is typically the case).

Attachments

retrieve_op_conf_from_mysql.patch (442 bytes) - added by Nick_Lewis on 07/30/08 09:34:49.
minimal fix

Change History

07/30/08 09:34:49 changed by Nick_Lewis

  • attachment retrieve_op_conf_from_mysql.patch added.

minimal fix

07/30/08 09:48:31 changed by Nick_Lewis

I have attached a minimal fix.

A better solution would be for the parse_zapata function to follow the #include rather than the function being called a second time for parsing the zapata-auto.conf file. This would also allow for the ;AMPLABEL: pseudo comment to be in a more suitable file such as zapata_additional.conf or zapata_custom.conf . I will leave this for someone else to investigate. Perhaps there is a better way to implement ZAP trunk relabelling that does not involve pseudo comments in zapata*.conf files at all.

08/02/08 22:30:53 changed by p_lindheimer

  • milestone changed from Cut Line to 3.0.

Nick, is this just for zap outbound trunks, for inbound zap channels

08/04/08 04:32:37 changed by Nick_Lewis

Philippe, I think ;AMPLABEL: is designed to be used for all zap trunks and ;AMPWILDCARDLABEL(x): for zap extensions judging by the example file provided by rcourtna at

http://freepbx.org/trac/browser/freepbx/trunk/amp_conf/astetc/zapata.conf.template

I am not sure if I have understood your question correctly

10/16/08 11:46:30 changed by Nick_Lewis

The previously attached minor patch has now had extensive and prolonged testing so although it is not too important may I please request that it is applied to the trunk

10/16/08 16:39:18 changed by mbrevda

Why not phrase asterisk itself for the channel info? (zap show channels)

10/17/08 03:31:45 changed by Nick_Lewis

Asterisk does not contain this label info so the cli command zap show channels cannot retrieve it. rcourtna added the AMPLABEL and AMPWILDCARDLABEL keywords with preceeding semicolons (;) so asterisk treats them as comments and ignores them.

I cannot speak for rcourtna about the elegance of the method but it has been implemented in the code for over three years. My minor fix is merely to resolve a bug when zapata-auto.conf is used in addition to zapata.conf.

Normally FOP prefixes the channel numbers on the screen with the word "ZAP". Using the rcourna method it is possible to add the following line to zapata.conf

;AMPLABEL:Analog Line %c

and FOP will then prfix the channel numbers with "Analog Line" instead which is much more meaningful to the FOP user.

08/23/09 13:56:44 changed by p_lindheimer

  • owner changed from p_lindheimer to asternic.
  • component changed from Core to Flash Operator Panel.

08/25/09 19:09:40 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to wontfix.

closing this ticket, if this should be in, let's get it in the php version re #3291 that is being looked at.