Ticket #2989 (closed Patches: wontfix)

Opened 5 years ago

Last modified 4 years ago

Insufficient FOP button positions autogenerated for small layout rectangles

Reported by: Nick_Lewis Assigned to: p_lindheimer
Priority: minor Milestone: 2.6
Component: Core Version: SVN-HEAD
Keywords: Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

Revision [6180] introduced the auto generation of FOP button positions from the defined layout rectangles (see ticket #2699). There is a bug in this auto generation when the vertical height of a rectangle is less than three buttons.

Attachments

retrieve_op_conf_from_mysql.patch (7.8 kB) - added by Nick_Lewis on 08/04/08 04:03:43.

Change History

08/04/08 04:03:43 changed by Nick_Lewis

  • attachment retrieve_op_conf_from_mysql.patch added.

08/04/08 04:17:46 changed by Nick_Lewis

I have attached a patch that corrects the generation of style info from layout info in the styleinfo function of the retrieve_op_conf_from_mysql.pl file.

The patch also includes the changes to allow the layout to be under the control of the freepbx database:

(i) If a "panel" table exists in the freepbx database then layout info is taken from the database. This is primarily a hook for a forthcoming panel module but can be used now with phpMyAdmin

(ii) Legends can be customised without breaking the association between buttons and rectangles. This permits non-english legends to be specified in layout info

(iii) Some layout constants are made explicit

(iv) Color2 for conference rectange is improved

The panel database can be edited from phpMyAdmin or from a panel module that can be found at:

http://freepbx.org/trac/browser/contributed_modules/modules/panel

10/16/08 12:44:57 changed by Nick_Lewis

The previously attached patch has now had extensive and prolonged testing so may I please request that it is applied to the trunk

03/31/09 09:14:19 changed by Nick_Lewis

  • type changed from Bugs to Patches.
  • milestone changed from Cut Line to 2.6.

If implementation of the php rewrite of retrive_op_conf_from_mysql.pl is not imminent then lets have this bug fix of the perl code

08/25/09 21:40:41 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to wontfix.

closing and diverting any work on this to be considered in #3291 in php version.