Ticket #3072 (closed Feature Requests: fixed)

Opened 3 years ago

Last modified 3 years ago

Pop up a warning message when a probable in-operable trunk configuration is provided

Reported by: wiseoldowl Assigned to: p_lindheimer
Priority: major Milestone: 2.5
Component: Core - Trunks/Routing Version: 2.5-branch
Keywords: Cc:
Confirmation: Need testing SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

Please, when someone makes what appears to be an obvious mistake in trunk configuration (such as placing a disallow=all after any allow=) pop up a (dismissable) warning box. The user should have the option to "do it anyway", just in case they really do know what they are doing (too-strict error checking can cause other problems) but at least users should be warned when it appears they are making an obvious trunk configuration error, particularly since those familiar with older versions of FreePBX may not realize that FreePBX no longer reverse-sorts the trunk configuration, and also because there are so many bad examples of trunk configuration out on the 'net (and even in the FreePBX wiki).

Attachments

functions.inc.php-disallow.patch (4.9 kB) - added by p_lindheimer on 08/15/08 11:43:04.
patch to move disallow=all to top of any sip/iax section

Change History

08/15/08 05:29:28 changed by mbrevda

  • milestone changed from 2.5 to 3.0.

This can be taken even further by adding separate boxes for every option like in extensions, and even only allowing codecs that are installed. This will probably have to wait for the whole rebuilding of routing/trunks

08/15/08 09:50:17 changed by p_lindheimer

we may be able to do some sanity fixing (vs. checking) like we do with things like 'insecure' or 'notransfer' at generation time, will have to review.

08/15/08 11:41:55 changed by p_lindheimer

  • confirmation changed from Unreviewed to Need testing.
  • milestone changed from 3.0 to 2.5.

try the following patch to: /var/www/html/admin/modules/core/functions.inc.php which will move all disallow=all statement to the top. We may be able to re-classify this as a bug and get it into 2.5 and after testing consider it for 2.4. It's not quite what you are asking however it is probably the right solution for this. Patching coming next.

08/15/08 11:43:04 changed by p_lindheimer

  • attachment functions.inc.php-disallow.patch added.

patch to move disallow=all to top of any sip/iax section

08/16/08 03:09:45 changed by pnlarsson

After a code review of the patch, but not testing it, i think that this line will not work anymore: 

allow=alaw&gsm

08/16/08 03:18:59 changed by pnlarsson

And after looking at again, i wish i tested before saying anything, it should work

Sorry for the noise...

08/16/08 12:57:19 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [6406]) closes #3072, always moves disallow=all to the top of a sip/iax section, also removes record_in and record_out from sip, iax settings which are bogus