Ticket #3271 (closed Feature Requests: fixed)

Opened 2 years ago

Last modified 2 years ago

Add support for Business Edition (patches included)

Reported by: awells Assigned to: p_lindheimer
Priority: minor Milestone: 2.5
Component: Installation Version: 2.5-branch
Keywords: support Business Edition BE ABE Cc:
Confirmation: Need Feedback SVN Revision (if applicable):
Backend Engine: All Backend Engine Version: Business Edition C.2.1.2

Description

Hello, As my co-worked Stagg and I posted in the forum, we have been trying to get FreePBX working on Asterisk Business Edition. I have gotten it work this evening with just a few minor tweaks to the code to map the BE version numbers to OpenSource? asterisk version numbers, and a change to modules.conf so BE will actually run. Patches are attached. I have not tested every piece of functionality in FreePBX with the version mapping, but so far I see no issues.

The patch to functions.inc.php is slightly incorrect, as it maps all versions of BE to 1.4 - I believe A to be 1.0, B to be 1.2, and C to be 1.4 (actually I know C is 1.4) but I only have C available to test with. Would be trivial to map the others to their correct version numbers.

Attachments

functions.inc.php.ABE_support.diff (1.0 kB) - added by awells on 10/12/08 14:59:29.
Updated functions.inc.php patch for ABE support
modules.conf.ABE_support.diff (386 bytes) - added by awells on 10/12/08 14:59:51.
Updated modules.conf patch for ABE support
install_amp.ABE_support.diff (1.2 kB) - added by awells on 10/12/08 15:00:21.
patch for install_amp script to add support for ABE

Change History

10/11/08 22:12:53 changed by qwell

I was just talking to Philippe about this last week..

If you need anything, please let me know, and I'd be happy to help in any way I can.

After a cursory look, you are right that the version numbers are not mapped correctly. You can safely ignore ABE version A (as it's 1.0-based), B maps to 1.2, and C maps to 1.4.

The app_voicemail/app_directory change in modules.conf is correct. I'm not sure why func_strings would need to be preloaded (maybe res_phoneprov requires it?), and the chan_alsa change seems unrelated.

Adding support for res_phoneprov would be pretty interesting..

10/12/08 08:10:55 changed by p_lindheimer

  • confirmation changed from Unreviewed to Need Feedback.

can you modify the patch so that it rejects the 1.0 version (which we don't support) and properly maps B -> 1.2 and C -> 1.4. Also, can you make the related modification to install_amp which will otherwise not allow the installation. Then we would be glad to get this added in so that Business Edition can be supported. (As qwell mentions, we were just discussing this the other day as we would like to add this in).

10/12/08 13:35:41 changed by awells

Sure thing. I will work on that this evening and post updated patches.

10/12/08 14:58:52 changed by awells

Adding updated patches.

functions.inc.php: Added version checking for B vs C mapping to 1.2 vs 1.4. I didn't see anywhere where 1.0 was actively mapped and then rejected so I didn't add a mapping for A to 1.0 so it will die with the generic "UNABLE-TO-CONNECT" message.

modules.conf: you were correct about func_strings and chan_alsa not being required (I commented them out and ABE was able to start up) so I removed them from the patch.

install_amp: I added checking for ABE. The version_check() function doesn't like version numbers that start with letters, so I did a substr hack to find ABE version A and kick it out, while allowing B and C.

Let me know if you want/need any more changes.

- Aubrey

10/12/08 14:59:29 changed by awells

  • attachment functions.inc.php.ABE_support.diff added.

Updated functions.inc.php patch for ABE support

10/12/08 14:59:51 changed by awells

  • attachment modules.conf.ABE_support.diff added.

Updated modules.conf patch for ABE support

10/12/08 15:00:21 changed by awells

  • attachment install_amp.ABE_support.diff added.

patch for install_amp script to add support for ABE

10/18/08 10:12:02 changed by p_lindheimer

awells or qwell,

I would like to check these in - have they been tested? I'm not currently setup to test these and don't want to check in untested code. Thanks.

10/18/08 10:20:23 changed by p_lindheimer

r7002

detect ABE Business Edition, tested against 1.4 non-business and nothing is broken, need confirmation from testing on BE that it does as adverstised, install_amp change still needs testing before checking in

10/18/08 20:19:45 changed by awells

I haven't regression tested the install_amp changes against 1.2/1.4/1.6 but it does work for ABE.

I'll try and find time to test that tomorrow or early next week.

10/21/08 22:13:02 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [7064]) closes #3271 allow install_amp for business edition

10/21/08 23:26:13 changed by p_lindheimer

(In [7088]) Merged revisions 6976-7087 via svnmerge from http://svn.freepbx.org/freepbx/branches/2.5

........

r6982 | mickecarlsson | 2008-10-14 03:48:18 -0700 (Tue, 14 Oct 2008) | 1 line

New and modified versions of russian translation for modules from #3279

........

r6987 | mickecarlsson | 2008-10-15 08:41:38 -0700 (Wed, 15 Oct 2008) | 1 line

Add Hungarian as language choice in freepbx_admin.php

........

r7002 | p_lindheimer | 2008-10-18 10:18:15 -0700 (Sat, 18 Oct 2008) | 1 line

ref #3271 detect ABE Business Edition, tested against 1.4 non-business and nothing is broken, need confirmation from testing on BE that it does as adverstised, install_amp change still needs testing before checkin ing

........

r7003 | mickecarlsson | 2008-10-18 10:33:29 -0700 (Sat, 18 Oct 2008) | 1 line

Updated amp.pot and swedish language for amp

........

r7006 | p_lindheimer | 2008-10-18 11:10:33 -0700 (Sat, 18 Oct 2008) | 1 line

closes #3264 add languageprefix=yes and while we are at it, execincludes=yes

........

r7007 | mickecarlsson | 2008-10-18 14:05:26 -0700 (Sat, 18 Oct 2008) | 1 line

Swedish language for amp. All text is translated

........

r7009 | mickecarlsson | 2008-10-19 00:09:14 -0700 (Sun, 19 Oct 2008) | 1 line

Closes #3279, new russian translations for amp

........

r7052 | p_lindheimer | 2008-10-21 07:51:22 -0700 (Tue, 21 Oct 2008) | 1 line

closes #3309 have op_server.pl reload instead of killing and restarting

........

r7058 | p_lindheimer | 2008-10-21 11:11:41 -0700 (Tue, 21 Oct 2008) | 1 line

send raw asterisk version info if the parsed version is blank, and escape the & when sending to wget

........

r7059 | p_lindheimer | 2008-10-21 11:14:30 -0700 (Tue, 21 Oct 2008) | 1 line

revert r7058, should not have been checked in until we fix the css for the tabs

........

r7060 | p_lindheimer | 2008-10-21 11:32:25 -0700 (Tue, 21 Oct 2008) | 1 line

change default of MODULEADMINWGET to false, was set to true in amportal.conf

........

r7061 | sasargen | 2008-10-21 12:49:36 -0700 (Tue, 21 Oct 2008) | 1 line

fix text overflow in left nav tab menu

........

r7062 | p_lindheimer | 2008-10-21 13:16:55 -0700 (Tue, 21 Oct 2008) | 1 line

localize the Tool/Setup lnav tabs, they will be truncated if too wide so translators should review and consider abbreviating Tools and Setup which only appear in the tabs and not elsewhere

........

r7063 | p_lindheimer | 2008-10-21 22:10:22 -0700 (Tue, 21 Oct 2008) | 1 line

create 2.5.1 upgrade directory to bump version

........

r7064 | p_lindheimer | 2008-10-21 22:13:01 -0700 (Tue, 21 Oct 2008) | 1 line

closes #3271 allow install_amp for business edition

........

r7065 | p_lindheimer | 2008-10-21 22:16:00 -0700 (Tue, 21 Oct 2008) | 1 line

updated CHANGES for 2.5.1 release

........

r7066 | p_lindheimer | 2008-10-21 22:20:14 -0700 (Tue, 21 Oct 2008) | 1 line

fix spelling errors to keep mickecarlsson happy :-)

........

r7070 | p_lindheimer | 2008-10-21 22:36:53 -0700 (Tue, 21 Oct 2008) | 1 line

Creating release 2.5.1

........

10/23/08 07:57:27 changed by awells

It looks like the modules.conf patch was skipped. If noload => app_directory_odbcstorage.so and noload => app_voicemail_odbcstorage.so are not added to modules.conf, ABE will crash at startup.

10/23/08 13:53:09 changed by p_lindheimer

r7111