Ticket #3291 (closed Patches: fixed)

Opened 1 year ago

Last modified 2 months ago

Convert retrieve_op_conf_from_mysql.pl to php

Reported by: Nick_Lewis Assigned to: p_lindheimer
Priority: minor Milestone: 2.6
Component: Core Version: SVN-HEAD
Keywords: Cc:
Confirmation: Need Feedback SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

/var/lib/asterisk/bin/retrieve_op_conf_from_mysql.pl appears to be last surviving member of the retrieve*.pl group of perl scripts. It could be converted to php and left in the same directory. More radically it could become a functions.inc.php file in /var/www/html/admin/modules/panel if and when this contributed module is adopted

Attachments

retrieve_op_conf_from_mysql.php (22.5 kB) - added by Nick_Lewis on 10/27/08 09:32:08.
retrieve_op_conf_from_mysql.2.php (23.0 kB) - added by Nick_Lewis on 02/26/09 02:20:49.
generate_configurations_fop.patch (1.1 kB) - added by Nick_Lewis on 02/26/09 02:31:07.
retrieve_op_conf_from_mysql.3.php (23.5 kB) - added by Nick_Lewis on 08/26/09 05:37:04.
retrieve_op_conf_from_mysql.4.php (24.0 kB) - added by Nick_Lewis on 08/26/09 08:21:06.

Change History

10/27/08 09:32:08 changed by Nick_Lewis

  • attachment retrieve_op_conf_from_mysql.php added.

10/27/08 09:42:44 changed by Nick_Lewis

  • type changed from Proposed Change to Patches.

I have attached a php equivalent of the current perl program (inc fixes for #2972 and #2989. The file can be accessed in the same way as retrieve_op_conf_from_mysql.pl but with the dot extension changed to php.

The php version produces identical results to the perl version in my test environment and usage but I would be grateful if others tested it as well to get better test coverage

10/27/08 10:45:58 changed by p_lindheimer

  • confirmation changed from Unreviewed to Confirmed.

Nick,

that sounds great, hopefully some people can do some independent testing to check it against the '.pl' version. The next step would be to change it to:

generate_configurations_fop()

see the libfreepbx.confgen.php and how they are used in retrieve_conf. Most of the functions in that file are deprecated, but it would be the place to put it. The advantage is that they are simply included in retrieve_conf instead of spawned as a new process, and they also inherit the $db, $amp_conf, $version (asterisk version running) and anything else that is available in the retrieve_conf environment.

02/26/09 02:19:53 changed by Nick_Lewis

For retrieve_op_conf_from_mysql.php to be integrated into libfreepbx.confgen.php some minor adjustments are needed to avoid duplicate includes of admin/functions.inc and to avoid provincial declaration and us of extra globals. Please find slightly revised version attached

02/26/09 02:20:49 changed by Nick_Lewis

  • attachment retrieve_op_conf_from_mysql.2.php added.

02/26/09 02:31:07 changed by Nick_Lewis

  • attachment generate_configurations_fop.patch added.

02/26/09 02:39:13 changed by Nick_Lewis

Please find attached a patch that adds the function generate_configurations_fop() to libfreepbx.confgen.php and makes use of it in retrieve_conf

02/26/09 02:47:11 changed by Nick_Lewis

Philippe

As the code for fop generation is quite a bit bigger than other functions in libfreepbx.confgen.php I have for now included the code from retrieve_op_conf_from_mysql.php rather than pasting it directly in to libfreepbx.confgen.php

However please let me know if you would prefer a patch with the code directly in libfreepbx.confgen.php

02/26/09 03:49:51 changed by Nick_Lewis

Fortunately there was a bug in r7157 that left libfreepbx.confgen.php unconditionally included (as well as being conditionally included for core_conf and queues_conf). If this bug is fixed then libfreepbx.confgen.php will need to be conditionally included if FOPDISABLE is not set in amp conf

03/11/09 07:11:56 changed by Nick_Lewis

Nudge: "However please let me know if you would prefer a patch with the code directly in libfreepbx.confgen.php"

08/23/09 22:33:59 changed by p_lindheimer

ok - just going through everything to role things into 2.6. So without me running through the history, where do we stand on these?

libfreepbx.confgen.php is somewhat obsoleted since all those functions have been moved to core. I believe it is only in there for migration sakes and as they stand, they are probably out dated.

So .. however it makes the most sense to move to the php version if these are still all good...???

08/24/09 01:47:08 changed by Nick_Lewis

I think we are still good.

If libfreepbx.confgen.php is to be removed I guess that the code could be referenced by an include in retrieve_conf or core/functions.inc.php or pasted in directly

If there have been any changes to the format of the database tables since february then this will need checking with retrieve_op_conf_from_mysql.php to make sure it is not broken.

(I have not been following the discussions regarding "FOP does not work on 1.6" but assume this is down to incompatibility with the 1.6 asterisk manager rather than being retrieve_op_conf_from_mysql related.)

08/24/09 07:25:36 changed by p_lindheimer

there have not been any changes to retrieve_op_conf_from_mysql that I am aware of but it's easy enough to do an svn log on it.

drmessano was working on getting the new version of FOP into trunk for review (he may have done it yesterday) so that we could review and my plan is to merge to 2.6 if it looks good. He indicated it should be compatible with the current code though.

08/24/09 07:42:41 changed by Nick_Lewis

Good point - there has been nothing changed in retrieve_op_conf_from_mysql.pl for over a year so retrieve_op_conf_from_mysql.php should be fine. Unless you think otherwise I will leave it with you to reference or paste it in the best location

(My preferred solution would be to make an admin/modules/panel module directory and add retrieve_op_conf_from_mysql.php in there renamed as functions.inc.php - see the contributed_modules/modules/panel for other functionality that could live there too)

08/24/09 07:47:13 changed by p_lindheimer

I take it I can literally just replace it in retrieve_conf with yours? I also assume it is :

retrieve_op_conf_from_mysql.2.php

that I want? And what is the last file: generate_configurations_fop.patch

(sorry if it is above, just running through too many tickets to read everything :( )

thanks!

08/24/09 08:28:32 changed by Nick_Lewis

Yes retrieve_op_conf_from_mysql.2.php is the one to use (renamed to retrieve_op_conf_from_mysql.php). It is a drop-in replacement for its retrieve_op_conf_from_mysql.pl namesake.

The generate_configurations_fop.patch added a reference to retrieve_op_conf_from_mysql.php from libfreepbx.confgen.php but if you are going to reference retrieve_op_conf_from_mysql.php directly from retrieve_conf or elsewhere then the generate_configurations_fop patch is not applicable

08/25/09 17:06:47 changed by p_lindheimer

  • confirmation changed from Confirmed to Need Feedback.

Nick,

I installed the retrieve_op_conf_from_mysql.2.php and configured retrieve_conf to use that in place of the .pl version. I then did a diff on the generated cfg file and they were a little different. I visually compared them and there were some minor differences, nothing really substantial except one issue:

On the zap trunks, the .pl version shows me as having "Zap 3" as a trunk. The .php version shows me as having: "Zap \3" and "Zap \4" as trunks.

The reality is, I have the following in my zapata.conf file: 

context=from-zaptel
group=0                                                                                                                                     
signalling = fxs_ks
channel => 3
;context=from-zaptel
;group=0
;signalling = fxs_ks
;channel => 4
group=11

So it looks like there may be some minor differences, it appears to be parsing comment lines in zapata.conf in the php version if I understand the issue.

For now waiting on feedback and keeping the perl version in.

08/25/09 17:11:16 changed by p_lindheimer

closed #2972 if needed should be folded into the php version.

08/25/09 17:12:01 changed by p_lindheimer

#3236 should be reviewed to see if applicable for this version also.

08/25/09 18:40:01 changed by p_lindheimer

#2989 should be reviewed and if applicable rolled into the php version

08/26/09 01:07:07 changed by Nick_Lewis

Sorry for the differences between the perl and php versions. I think that the backslash is caused by an escaped % character in perl that does not need to be escaped in php. I suspect that I did not spot this because I was tesing with AMPLABELs instead of the default names. The mishandling of commented out contexts was probably an oversight.

I will fix these problems and review #2972, #3236, #2989 to check that they have been incorporated.

08/26/09 05:35:55 changed by Nick_Lewis

I think I have a fix for the backslash and comment problems.

I have also fixed a bad next-continue substitution problem (next means different things in perl and php).

I have checked that fixes for #2972 and #2989 are incorporated

I have enhanced the zapata parser so that it follows #include declarations

I have not had time to look at #3236

08/26/09 05:37:04 changed by Nick_Lewis

  • attachment retrieve_op_conf_from_mysql.3.php added.

08/26/09 08:14:42 changed by Nick_Lewis

Now fixed a problem with the new #include support so the path is correct from any directory

Repaired a problem with the operation of extension ranges for department ampusers

Fixed missing backgrounds for department ampusers #3236

08/26/09 08:21:06 changed by Nick_Lewis

  • attachment retrieve_op_conf_from_mysql.4.php added.

08/27/09 14:04:19 changed by p_lindheimer

I diffed the files generated from both, they are enough the same (there is an off by one in a bunch of the layouts but the FOP looks fine so ...)

However the diff turned up that your version does not have a bunch of these:

Panel_Context=default

Please check if that is an issue and if so, if it needs to be changed. I checking in the changes with your new version but will hold off publishing until hearing back from you (although the ticket will be closed, but feel free to comment). Thanks!

08/27/09 14:05:50 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [8218]) closes #3291 replace perl version with php version, leaving perl version code base for now though not called by retrieve_conf

08/27/09 22:23:22 changed by p_lindheimer

  • status changed from closed to reopened.
  • resolution deleted.

Nick, the following patch fixes trunks which got broke with 2.7 because I changed how trunks are represented: 

Index: retrieve_op_conf_from_mysql.php
===================================================================
--- retrieve_op_conf_from_mysql.php	(revision 8221)
+++ retrieve_op_conf_from_mysql.php	(working copy)
@@ -402,7 +402,7 @@
 $tables = array("sip","iax");
 foreach ($tables as $table) {
 	if (table_exists($db,$table)) {
-		$statement = "SELECT data,id,'$table' from $table where keyword='account' and flags <> 1 and id>99990 group by data order by id";
+		$statement = "SELECT data,id,'$table' from $table where keyword='account' and flags <> 1 and id LIKE 'tr-%' group by data order by id";
 		$results = $db->getAll($statement);
 		if(DB::IsError($results)) {
 		   die($results->getMessage());
@@ -563,7 +563,7 @@
 		$btn=get_next_btn($trunkpos,$btn);
 		if ($btn == 0) {last;}
 		if (table_exists($db,$table)) {
-		$statement = "SELECT keyword,data from $table where id=$id and keyword <> 'account' and flags <> 1 order by keyword";
+		$statement = "SELECT keyword,data from $table where id='$id' and keyword <> 'account' and flags <> 1 order by keyword";
 			$results = $db->getAll($statement);
 			if(DB::IsError($results)) {
 			   die($results->getMessage());

However, I am wondering since you are familiar with the code, do you think it would be easy to modify the way trunks are generated now that we have a proper trunks table? It may significantly simplify all the zap stuff and all. Have a look at the trunk table and see what you think?

08/27/09 22:30:37 changed by p_lindheimer

(In [8222]) fixes #3835 and re #3291 - we should redo how the trunks are searched now that we have the trunk table plus there is an option for a descriptive name that should be used if present

08/28/09 02:46:08 changed by Nick_Lewis

Philippe

Could you please give details of the out-by-one error so that I can check whether it is something serious. (Hopefully it is only because of the incorporation of the fix for #2989.)

Regarding simplifying the trunk stuff I think from my recollection that most of the complexity is due to zaps and other trunks sharing the same fop rectangle but being generated from different sources (i) zapata.conf file and (ii) <tech> database table(s). I am not familiar with the new trunks database table. Does it contain the zaps? I suspect that only if it does will it be possible to simplify the code.

08/28/09 02:55:56 changed by Nick_Lewis

Philippe

Sorry I missed your comment about missing Panel_Context=default. Does this only affect rectangles and legends or does it affect all buttons? Do you have any freepbx administrators defined with extension range and department name?

Nick

08/28/09 07:31:42 changed by p_lindheimer

Nick,

I just noticed it in a diff, a bunch of numbers (probably coordinates) were 'off by one'.

If you just run the perl version followed by your version and do a diff of the two files, you will see exactly what I am referring to. That is all I did.

Concerning the new trunks, the table schema is as follows so as you can see, I believe you can get everything out of it: 

  CREATE TABLE `trunks` 
  ( 
    `trunkid` INTEGER,
    `name` VARCHAR( 50 ) NOT NULL DEFAULT '', 
    `tech` VARCHAR( 20 ) NOT NULL , 
    `outcid` VARCHAR( 40 ) NOT NULL DEFAULT '', 
    `keepcid` VARCHAR( 4 ) DEFAULT 'off',
    `maxchans` VARCHAR( 6 ) DEFAULT '',
    `failscript` VARCHAR( 255 ) NOT NULL DEFAULT '', 
    `dialoutprefix` VARCHAR( 255 ) NOT NULL DEFAULT '', 
    `channelid` VARCHAR( 255 ) NOT NULL DEFAULT '', 
    `usercontext` VARCHAR( 255 ) NULL, 
    `provider` VARCHAR( 40 ) NULL, 
    `disabled` VARCHAR( 4 ) DEFAULT 'off',
  
    PRIMARY KEY  (`trunkid`, `tech`, `channelid`) 
  )

The only possible issue is whether or not to include the usercontext if one is included, which is only relevant to sip and iax trunks. That is simply the second context listed. You may need to lookup the context, I don't recall if the current version includes the usercontext when it is defined but effectively blank. An example of what the table data might look like is, so you can see the types of information which makes it much more straight forward. And there is the name field which allows the new descriptive name that you can use vs. the context name if one is available.

trunkidnametechoutcidkeepcidmaxchansfailscriptdialoutprefixchannelidusercontextproviderdisabled
1Zap Channel 5zap off 5notneeded off
10 enum off +1 off
11teliaxsip"My CID" <4252221234>off4 teliax off
12Local Loopbackcustom off Local/$OUTNUM$@from-trunknotneeded off
13PB Extensionsip9284542345off pb23543pb-in off
17privdundi off3 privnotneeded off
18DUNDi's priviax off privextloc off
22Zap g0zap off wg0notneeded off
3Prim voipjetiax"MYNAME" <3452349594>off3failtrunk.agi voipjet on
5My voxeeiax3425322342off2failtrunk.agi voxee on
7fpbx-1-philippesip3452346543off fpbx-1-234543 off

Note one thing, the disabled colum, on means that it is disable, as in the checkbox is checked (on). So trunks 2 and 3 are disabled in the above example. (This would be equivalent to the way the flag field is used to not put disabled trunks up in the current script, it's what determines whether to set that field or not.

08/29/09 10:34:44 changed by p_lindheimer

  • status changed from reopened to closed.
  • resolution set to fixed.

closing again, see #3837 to pickup discussion of moving to the trunks table.

01/13/10 12:59:04 changed by p_lindheimer

(In [8599]) Merged revisions 7910,7912-8166,8168-8338,8340-8371,8373-8405,8407-8598 via svnmerge from http://svn.freepbx.org/freepbx/branches/2.6

........

r7910 | p_lindheimer | 2009-08-02 18:36:37 -0700 (Sun, 02 Aug 2009) | 1 line

branch trunk to 2.6

........

r7978 | p_lindheimer | 2009-08-07 15:40:44 -0700 (Fri, 07 Aug 2009) | 1 line

update packed js library

........

r7981 | p_lindheimer | 2009-08-07 15:52:01 -0700 (Fri, 07 Aug 2009) | 1 line

Creating release 2.6.0beta1

........

r7992 | p_lindheimer | 2009-08-07 18:58:23 -0700 (Fri, 07 Aug 2009) | 1 line

added trunk migration code to table.php, seems to be needed

........

r8006 | p_lindheimer | 2009-08-07 20:11:49 -0700 (Fri, 07 Aug 2009) | 1 line

add sql() function definition if not there

........

r8019 | p_lindheimer | 2009-08-09 17:10:47 -0700 (Sun, 09 Aug 2009) | 1 line

forgot to change moduleauthor to modulepublisher in css, need to roll the tarball one more time :(

........

r8022 | p_lindheimer | 2009-08-09 21:13:58 -0700 (Sun, 09 Aug 2009) | 1 line

2.6 highlights added to CHANGES

........

r8025 | p_lindheimer | 2009-08-09 21:23:46 -0700 (Sun, 09 Aug 2009) | 1 line

Creating release 2.6.0beta1

........

r8043 | p_lindheimer | 2009-08-14 18:05:20 -0700 (Fri, 14 Aug 2009) | 1 line

adds sort param used by new printextensions

........

r8046 | p_lindheimer | 2009-08-15 11:43:14 -0700 (Sat, 15 Aug 2009) | 1 line

Creating release 2.6.0beta1

........

r8083 | p_lindheimer | 2009-08-18 14:44:13 -0700 (Tue, 18 Aug 2009) | 1 line

fixes #3075 dead code removal

........

r8088 | p_lindheimer | 2009-08-22 17:27:44 -0700 (Sat, 22 Aug 2009) | 1 line

closes #3675 increase text input field size in components.class.php

........

r8099 | p_lindheimer | 2009-08-23 14:54:27 -0700 (Sun, 23 Aug 2009) | 1 line

undefined varialbes re #3780

........

r8102 | p_lindheimer | 2009-08-23 16:10:55 -0700 (Sun, 23 Aug 2009) | 1 line

fixes #3382 make links relative and add audio/basic type to make work in safari

........

r8104 | p_lindheimer | 2009-08-23 16:41:10 -0700 (Sun, 23 Aug 2009) | 1 line

fixes #3559 adds ASTMANAGERHOST

........

r8105 | p_lindheimer | 2009-08-23 16:58:54 -0700 (Sun, 23 Aug 2009) | 1 line

fixes #3606 improved logout view

........

r8106 | p_lindheimer | 2009-08-23 17:14:36 -0700 (Sun, 23 Aug 2009) | 1 line

use TXTCIDNAME() as TXTCIDname has been deprecated since 1.2 re #3599

........

r8109 | p_lindheimer | 2009-08-23 18:13:27 -0700 (Sun, 23 Aug 2009) | 1 line

fixes #3642 hardcoded paths

........

r8110 | p_lindheimer | 2009-08-23 18:51:20 -0700 (Sun, 23 Aug 2009) | 1 line

needs parse_amprotal because of change re #3642

........

r8113 | p_lindheimer | 2009-08-23 21:22:44 -0700 (Sun, 23 Aug 2009) | 1 line

closes #3608 use htmlspecialchars to remove some html errors

........

r8114 | p_lindheimer | 2009-08-23 21:54:04 -0700 (Sun, 23 Aug 2009) | 1 line

weakpassword validation re #3581 and re #3266

........

r8117 | p_lindheimer | 2009-08-24 12:01:39 -0700 (Mon, 24 Aug 2009) | 1 line

add USEQUEUESTATE flag to use 'HINT:' format re #3562 but related to the Asterisk patch: https://issues.asterisk.org/view.php?id=15168

........

r8118 | p_lindheimer | 2009-08-24 12:19:58 -0700 (Mon, 24 Aug 2009) | 1 line

add USEQUEUESTATE flag to amportal.confto use 'HINT:' format re #3562 but related to the Asterisk patch: https://issues.asterisk.org/view.php?id=15168

........

r8162 | p_lindheimer | 2009-08-25 12:38:39 -0700 (Tue, 25 Aug 2009) | 1 line

add include of main functions.inc.php removing several duplicated functions

........

r8169 | p_lindheimer | 2009-08-25 18:53:37 -0700 (Tue, 25 Aug 2009) | 1 line

fixes #3621 better matching of call recordings with users that occured at the same time

........

r8170 | p_lindheimer | 2009-08-25 19:03:54 -0700 (Tue, 25 Aug 2009) | 1 line

fixes #3639 allows pidof to be defined and removes hard coded /etc/asterisk path

........

r8171 | p_lindheimer | 2009-08-25 19:20:17 -0700 (Tue, 25 Aug 2009) | 1 line

closes #3305 adds reload command to freepbx_engine using kill -HUP to reload asterisk and fop

........

r8195 | p_lindheimer | 2009-08-26 10:35:26 -0700 (Wed, 26 Aug 2009) | 1 line

create 2.6.0beta2 dir in upgrades to reflect upcoming version

........

r8198 | p_lindheimer | 2009-08-26 10:50:14 -0700 (Wed, 26 Aug 2009) | 1 line

Creating release 2.6.0beta2

........

r8217 | p_lindheimer | 2009-08-27 13:50:33 -0700 (Thu, 27 Aug 2009) | 1 line

closes #2880 fix lower timeouts in phpagi-asmanager that gets called from agi scripts, does not effect the copy called by the GUI code

........

r8218 | p_lindheimer | 2009-08-27 14:05:49 -0700 (Thu, 27 Aug 2009) | 1 line

closes #3291 replace perl version with php version, leaving perl version code base for now though not called by retrieve_conf

........

r8222 | p_lindheimer | 2009-08-27 22:30:36 -0700 (Thu, 27 Aug 2009) | 1 line

fixes #3835 and re #3291 - we should redo how the trunks are searched now that we have the trunk table plus there is an option for a descriptive name that should be used if present

........

r8234 | mickecarlsson | 2009-08-28 13:12:11 -0700 (Fri, 28 Aug 2009) | 1 line

Localization updates for core

........

r8235 | mickecarlsson | 2009-08-28 13:17:48 -0700 (Fri, 28 Aug 2009) | 1 line

Small fix for Swedish language in core

........

r8236 | mickecarlsson | 2009-08-28 13:21:28 -0700 (Fri, 28 Aug 2009) | 1 line

Yet another small fix for Swedish language in core

........

r8242 | p_lindheimer | 2009-08-29 12:29:48 -0700 (Sat, 29 Aug 2009) | 1 line

fixes #3840 replace last with break left over from perl port

........

r8255 | p_lindheimer | 2009-08-31 11:12:45 -0700 (Mon, 31 Aug 2009) | 1 line

remove pass by reference indicator in parse_zapata it is already declared in the function and creates error on php 5.3+

........

r8270 | p_lindheimer | 2009-09-02 09:43:41 -0700 (Wed, 02 Sep 2009) | 1 line

fixes #3850 adds dahdi (though some real dahdi testing is necessary, tried to get labels right), also moves retrieve_op_conf_from_mysql.php to an include file no longer stand-alone executable re #3837

........

r8273 | p_lindheimer | 2009-09-04 17:44:43 -0700 (Fri, 04 Sep 2009) | 1 line

fixes #3858 reload deprecated starting 1.4 changed to module_reload

........

r8274 | p_lindheimer | 2009-09-05 08:25:52 -0700 (Sat, 05 Sep 2009) | 1 line

fixes #3861 previous patch had wrong path to default asterisk.conf

........

r8280 | p_lindheimer | 2009-09-05 17:35:56 -0700 (Sat, 05 Sep 2009) | 1 line

fixes #3678 parse voicemail includes even when they have single/double quotes

........

r8287 | p_lindheimer | 2009-09-05 18:25:06 -0700 (Sat, 05 Sep 2009) | 1 line

bump to RC1

........

r8289 | p_lindheimer | 2009-09-05 18:32:59 -0700 (Sat, 05 Sep 2009) | 1 line

Creating release 2.6.0RC1

........

r8303 | p_lindheimer | 2009-09-05 19:14:55 -0700 (Sat, 05 Sep 2009) | 1 line

update to 2.5.2

........

r8352 | p_lindheimer | 2009-09-09 14:00:11 -0700 (Wed, 09 Sep 2009) | 1 line

fix sort order of old trunk dialrules in conversion re #3854

........

r8356 | p_lindheimer | 2009-09-09 15:00:32 -0700 (Wed, 09 Sep 2009) | 1 line

make more generic email address example re #3877

........

r8371 | p_lindheimer | 2009-09-09 16:39:13 -0700 (Wed, 09 Sep 2009) | 1 line

closes #3870 add astdb information to FOP

........

r8376 | p_lindheimer | 2009-09-09 16:59:01 -0700 (Wed, 09 Sep 2009) | 1 line

Creating release 2.6.0RC2

........

r8388 | mickecarlsson | 2009-09-10 10:28:06 -0700 (Thu, 10 Sep 2009) | 1 line

Closes #3885 move macro-dumpvars out from extensions.conf to extensions_custom.conf.sample and update the deprecated variables

........

r8401 | lazytt | 2009-10-08 11:16:00 -0700 (Thu, 08 Oct 2009) | 1 line

bring the trash in to the 21st centry

........

r8405 | p_lindheimer | 2009-10-11 20:51:32 -0700 (Sun, 11 Oct 2009) | 1 line

fixes #3903 rename goto to goto_dest, scanned freepbx code, not used in any agi scripts so should be safe

........

r8407 | p_lindheimer | 2009-10-11 21:03:23 -0700 (Sun, 11 Oct 2009) | 1 line

regenerate js library

........

r8408 | p_lindheimer | 2009-10-11 21:06:02 -0700 (Sun, 11 Oct 2009) | 1 line

create 2.6.0 dir to force final release

........

r8410 | lazytt | 2009-10-13 00:57:39 -0700 (Tue, 13 Oct 2009) | 1 line

closes #3925, #3904; adds fax extensions in extensions.class.php, fixes splice funtion

........

r8416 | p_lindheimer | 2009-10-21 13:35:34 -0700 (Wed, 21 Oct 2009) | 1 line

file upload to stringent (e.g. doesn't like RC1 in version number because it was not allowing caps

........

r8421 | mickecarlsson | 2009-11-07 01:27:29 -0800 (Sat, 07 Nov 2009) | 1 line

Closes #3943 removed obsolete links in INSTALL file

........

r8428 | mickecarlsson | 2009-11-29 02:43:22 -0800 (Sun, 29 Nov 2009) | 1 line

Fixed some spelling errors in install_amp

........

r8430 | mickecarlsson | 2009-12-01 11:08:55 -0800 (Tue, 01 Dec 2009) | 1 line

Adds utf-8 support line (currently disabled) to vm_email.inc so that voicemail email can be localized

........

r8431 | mickecarlsson | 2009-12-01 11:51:07 -0800 (Tue, 01 Dec 2009) | 1 line

Closes #3963 adds preload of pbx_config and chan_local to modules.conf

........

r8432 | lazytt | 2009-12-10 04:25:01 -0800 (Thu, 10 Dec 2009) | 19 lines

Extended functionality of amportal sbin app with an 'admin' option, which allowes running of more admin/dev options. Also added fpbx application which can be called in place of amportal. Additional aoptions are as followes:

reload|r: does a full dialplan regeneration/reload (like clicking the orange bar) context|cxt: show's the specified context from the dialplan. This is extreamly usefull when

when developing dialplan on a system with many modules, where it is not fesable look thru the whole extensions_additional every time to see how a specific context was generate

  • when run with the 'list' or 'l' option, will list all avalible context's as they appear in extensions* files
  • when run with the 'contains' or 'con' options, will only print the dialplan WITHIN the context, eliminating the contexts header and trailing ;

modadmin|ma: runs the module_admin script with additional argument as passed

additioanly, the shortcut a can replace admin. For example:

'amportal admin reload' is the same as 'amportal a reload' 'amportal admin context list' is the same as 'amportal a ctx l' or 'fpbx a ctx l'

........

r8433 | lazytt | 2009-12-10 04:35:25 -0800 (Thu, 10 Dec 2009) | 1 line

allow /sbin/fpbx to be executable, re: r8432

........

r8434 | mickecarlsson | 2009-12-10 11:44:43 -0800 (Thu, 10 Dec 2009) | 1 line

Closes #3971, updated Russian language file for amp

........

r8436 | mickecarlsson | 2009-12-10 11:55:59 -0800 (Thu, 10 Dec 2009) | 1 line

Re #3971, added missing license text

........

r8439 | lazytt | 2009-12-13 06:08:31 -0800 (Sun, 13 Dec 2009) | 1 line

update amportal.conf to reflect r8438

........

r8442 | lazytt | 2009-12-14 09:08:53 -0800 (Mon, 14 Dec 2009) | 1 line

further amportal/fpbx admin features: externalip or extip returns the external ip address of the default gateway

........

r8444 | mickecarlsson | 2009-12-16 07:27:11 -0800 (Wed, 16 Dec 2009) | 1 line

Re #3977 fixes spelling error in code

........

r8459 | mickecarlsson | 2010-01-01 05:27:17 -0800 (Fri, 01 Jan 2010) | 1 line

Closes #3900 dbDel is deprecated, replaced with DB_DELETE

........

r8464 | mickecarlsson | 2010-01-02 14:19:06 -0800 (Sat, 02 Jan 2010) | 1 line

Closes #3987 fixes delimeter for Asterisk 1.6 and NVFax

........

r8466 | lazytt | 2010-01-04 14:21:06 -0800 (Mon, 04 Jan 2010) | 1 line

re: #3900; DB_DELETE is a function not an application, wrap it in a Noop to execute it

........

r8478 | p_lindheimer | 2010-01-04 16:12:02 -0800 (Mon, 04 Jan 2010) | 1 line

Creating release 2.6.0

........

r8578 | mickecarlsson | 2010-01-10 13:26:37 -0800 (Sun, 10 Jan 2010) | 1 line

Re #3805 initial checkin of new extension class Progress

........