Ticket #3368 (closed Patches: fixed)

Opened 2 years ago

Last modified 2 years ago

html, css and javascript errors

Reported by: Nick_Lewis Assigned to:
Priority: minor Milestone: 2.6
Component: System Dashboard Version: 2.5-branch
Keywords: Cc:
Confirmation: Confirmed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

On opening a new install of Freepbx 2.5.1 at /admin/config.php I was pleased by the dashboard but disappointed by the errors emanating from my browser which has html, css and javascript debuggers.

The errors were: entities missing semicolons unescaped ampersands unknown br close tags illegal content in h4 element missing type attribute on script tags illegal less-than slash combination in script element missing unit on css value invalid css value recommend accessibility summary on table recommend disable short tags sgml option

Attachments

dashboard.css.patch (227 bytes) - added by Nick_Lewis on 11/04/08 04:22:55.
freepbx.php.patch (3.7 kB) - added by Nick_Lewis on 11/04/08 04:23:07.
freepbx_admin.php.patch (0.9 kB) - added by Nick_Lewis on 11/04/08 04:23:18.
freepbx_reload.php.patch (3.4 kB) - added by Nick_Lewis on 11/04/08 04:23:30.
functions.inc.php.patch (1.8 kB) - added by Nick_Lewis on 11/04/08 04:23:40.
mainstyle.css.patch (299 bytes) - added by Nick_Lewis on 11/04/08 04:23:53.
page.index.php.patch (2.3 kB) - added by Nick_Lewis on 11/04/08 04:24:03.

Change History

11/04/08 04:22:55 changed by Nick_Lewis

  • attachment dashboard.css.patch added.

11/04/08 04:23:07 changed by Nick_Lewis

  • attachment freepbx.php.patch added.

11/04/08 04:23:18 changed by Nick_Lewis

  • attachment freepbx_admin.php.patch added.

11/04/08 04:23:30 changed by Nick_Lewis

  • attachment freepbx_reload.php.patch added.

11/04/08 04:23:40 changed by Nick_Lewis

  • attachment functions.inc.php.patch added.

11/04/08 04:23:53 changed by Nick_Lewis

  • attachment mainstyle.css.patch added.

11/04/08 04:24:03 changed by Nick_Lewis

  • attachment page.index.php.patch added.

11/04/08 05:09:03 changed by Nick_Lewis

I have attached patches to remove the html/css/js errors when viewing the dashboard

The patches do make changes outside the dashboard module but do not resolve the validation errors on other pages

11/04/08 11:11:28 changed by sasargen

  • confirmation changed from Unreviewed to Confirmed.

Thanks for these patches; they look good to me. FreePBX needs a lot of help to produce well-formed HTML. The way single quotes are used sometimes and double quotes are used other times on the same line in freepbx_reload.php.patch is a little confusing, but it does stop the validator from complaining.

11/04/08 11:59:44 changed by mickecarlsson

  • status changed from new to closed.
  • resolution set to fixed.

(In [7222]) Closes #3368 fixes various errors in css, html and javascript

11/05/08 08:32:02 changed by mickecarlsson

(In [7225]) Merged revisions 7222 via svnmerge from http://svn.freepbx.org/modules/branches/2.6

........

r7222 | mickecarlsson | 2008-11-04 20:59:44 +0100 (Tue, 04 Nov 2008) | 1 line

Closes #3368 fixes various errors in css, html and javascript

........

01/06/09 14:59:27 changed by p_lindheimer

(In [7346]) Merged revisions 7088-7102,7104-7345 via svnmerge from http://svn.freepbx.org/freepbx/branches/2.5

........

r7111 | p_lindheimer | 2008-10-23 13:52:50 -0700 (Thu, 23 Oct 2008) | 1 line

#3271 add some noloads that ABE is not happy with apparently (sounds liek an ABE bug that should be addressed)

........

r7125 | mickecarlsson | 2008-10-24 10:51:15 -0700 (Fri, 24 Oct 2008) | 1 line

Updated amp.pot and swedish language files

........

r7139 | p_lindheimer | 2008-10-25 11:38:33 -0700 (Sat, 25 Oct 2008) | 1 line

typo in variable name resulting in error report missing problem module name, re #3324 but not causing that issue

........

r7140 | sasargen | 2008-10-25 13:33:46 -0700 (Sat, 25 Oct 2008) | 1 line

ARI: add tooltips to Call Me Number and Call Screening labels

........

r7141 | p_lindheimer | 2008-10-25 18:32:38 -0700 (Sat, 25 Oct 2008) | 1 line

closes #3327 user will be required to edit the vm_general.inc if running 1.6 and desires this enabled

........

r7142 | mickecarlsson | 2008-10-26 01:13:13 -0700 (Sun, 26 Oct 2008) | 1 line

Fixed spelling errir and tidy up tabs formatting in vm_general.inc

........

r7157 | p_lindheimer | 2008-10-27 10:53:03 -0700 (Mon, 27 Oct 2008) | 1 line

don't include libfreepbx.confgen.php unless needed, since the functions are deprecated and no longer used except during upgrade transitions

........

r7208 | mickecarlsson | 2008-11-02 09:01:56 -0800 (Sun, 02 Nov 2008) | 1 line

Enabled Bulgarian language in language selector, added Bulgarian language to amp

........

r7210 | mickecarlsson | 2008-11-02 09:13:28 -0800 (Sun, 02 Nov 2008) | 1 line

Sorted the languages in alfabetic order, english on top

........

r7221 | mickecarlsson | 2008-11-04 10:59:28 -0800 (Tue, 04 Nov 2008) | 1 line

Updated readme for i18n

........

r7222 | mickecarlsson | 2008-11-04 11:59:44 -0800 (Tue, 04 Nov 2008) | 1 line

Closes #3368 fixes various errors in css, html and javascript

........

r7223 | mickecarlsson | 2008-11-05 06:57:54 -0800 (Wed, 05 Nov 2008) | 1 line

Updated pot file and swedish language for amp

........

r7226 | mickecarlsson | 2008-11-05 08:36:03 -0800 (Wed, 05 Nov 2008) | 1 line

Added a tool to autocreate all .pot files for amp and all modules

........

r7231 | mickecarlsson | 2008-11-05 09:38:27 -0800 (Wed, 05 Nov 2008) | 1 line

Add Bulgarian language to core from ticket #3373

........

r7233 | mickecarlsson | 2008-11-06 10:44:52 -0800 (Thu, 06 Nov 2008) | 1 line

Closes #3379 updates French language for core

........

r7234 | mickecarlsson | 2008-11-06 11:09:22 -0800 (Thu, 06 Nov 2008) | 1 line

Correction in bulgarian language files for core

........

r7235 | mickecarlsson | 2008-11-06 13:33:34 -0800 (Thu, 06 Nov 2008) | 1 line

Fixes VmX module, settings were revered against extension settings for VmX

........

r7236 | mickecarlsson | 2008-11-06 22:24:36 -0800 (Thu, 06 Nov 2008) | 1 line

Really fixes the amp.po for swedish language

........

r7237 | mickecarlsson | 2008-11-06 22:28:53 -0800 (Thu, 06 Nov 2008) | 1 line

Removed freepbx.pot, file is obsolete, .pot file is now in i18n instead

........

r7239 | mickecarlsson | 2008-11-08 10:15:24 -0800 (Sat, 08 Nov 2008) | 1 line

Addresses #3381 updates Italian language for core and ari

........

r7241 | mickecarlsson | 2008-11-08 10:21:35 -0800 (Sat, 08 Nov 2008) | 1 line

Addresses #3380 enclosed test string for translation

........

r7247 | mickecarlsson | 2008-11-10 09:42:01 -0800 (Mon, 10 Nov 2008) | 1 line

Closes #3358 updates Italian language for core. Thank you francesco_r

........

r7259 | mickecarlsson | 2008-11-12 12:43:54 -0800 (Wed, 12 Nov 2008) | 1 line

Closes #3389 updating Bulgarian language files

........

r7261 | mickecarlsson | 2008-11-12 13:41:50 -0800 (Wed, 12 Nov 2008) | 1 line

Closes #3380 fixes various string enclosures for localization. Thank you chocho

........

r7262 | mickecarlsson | 2008-11-12 23:02:52 -0800 (Wed, 12 Nov 2008) | 1 line

Merged 2.5 amp.pot with 2.6 amp.pot so that there is only one with all text strings from both versions

........

r7303 | mickecarlsson | 2008-11-23 06:32:05 -0800 (Sun, 23 Nov 2008) | 1 line

Updated amp.pot and swedish language files for core

........

r7309 | mickecarlsson | 2008-12-06 06:05:37 -0800 (Sat, 06 Dec 2008) | 1 line

Updates #3224 removes hard coded cdr database

........

r7312 | mickecarlsson | 2008-12-07 04:00:20 -0800 (Sun, 07 Dec 2008) | 1 line

Added ari.pot for localization of ARI

........

r7336 | mickecarlsson | 2008-12-26 00:36:36 -0800 (Fri, 26 Dec 2008) | 1 line

Closes #3453 adds Chinese language to core. Thank you edwardbadboy

........

r7337 | mickecarlsson | 2008-12-26 02:30:43 -0800 (Fri, 26 Dec 2008) | 1 line

Remove Chinese language in #3453 from core as it was not a proper FreePBX translation

........

r7341 | mickecarlsson | 2009-01-06 11:36:02 -0800 (Tue, 06 Jan 2009) | 1 line

Closes #3462, put double quote in javascript so that languages with single quote in text does not interfere with code

........