Ticket #3449 (closed Bugs: fixed)

Opened 3 years ago

Last modified 3 years ago

URL of Panel in admin/views/panel.php incorrect

Reported by: tristangrimaux Assigned to:
Priority: minor Milestone: 2.6
Component: FreePBX Framework Version: 2.5-branch
Keywords: Cc:
Confirmation: Confirmed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description (Last modified by p_lindheimer)

In line 7 of admin/views/panel.php the url property of iframe is "../../panel/index_amp.php?context='.$deptname.'" and it whould be "../panel/index_amp.php?context='.$deptname.'".

The bug is not visible if you install freepbx in a root folder, and with the correction it works good on both installations.

Change History

(follow-up: ↓ 3 ) 12/22/08 02:59:39 changed by mickecarlsson

Please report back the version of FreePBX you are using. 2.3, 2.4 or 2.5.

(follow-up: ↓ 4 ) 12/28/08 02:52:20 changed by naftali5

i am using 2.5 installed to /var/www/html/admin

works both ways

the extra ../ is likely to get out of the views folder, but the page is loaded at /var/www/html/admin/ so only one ../ is needed to get to /var/www/html/panel/

(in reply to: ↑ 1 ) 01/08/09 13:48:42 changed by tristangrimaux

Replying to mickecarlsson:

Please report back the version of FreePBX you are using. 2.3, 2.4 or 2.5.

version 2.5.1!

(in reply to: ↑ 2 ) 01/08/09 13:52:14 changed by tristangrimaux

Replying to naftali5:

i am using 2.5 installed to /var/www/html/admin works both ways the extra ../ is likely to get out of the views folder, but the page is loaded at /var/www/html/admin/ so only one ../ is needed to get to /var/www/html/panel/

Exactly. The double ../ makes sense in the folder it's standing, /var/www/html/admin/views but it's used by files in /var/www/html/admin.

05/02/09 12:34:44 changed by p_lindheimer

  • owner deleted.
  • confirmation changed from Unreviewed to Confirmed.
  • component changed from - choose - to FreePBX Framework.
  • description changed.

I suspect it works fine since the extra '..' parent directory will have no effect once you get to the virtual root. However, the comments are correct that the path should be relative to the admin and not admin/views directory which could cause problems on more non-standard installations.

05/02/09 12:35:41 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [7614]) fixes #3449 path is relative to admin and not admin/views directory

05/06/09 13:34:40 changed by p_lindheimer

(In [7646]) Merged revisions 7352-7407,7409-7460,7462-7481,7483-7519,7521,7524-7529,7531-7543,7545-7551,7553-7590,7596,7598-7637,7639,7641-7645 via svnmerge from http://svn.freepbx.org/freepbx/branches/2.5

........

r7410 | mickecarlsson | 2009-01-07 10:02:26 -0800 (Wed, 07 Jan 2009) | 1 line

re #3463, updated the amp.pot file and Swedish language

........

r7420 | mickecarlsson | 2009-01-27 10:01:03 -0800 (Tue, 27 Jan 2009) | 1 line

Closes #3484 updated spanish language for core (and modules)

........

r7423 | mickecarlsson | 2009-01-27 10:24:35 -0800 (Tue, 27 Jan 2009) | 1 line

Closes #3438 updated amp.po file for french language

........

r7441 | mickecarlsson | 2009-02-01 10:46:43 -0800 (Sun, 01 Feb 2009) | 1 line

Closes #3503 adds chinese language to core

........

r7460 | mickecarlsson | 2009-02-16 12:35:51 -0800 (Mon, 16 Feb 2009) | 1 line

Closes #3539 updates Bulgarian language to core and ari. Thank you chocho

........

r7551 | mickecarlsson | 2009-03-26 04:36:44 -0700 (Thu, 26 Mar 2009) | 1 line

Closes #3596, adds Danish language to Ari. Thank you danielz

........

r7572 | mickecarlsson | 2009-04-06 11:20:22 -0700 (Mon, 06 Apr 2009) | 1 line

Closes #3616 adds Portuguese (Brasil) language to amp. Thank you Flavio E. Goncalves. Please feel free to do the Brazilian translations fro FreePBX

........

r7614 | p_lindheimer | 2009-05-02 10:35:40 -0700 (Sat, 02 May 2009) | 1 line

fixes #3449 path is relative to admin and not admin/views directory

........

r7616 | p_lindheimer | 2009-05-02 10:44:53 -0700 (Sat, 02 May 2009) | 1 line

closes #3556

........

r7625 | p_lindheimer | 2009-05-02 11:58:49 -0700 (Sat, 02 May 2009) | 1 line

fixes 641 hardcoded path

........

r7628 | p_lindheimer | 2009-05-02 13:19:12 -0700 (Sat, 02 May 2009) | 1 line

fixes #3513 check/report db error

........

r7629 | p_lindheimer | 2009-05-02 13:29:44 -0700 (Sat, 02 May 2009) | 1 line

fixes #3525 HTML errors

........

r7645 | p_lindheimer | 2009-05-06 09:36:46 -0700 (Wed, 06 May 2009) | 1 line

fixes #3658 module_admin PHP error when online repository not available

........