Ticket #3507 (new Patches)

Opened 4 years ago

Last modified 4 years ago

Add Native Intercom for Grandstream

Reported by: francesco_r Assigned to: p_lindheimer
Priority: minor Milestone: Undetermined
Component: Core - Users/Devices Version: 2.5-branch
Keywords: Cc:
Confirmation: Unreviewed Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable):

Description

Adding these two lines in the top of macro-exten-vm you can use the native Grandstream Intercom (or Paging as Grandstream say...i don't know why, but they call intercom -> paging, and paging -> intercom)

[macro-exten-vm]
exten => s,1,Set(NATIVEPAGING=${SIP_HEADER(Call-Info)})
exten => s,n,GotoIf($["${NATIVEPAGING}"="<http://127.0.0.1>\;answer-after=0"]?ext-intercom,${INTERCOMCODE}${ARG2},1)
exten => s,n,Macro(user-callerid)
...

Change History

02/03/09 12:12:45 changed by mbrevda

How does this work differently that the current method?

02/03/09 16:56:33 changed by francesco_r

You can intercom an extension simply pressing menu(ok) button + extensions number. And if you have setup the BLF keys, you can intercom the extension pressing only two keys: menu(ok) + blf key.

02/04/09 01:17:57 changed by mbrevda

Hmm, it seems that the patch is a hack to enable the described method to work on phones other than grandstream (as the grandstream's themselves should not need any additional modifying as they respond to the nativepaging header??)

It would probably be more modular to lobby grandstream to make the sip header/called number configurable (i.e. I have 4+ext set to autoanswer. If you can set that menu + exten should dial 4+ exten, you can accomplish the same idea without burdening FreePBX to support every silly phone manufacturer out there)

02/04/09 05:04:22 changed by francesco_r

What? Sorry but i don't understand the first sentence mbrevda. My english is not so good.
This little patch is only for Grandstream Intercom and don't broke anything existing compatibility. I have enabled this in many setup where there are many type of SIP phones like Snom, Thomson and Siemens and they works transparently. If one press the PAGE (Intercom) button and dial a number, the Grandstream phone send a sip header

<http://127.0.0.1>;answer-after=0

so the patch control if is present and eventually send to intercom extension.
Perhaps is best to rename NATIVEPAGING to NATIVEINTERCOM.

02/04/09 13:01:48 changed by mbrevda

I'm missing something: what are you trying to page that you cant page today?

02/04/09 13:26:05 changed by francesco_r

02/04/09 16:45:06 changed by p_lindheimer

  • component changed from - choose - to Core - Users/Devices.

If I understand the request properly, you are asking to put special case code in the dialplan to enable how GS implements intercom-ing which is unique to them. If that understanding is correct, then I do not agree we should do that. If we start to accommodate every special case mode of how different manufactures implement various features in a form you suggest here, the code will become quite un-manageable. Other manufactures (Aastra as an example) can be easily deployed to do the same sort of 'two touch' intercom-ing with the existing dialplan by prepending an intercom header.

So unless I have mis-understood, I would suggest pressuring Grandstream to provide similar capabilities in their phone.

p.s. for your own implementation, you may want to simplify it down to a single line:

exten => s,1,GotoIf($["${SIP_HEADER(Call-Info)}"="<http://127.0.0.1>\;answer-after=0"]?ext-intercom,${INTERCOMCODE}${ARG2},1)

02/04/09 17:08:51 changed by francesco_r

You perfectly understand my request. I have "spammed" Grandstream with many features request like custom or server-side call forward, dnd, intercom etc. but is like to talk to the hand...

02/04/09 23:19:57 changed by p_lindheimer

You may want to consider other manufacturers like SNOM, Aastra, etc. then - who are a lot better at listening, have a relationship with the FreePBX team, and have equipment that is of excellent quality...

02/05/09 04:11:56 changed by francesco_r

Yes i know, i already use Aastra and especially Snom. The latest for me are the best SIP phones. But in some setup, the Grandstream are preferred for valuable reasons.

08/24/09 01:25:01 changed by p_lindheimer

  • milestone changed from 2.6 to 2.7.