Ticket #3517 (closed Bugs: fixed)

Opened 2 years ago

Last modified 1 year ago

Bug in dialparties.agi when called number is 0

Reported by: Muerte Assigned to:
Priority: minor Milestone: 2.6
Component: FreePBX Framework Version: 2.5-branch
Keywords: Cc:
Confirmation: Unreviewed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

Starting at line 119: 

$nodest	= get_var( $AGI, "NODEST" );
if (empty($nodest)) {
	$nodest	= '';
}

if $nodest gets the string '0', empty interprets that as true and clears out nodest. If 0 was a ring group or other items that sets the voicemail block flag, this causes transfers to fail to go to voicemail. I was able to at least patch it to work correctly by changing line 120 to read: 

if (empty($nodest) && $nodest !== '0') {

That prevents it from being cleared and then the checks of 

$nodest != ''

don't fail.

Change History

05/02/09 12:21:15 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [7626]) fixes #3517 no need to test nodest variable, it will be set and empty if not set in the channel

05/06/09 12:15:58 changed by p_lindheimer

(In [7647]) Merged revisions 7525-7553,7555-7612,7614-7646 via svnmerge from http://svn.freepbx.org/modules/branches/2.5

........

r7543 | mickecarlsson | 2009-03-21 05:37:55 -0700 (Sat, 21 Mar 2009) | 1 line

Fixes #3591 logic should be AND instead of OR

........

r7571 | mickecarlsson | 2009-04-06 11:18:35 -0700 (Mon, 06 Apr 2009) | 1 line

Re #3616, adds Portuguese (Brasil) to varous modules

........

r7612 | p_lindheimer | 2009-05-02 09:52:03 -0700 (Sat, 02 May 2009) | 1 line

fixes #3653 Skip Busy Agent ignored in some Follow-Me configurations under a queue

........

r7624 | p_lindheimer | 2009-05-02 11:40:34 -0700 (Sat, 02 May 2009) | 1 line

fixes #3457 don't use _. since Asterisk 1.2 will take that over more explicit matches like _s-.

........

r7626 | p_lindheimer | 2009-05-02 12:21:14 -0700 (Sat, 02 May 2009) | 1 line

fixes #3517 no need to test nodest variable, it will be set and empty if not set in the channel

........

r7627 | p_lindheimer | 2009-05-02 13:15:16 -0700 (Sat, 02 May 2009) | 1 line

fixes #3618 generate announce-position in queues.conf for Asterisk 1.6 (yes or no only for now)

........

r7644 | mickecarlsson | 2009-05-05 13:54:37 -0700 (Tue, 05 May 2009) | 1 line

Re #3657, updated Brazilian Portuguese language files

........