agi-bin/phpagi.php has hard coded paths

The proposed patch brings up some questions and issues. You are running parse_amportal_conf() and parse_asterisk_conf() from within the phpagi.php which does not necessarily have access to those functions (and normally does not) since this is a library used for AGI scripts. It's more likely to make the AGI script fail.

Furthermore, we do not want to be parsing the amportal.conf file every time an AGI script is run.

You will fine that the following globals are defined for all channels:

ASTETCDIR = /etc/asterisk
ASTMODDIR = /usr/lib/asterisk/modules                                                                                                                     
ASTVARLIBDIR = /var/lib/asterisk                                                                                                                          
ASTAGIDIR = /var/lib/asterisk/agi-bin                                                                                                                     
ASTSPOOLDIR = /var/spool/asterisk                                                                                                                         
ASTRUNDIR = /var/run/asterisk                                                                                                                             
ASTLOGDIR = /var/log/asterisk                                                                                                                             

which are parsed form the config files. If you want to propose a patch that pulls these out of the channel we can have a review. However, it may be tricky if data is needed from these prior to setting up the connections.

How will anything be fine when the paths are wrong ?

ASTETCDIR = /etc/asterisk is /usr/local/etc/asterisk ASTMODDIR = /usr/lib/asterisk/modules is /usr/local/lib/asterisk ASTVARLIBDIR = /var/lib/asterisk is /usr/local/share/asterisk ASTAGIDIR = /var/lib/asterisk/agi-bin is /usr/local/share/asterisk/agi-bin

and I don't actualy see the problem every agi script to read the conf. Every program reads some conf on execution why should agi scripts have hard coded paths ? Or should those paths be changed on install (which ofcourse can be overwriten on update) ?

tbyte,

you missed my point. We pass in the paths that are configured in amportal.conf into the above channel variables which are available by the agi script.

However - I applied the requested change from another ticket to php-asmanager.php (the one in ~admin/common) which resulted in multiple other broken components that had ripple affects. It broke ARI and generate_hints.php so far as I have found. I am tempted to put it back but will probably refrain for now and see if other issues are reported.

The dilemma of course here is that you need this file included first to get the AGI channel open in order to get those variables...

So ... I would suggest you come up with a solution that does not end up having to include all of the functions.inc.php or go parsing all of amportal.conf. One suggestion would be a modification of the form:

if (! @include "my_phpagi_override_file.conf") {
  // default values as currently exist
  define(...)
}

for now moving this to 2.7 pending some further decisions.