Ticket #3734 (closed Bugs: fixed)

Opened 1 year ago

Last modified 1 year ago

Client side CF when paging should be blocked

Reported by: p_lindheimer Assigned to:
Priority: minor Milestone: 2.6
Component: Paging & Intercom Version: 2.5-branch
Keywords: Cc:
Confirmation: Confirmed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

The issue is if a phone is paged that is client side forwarded. Either it should be blocked, or settable in the page group. If I'm not mistaken, server side CF is blocked, so if that is the case, then client side SHOULD be blocked to be consistent.

This should probably be done in the auto-answer macro so it effect intercom also, or should it be allowed with intercom??? If it should be allowed with intercom, then it should be in the top level before each context is called to be more performant.

I think the following is what is needed: 

Index: functions.inc.php
===================================================================
--- functions.inc.php   (revision 7826)
+++ functions.inc.php   (working copy)
@@ -366,6 +366,7 @@
                                foreach ($custom_vars as $key => $value) {
                                        $ext->add($extpaging, $grp, '', new ext_setvar('_'.ltrim($key,'_'), $value));
                                }
+                               $ext->add($extpaging, $grp, '', new ext_setvar('__FORWARD_CONTEXT', 'block-cf'));
 
                                $ext->add($extpaging, $grp, '', new ext_page($dialstr));
                        }

Change History

06/22/09 13:12:31 changed by p_lindheimer

oops the above patch is for a 2.6 system, for 2.5 the patch would be: 

Index: functions.inc.php
===================================================================
--- functions.inc.php   (revision 7758)
+++ functions.inc.php   (working copy)
@@ -322,6 +322,7 @@
                                $ext->add($extpaging, $grp, '', new ext_macro('user-callerid'));
                                // make AMPUSER inherited here, so we can skip the proper 'self' if using cidnum masquerading
                                $ext->add($extpaging, $grp, '', new ext_setvar('_AMPUSER', '${AMPUSER}'));
+                               $ext->add($extpaging, $grp, '', new ext_setvar('__FORWARD_CONTEXT', 'block-cf'));
                                $ext->add($extpaging, $grp, '', new ext_page($dialstr));
                        }

06/23/09 10:15:38 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [7858]) fixes #3734 set FORWARD_CONTEXT before paging to block client side CF

06/23/09 12:51:24 changed by p_lindheimer

(In [7860]) Merged revisions 7858-7859 via svnmerge from http://svn.freepbx.org/modules/branches/2.5

........

r7858 | p_lindheimer | 2009-06-23 10:15:37 -0700 (Tue, 23 Jun 2009) | 1 line

fixes #3734 set FORWARD_CONTEXT before paging to block client side CF

........

r7859 | p_lindheimer | 2009-06-23 12:40:39 -0700 (Tue, 23 Jun 2009) | 1 line

ref #3732 missing enclosing ()

........

06/23/09 13:23:03 changed by p_lindheimer

(In [7866]) Merged revisions 7807-7858 via svnmerge from http://svn.freepbx.org/modules/branches/2.5

........

r7812 | mickecarlsson | 2009-06-10 14:39:39 -0700 (Wed, 10 Jun 2009) | 1 line

Closes #3713 adds Russian language to weakpasswords. Thank you ded

........

r7854 | fskrotzki | 2009-06-20 19:53:20 -0700 (Sat, 20 Jun 2009) | 1 line

Fixes #3732 by removing the system context of zonemessages from the selection list

........

r7858 | p_lindheimer | 2009-06-23 10:15:37 -0700 (Tue, 23 Jun 2009) | 1 line

fixes #3734 set FORWARD_CONTEXT before paging to block client side CF

........

06/23/09 13:24:59 changed by p_lindheimer

(In [7867]) fixes #3734 block CF client side on paging