Ticket #3744 (closed Bugs: fixed)

Opened 3 years ago

Last modified 3 years ago

core_trunks_gettrunkroutes returns bogus information

Reported by: p_lindheimer Assigned to: p_lindheimer
Priority: trivial Milestone: 2.6
Component: Core - Trunks/Routing Version: 2.5-branch
Keywords: Cc:
Confirmation: Confirmed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

The function, core_trunks_gettrunkroutes, is suppose to return a hash which includes each route and the sequence number of that route as the value. This is currently only used to display the tool-tip on the trunk page of which routes are being used by a trunk.

The function is flawed in two ways:

  • it has the indices reversed when returning the hash so the number of routes are not even always correct.
  • it returns the priority of the call to dialout-trunk/enum/dundi from the old extensions table (which unfortunately is how routes are stored, sigh ... need to get this updated). As a result, the sequence number may not be right as the priority of the first call is not always 1.

This bug has been present since r3975 and thus effects all versions back to that era (which I believe is at least back to 2.3.

The effect is only visual, it does not effect functionality.

Change History

07/05/09 12:37:33 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

(In [7890]) fixes #3744 found a good way to get proper sequences without multiple ugly queries

07/05/09 12:39:33 changed by p_lindheimer

(In [7891]) Merged revisions 7890 via svnmerge from http://svn.freepbx.org/modules/branches/2.5

........

r7890 | p_lindheimer | 2009-07-05 10:37:32 -0700 (Sun, 05 Jul 2009) | 1 line

fixes #3744 found a good way to get proper sequences without multiple ugly queries

........

07/05/09 12:40:39 changed by p_lindheimer

(In [7892]) Merged revisions 7890 via svnmerge from http://svn.freepbx.org/modules/branches/2.5

........

r7890 | p_lindheimer | 2009-07-05 10:37:32 -0700 (Sun, 05 Jul 2009) | 1 line

fixes #3744 found a good way to get proper sequences without multiple ugly queries

........

07/05/09 12:45:32 changed by p_lindheimer

(In [7893]) Merged revisions 7892 via svnmerge from http://svn.freepbx.org/modules/branches/2.4

................

r7890 | p_lindheimer | 2009-07-05 10:37:32 -0700 (Sun, 05 Jul 2009) | 1 line

fixes #3744 found a good way to get proper sequences without multiple ugly queries

................