Ticket #4228 (new Feature Requests)

Opened 3 years ago

Last modified 3 years ago

Basic (FollowMe) loop detection

Reported by: pwalker Assigned to: p_lindheimer
Priority: minor Milestone: Undetermined
Component: Core Version: 2.7-branch
Keywords: loop follow me cf Cc:
Confirmation: Need Feedback Distro:
Backend Engine: All Distro Ver:
Backend Ver: SVN Revision (if applicable): 9537

Description

Changeset 8174 introduced some basic loop detection for Call Forward.

However, there are still cases where you'll get an immediate loop when FollowMe (and DND) is used (e.g. 11 calls 12 and 12 has 11 in its grplist). (Which I - or our customers - don't particularly like...)

I modified dialparties.agi so that the caller's extension is not added to the extension map in such cases.

It's more like a draft/sketch, not a production-ready patch!

- Not well-tested
- Doesn't currently work if '#' is appended to the extension (Well - should it?)
- Should this behaviour be configurable?
- There may be side effects...?

Is there any interest for this? (If there is and there is a chance to get this into FreePBX 2.x, I'll try to provide a better patch!)

Implementation note: I've moved the variables introduced in Changset 8174 ($realcalleridnum, $blindtransfer and $ampuser) up a bit to be able to use them earlier in dialparties.agi (and changed som spaces to tabs in that changeset's code to have better readable code there).

Attachments

loopdetection-0.diff (2.3 kB) - added by pwalker on 04/21/10 12:31:52.
Patch against 2.7 svn (experimental, see description)

Change History

04/21/10 12:31:52 changed by pwalker

  • attachment loopdetection-0.diff added.

Patch against 2.7 svn (experimental, see description)

04/21/10 12:38:25 changed by pwalker

  • svn_rev set to 9537.

05/25/10 16:07:39 changed by p_lindheimer

  • confirmation changed from Unreviewed to Need Feedback.

pwalker,

if I am reading this patch correctly it would appear it is not letting an extension call it-self? Is that correct? (And if so - that is a problem).

05/26/10 02:55:19 changed by pwalker

Philippe,

Sorry, I didn't yet have time to work on this. If I remember correctly, if an extension is trying to call itself, that is detected to be a loop and prevented. Sorry, if this is going to break something, then I will change or withdraw the patch, but I still can't see a reason (other creating a loop) where an extension should want to call itself. Thanks for any clarification! Philipp

05/26/10 10:49:35 changed by p_lindheimer

pwalker,

two cases. One is simple testing a system (calling yourself, will ring the other line). Another case is 'calling yourself' when you have multiple devices connected to the same user, as it will ring the other devices.

06/01/10 17:13:44 changed by p_lindheimer

  • milestone changed from 2.8 to Cut Line.

pushing this out since any changes inside of dialparties would need a longer cycle for testing then will be left for 2.8 - and this still appears un-resolved.