Ticket #4335 (closed Feature Requests: fixed)

Opened 2 years ago

Last modified 2 years ago

Make Custom Contexts compatible with FreePBX 2.8

Reported by: mbrevda Assigned to: mbrevda
Priority: minor Milestone: 2.8
Component: Custom Context Version: 2.7-branch
Keywords: Cc:
Confirmation: Confirmed SVN Revision (if applicable):
Backend Engine: All Backend Engine Version:

Description

As per: http://www.freepbx.org/forum/freepbx/users/custom-contexts-module-upgrade-updated-info

Change History

06/13/10 05:43:31 changed by mbrevda

(In [9820]) re #4335; working draft of Custom Context to FreePBX 2.8 compatability upgrade. Please report bugs to THIS ticket (#4335)

06/14/10 12:51:15 changed by mbrevda

(In [9828]) re #4335 some bug fixes. MIGRATION CODE IS STILL UNTESTED!!! PLEASE REPORT BUGS TO #4335!!!

06/14/10 12:52:13 changed by mbrevda

(In [9829]) re #4335 version bump

06/14/10 13:29:50 changed by p_lindheimer

  • owner changed from p_lindheimer to mbrevda.
  • component changed from - choose - to Other Module.

When creating/editing/viewing a custom context, the Outbound Routes section should be either:

  • Always in the order of the Outbound Routes
  • Always in the order of the assigned priorities

The latter would probably be the best and could be made consistent with all the other sections, but at a minimum at least the default order of the Outbound Routes.

I believe in the past these appeared in order because the context names had sequential numbers in them to force that order. Since Outbound Route manipulation is one of the most common uses of this module, that section should have an order that makes some logical sense thus the two bullet options above.

Which ever is chosen, the secondary sort key used in Custom Context should result in the same order that will be generated in the dialplan assuming you set all priorities the same.

06/16/10 04:06:21 changed by mbrevda

(In [9839]) re #4335 - update migration code, added migration for time conditions (not fully tested), remove time condition, version bump

06/16/10 04:07:01 changed by mbrevda

(In [9840]) re #4335 - remove timecondition page

06/16/10 11:51:34 changed by mbrevda

(In [9843]) re #4335 refine code

06/17/10 14:59:06 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.
  • confirmation changed from Unreviewed to Confirmed.
  • component changed from Other Module to Custom Context.
  • type changed from Bugs to Feature Requests.

Please open issues relating to this port in new tickets. The initial port and migration code has been checked in and published.

06/18/10 10:28:02 changed by mbrevda

(In [9874]) re #4335 - sort contexts based on the order in which they get generated by freepbx

06/18/10 12:04:36 changed by p_lindheimer

(In [9875]) tweak moshe's change to keep outbound route orders conisten with route seq when pri is equal, bump up num of possible priorities to accmodate lots of new modules, minor tweaks re #4335