Ticket #4369 (closed Bugs: fixed)

Opened 3 years ago

Last modified 3 years ago

Upgrade custom contexts removes routes

Reported by: john@erba.tv Assigned to: mbrevda
Priority: blocker Milestone: 2.8
Component: Custom Context Version: 2.8-branch
Keywords: upgrade custom contexts Cc:
Confirmation: Need Feedback Distro:
Backend Engine: Asterisk 1.6 Distro Ver:
Backend Ver: 1.6.2.9 SVN Revision (if applicable):

Description

After upgrading to freepbx 2.8 and applying latest update 2.8.0beta1.4 for custom contexts, the custom outbound routes I had defined were set to Deny. I had to edit them manually to Allow. I don't know whether this was a consequence of the 2.8 update or the custom contexts update. I only noticed it after having completed both. Although easy to work around, I have put as blocker because if it is a generalized problem then previously working routes will stop working upon update. Unfortunately my manual correction of the problem has destroyed most of the evidence, however a db backup between the two operations shows that on updating freepbx, table customcontexts_includes has this in column "include": "outrt-030-custom_john". After the correction in GUI the result is "outrt-30".

Change History

06/23/10 11:42:54 changed by p_lindheimer

  • confirmation changed from Unreviewed to Need Feedback.

John,

do you recall the exact sequence of what you did during the upgrade process, for example:

  1. Upgraded Framework
  2. Upgraded Core
  3. Applied Configuration Changes
  4. Upgraded all other modules
  5. Applied Configuration changes

As much of the exact sequence as you can remember at the above level of details would be very beneficial to determine the issue, in particular, if you did an Apply Configuration Changes after upgrading Core and prior to upgrading the Custom Context module.

06/23/10 22:53:03 changed by john@erba.tv

I carried out the sequence of clicking on the button in the upgrade tool, then upgraded Framework then upgraded other modules from the standard repositroy (but not custom contexts) then applied configuration changes.

After that I took another db backup, then later upgraded custom contexts and applied configuration changes. The reason for that is that the customcontext upgrade was not showing as part of the upgrades needed (probably because it was not the standard repository) and I only became aware of the available new package later on.

06/24/10 15:32:49 changed by mbrevda

see also #4355

06/25/10 08:10:30 changed by mbrevda

(In [9917]) re #4369, migrate before the user can hit reload

06/25/10 08:12:28 changed by mbrevda

(In [9918]) re #4369, no need to migrate twice. Kludgy way of checking, but it works and is cleaner then saving the migration status somewhere

06/25/10 08:14:07 changed by mbrevda

This issue should be resolved, awaiting feedback (or calm quite) before closing.

06/25/10 11:02:08 changed by mbrevda

(In [9919]) re #4369, remove time condition migration, that should be done from thre CC module; also remove core_get_routes function to avoid any conflicts with the same function name further down the line

06/25/10 14:00:58 changed by p_lindheimer

  • status changed from new to closed.
  • resolution set to fixed.

this should be addressed by the above changes to be active with rc1 being worked on right now.

In the meantime, if one updates to 2.8 and refrains from applying configuration changes prior to updating customcontext, the migration will work (though this is very error prone thus the coming changes)

06/25/10 15:50:35 changed by p_lindheimer

(In [9931]) remove route migrations from module now that done in framework update, I was wrong, doing them again could create problems here, re #4369

07/13/10 19:02:34 changed by p_lindheimer

(In [10122]) Merged revisions 9746-9768,9770-10121 via svnmerge from http://www.freepbx.org/v2/svn/freepbx/branches/2.8

................

r9750 | p_lindheimer | 2010-05-25 10:10:09 -0700 (Tue, 25 May 2010) | 1 line

closes #4256 make all versions of parse_amportal_conf() use the same preg_match() line using framework's functions.inc.php as authoritative

................

r9770 | mickecarlsson | 2010-05-26 11:17:11 -0700 (Wed, 26 May 2010) | 1 line

Reverted r7730 so that amportal setting SERVERINTITLE starts working again. See also #4299

................

r9771 | mbrevda | 2010-05-26 11:30:20 -0700 (Wed, 26 May 2010) | 1 line

re: #4300; bug fix for firefox. IE wont remember expanded state between page reload, everything else seems to be working.

................

r9772 | mickecarlsson | 2010-05-26 22:11:01 -0700 (Wed, 26 May 2010) | 1 line

Close #4299 adds hostname in header for gui

................

r9777 | p_lindheimer | 2010-05-28 11:34:16 -0700 (Fri, 28 May 2010) | 1 line

closes #4306 make lnav sections expandable/collapse-able

................

r9779 | p_lindheimer | 2010-05-29 09:33:15 -0700 (Sat, 29 May 2010) | 1 line

revert r9772 re #4299 we are not going to call hostname on every call in addition to it has the potential of messing up the display with an unknown length and could have other un-forseen consequences (and if we were going to do this, we should be using php gethostname() (and then defining a substitute for php versions that don't have that function

................

r9780 | p_lindheimer | 2010-05-29 10:01:36 -0700 (Sat, 29 May 2010) | 1 line

fixes #4307 unable to press apply configuration changes bar. Please open a new bug for IE, tested to work on FF, Safari, Chrome - so something is up with IE or there is some sort of bug/mis-matched html tag or something that the others are immune to...

................

r9781 | p_lindheimer | 2010-05-29 10:25:39 -0700 (Sat, 29 May 2010) | 1 line

fix some formatting so viewing source pages is easier, and adds a closing div that appeared to be missing

................

r9782 | p_lindheimer | 2010-05-29 10:51:30 -0700 (Sat, 29 May 2010) | 1 line

removes the div that was wrapping a group of li tags (I don't think you can do that) which was messing up IE, however IE still can not reload, the modal orange box never comes up, re #4307

................

r9784 | mickecarlsson | 2010-05-29 13:56:17 -0700 (Sat, 29 May 2010) | 1 line

Fixed spelling error

................

r9787 | p_lindheimer | 2010-05-30 09:26:29 -0700 (Sun, 30 May 2010) | 1 line

closes #4253 cleanup default amportal.conf file (note: the patch still did not apply but the full copy was used so it should be good but please confirm)

................

r9788 | p_lindheimer | 2010-05-30 10:45:15 -0700 (Sun, 30 May 2010) | 1 line

add title to categories saying they can click to expand/collapse the section

................

r9799 | p_lindheimer | 2010-06-01 13:06:54 -0700 (Tue, 01 Jun 2010) | 1 line

closes #4311 use freepbx_menu.conf to make modifications to left navigation menu, if file is not present then the code path remains unchanged

................

r9812 | p_lindheimer | 2010-06-02 10:22:00 -0700 (Wed, 02 Jun 2010) | 13 lines

Merged revisions 9634-9729,9733-9795,9798-9811 via svnmerge from http://www.freepbx.org/v2/svn/freepbx/branches/2.7

........

r9634 | p_lindheimer | 2010-05-14 07:10:47 -0700 (Fri, 14 May 2010) | 1 line

fixes #4269 enclose clid_format in quotes

........

r9811 | p_lindheimer | 2010-06-02 10:09:25 -0700 (Wed, 02 Jun 2010) | 1 line

fixes #4255 enclose the full set of searchstrings in ()

........

................

r9814 | p_lindheimer | 2010-06-02 13:19:02 -0700 (Wed, 02 Jun 2010) | 1 line

dont't run category through htmlspecialchars as only moh uses it, do it there since it breaks other things re: #4179

................

r9831 | p_lindheimer | 2010-06-15 10:34:02 -0700 (Tue, 15 Jun 2010) | 1 line

fixes #4345 fail an install when install.php or install.sql (or unintall versions) fails

................

r9833 | GameGamer?43 | 2010-06-15 12:02:29 -0700 (Tue, 15 Jun 2010) | 1 line

closes #4333 - check if outboundCID is set and it's not set to nothing

................

r9834 | GameGamer?43 | 2010-06-15 12:08:17 -0700 (Tue, 15 Jun 2010) | 1 line

closes #4331 - added ext_meetmeadmin class, to handle the management of meetme conferences from within freepbx

................

r9836 | p_lindheimer | 2010-06-15 13:09:42 -0700 (Tue, 15 Jun 2010) | 1 line

closes #4339 add displayconnects=no as default value, only helps with 1.6+

................

r9877 | p_lindheimer | 2010-06-18 12:22:07 -0700 (Fri, 18 Jun 2010) | 1 line

add template for freepbx_menu.conf allowing lnav manipulation from the defaults re #4311

................

r9891 | p_lindheimer | 2010-06-22 11:46:43 -0700 (Tue, 22 Jun 2010) | 1 line

fixes #4366 and fixes #4354 guielements should not be trying to do translations on passed in values, this should be done in the calling module prior to passing in the value

................

r9917 | mbrevda | 2010-06-25 05:10:30 -0700 (Fri, 25 Jun 2010) | 1 line

re #4369, migrate before the user can hit reload

................

r9919 | mbrevda | 2010-06-25 08:02:08 -0700 (Fri, 25 Jun 2010) | 1 line

re #4369, remove time condition migration, that should be done from thre CC module; also remove core_get_routes function to avoid any conflicts with the same function name further down the line

................

r9922 | p_lindheimer | 2010-06-25 11:09:36 -0700 (Fri, 25 Jun 2010) | 1 line

define sql() if not defined, some install methods does not have this function defined

................

r9933 | p_lindheimer | 2010-06-25 12:52:35 -0700 (Fri, 25 Jun 2010) | 1 line

Creating release 2.8.0rc1

................

r9958 | mickecarlsson | 2010-06-26 06:29:32 -0700 (Sat, 26 Jun 2010) | 1 line

Updated amp.pot

................

r9959 | mickecarlsson | 2010-06-26 06:30:59 -0700 (Sat, 26 Jun 2010) | 1 line

Added missing license text

................

r9960 | mickecarlsson | 2010-06-26 06:32:21 -0700 (Sat, 26 Jun 2010) | 1 line

Updated language tool

................

r9961 | p_lindheimer | 2010-06-26 09:17:47 -0700 (Sat, 26 Jun 2010) | 1 line

closes #4376 setting repository select box to extended if such modules are present, also changes 'type' form tool to what ever is currently selected

................

r9967 | mickecarlsson | 2010-06-27 03:17:51 -0700 (Sun, 27 Jun 2010) | 1 line

Updated amp.pot with latest changes

................

r9970 | mickecarlsson | 2010-06-27 10:02:16 -0700 (Sun, 27 Jun 2010) | 1 line

Updated all amp languages for 2.8

................

r9977 | p_lindheimer | 2010-06-28 11:20:44 -0700 (Mon, 28 Jun 2010) | 1 line

fixes #4382 enapsulate symlinking/copying into a class with error reporting at end

................

r9985 | p_lindheimer | 2010-06-28 18:37:10 -0700 (Mon, 28 Jun 2010) | 1 line

fixes #4386 don't generate an orphaned basetag if no extenions exists, fail at that point instead

................

r9999 | p_lindheimer | 2010-06-29 14:49:29 -0700 (Tue, 29 Jun 2010) | 1 line

fixes #4389 dahdi compatibility mode broken, 1.4 still has legacy zap applications even when in DAHDI mode so can't count on those

................

r10003 | p_lindheimer | 2010-06-30 08:47:03 -0700 (Wed, 30 Jun 2010) | 1 line

include module js files after all the standard js files as they will typically require things like standard jquery libraries, etc.

................

r10005 | p_lindheimer | 2010-06-30 14:11:31 -0700 (Wed, 30 Jun 2010) | 1 line

perl version no longer used

................

r10007 | p_lindheimer | 2010-06-30 14:36:30 -0700 (Wed, 30 Jun 2010) | 1 line

make freepbx_featurecodes.conf a template so it does not get read every time unless use is using it

................

r10010 | p_lindheimer | 2010-06-30 15:16:06 -0700 (Wed, 30 Jun 2010) | 1 line

fixes #4388 don't symlink from other fw_fop, fw_ari, fw_langpack modules, they are like framework also re #4382 leftover code deleted

................

r10027 | mickecarlsson | 2010-07-03 01:48:04 -0700 (Sat, 03 Jul 2010) | 1 line

amportal.conf: small spelling error

................

r10028 | p_lindheimer | 2010-07-03 09:35:06 -0700 (Sat, 03 Jul 2010) | 1 line

remove warning from incorrect (but harmless) call to connectdirs::create() re #4400

................

r10037 | mickecarlsson | 2010-07-07 01:07:26 -0700 (Wed, 07 Jul 2010) | 1 line

Re #4402 change from split to explode in callmonitor.module

................

r10038 | p_lindheimer | 2010-07-07 14:44:25 -0700 (Wed, 07 Jul 2010) | 1 line

if destination file is a different symlink or an actual file, and the md5 of the files are identical, then don't complain, just write out an error log re #4388

................

r10040 | p_lindheimer | 2010-07-07 14:54:28 -0700 (Wed, 07 Jul 2010) | 9 lines

Merged revisions 10019 via svnmerge from http://www.freepbx.org/v2/svn/freepbx/branches/2.7

........

r10019 | p_lindheimer | 2010-07-01 07:12:54 -0700 (Thu, 01 Jul 2010) | 1 line

fixes #4185 use DAHDI channels when compatibility mode is used

........

................

r10041 | mbrevda | 2010-07-08 03:07:17 -0700 (Thu, 08 Jul 2010) | 1 line

closes #4403; symlink ari_modules dir on reload

................

r10044 | p_lindheimer | 2010-07-08 10:45:30 -0700 (Thu, 08 Jul 2010) | 1 line

create 2.8.0 release dir and migration script to add preloads if needed to modules.conf re #3963 and re #4411

................

r10045 | mickecarlsson | 2010-07-08 11:54:17 -0700 (Thu, 08 Jul 2010) | 1 line

Fixes typo

................

r10047 | mickecarlsson | 2010-07-08 12:00:17 -0700 (Thu, 08 Jul 2010) | 1 line

Fix that typo again

................

r10050 | p_lindheimer | 2010-07-08 12:19:33 -0700 (Thu, 08 Jul 2010) | 1 line

change struture for ari module symlinks to accomodate other assets re #4403

................

r10053 | p_lindheimer | 2010-07-09 09:32:37 -0700 (Fri, 09 Jul 2010) | 1 line

fixes #4413 don't change permissions on hidden folders in ASTVARLIBDIR to keep from affecting anything in the .ssh folder

................

r10054 | p_lindheimer | 2010-07-09 16:53:14 -0700 (Fri, 09 Jul 2010) | 1 line

closes #4418 adds ability for modules to include js scripts into the <head> of the page

................

r10055 | p_lindheimer | 2010-07-09 23:21:44 -0700 (Fri, 09 Jul 2010) | 1 line

keep apply config bar from fading if DEVELRELOAD is set

................

r10100 | mbrevda | 2010-07-12 02:50:42 -0700 (Mon, 12 Jul 2010) | 1 line

closes #4423; dont display a blamk page in ari if fm is not enabled

................

r10101 | mbrevda | 2010-07-12 02:53:02 -0700 (Mon, 12 Jul 2010) | 1 line

closes #4423; dont display a blamk page in ari if fm is not enabled

................

r10108 | p_lindheimer | 2010-07-13 08:30:28 -0700 (Tue, 13 Jul 2010) | 1 line

provide the src module when reporting symlink errors

................

r10109 | p_lindheimer | 2010-07-13 09:58:44 -0700 (Tue, 13 Jul 2010) | 1 line

use the extended repository when checking modules if Third Party Modules are present (used by automatic update checker), re #4376 and will also help re #4385 since the modules will show as new if the normal repository is ever checked followed by the extended repository

................

r10111 | p_lindheimer | 2010-07-13 15:53:18 -0700 (Tue, 13 Jul 2010) | 1 line

Creating release 2.8.0

................